----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130228/#review103611 -----------------------------------------------------------
Ship it! Looks OK. Nice code duplication, but ok, this is kdelibs4support, not worth refactoring. PS: Please use phabricator, we're told reviewboard is on the way out. - David Faure On Aug. 16, 2017, 1:14 p.m., Ralf Habacker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130228/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2017, 1:14 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs4support > > > Description > ------- > > Mingw32 compile fix > > > Diffs > ----- > > src/solid/networking_p.h 894f2fa9259ed3626c6a5e10970eca55afa8cd79 > src/solid/networking_win.cpp 354ab3acf6e0d771907792270f209394065ae94b > > Diff: https://git.reviewboard.kde.org/r/130228/diff/ > > > Testing > ------- > > > Thanks, > > Ralf Habacker > >
