BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/43/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 02 Aug 2017 06:23:15 +
Build duration:
28 min and counting
JUnit Tests
mlaurent updated this revision to Diff 17535.
mlaurent added a comment.
Use a correct license (I copied a header from david class so I think it's ok
now) as in kwidgetaddons there is lgpl2 lgpl2.1 lgpl3 lgpl...
I didn't change ui file a QWidget otherwise we can't see qlineedit in
designe
mlaurent added inline comments.
INLINE COMMENTS
> kossebau wrote in knewpasswordwidget.ui:88
> rather extends QWidget now? unsure what exactly the consequences are
The consequence is that we don't see it in designer :)
So why not but it's better to show a lineedit no ?
> kossebau wrote in kpass
kossebau added inline comments.
INLINE COMMENTS
> knewpasswordwidget.ui:88
> + KPasswordLineEdit
> + QLineEdit
> + kpasswordlineedit.h
rather extends QWidget now? unsure what exactly the consequences are
> kpassworddialog.ui:163
> + KPasswordLineEdit
> + QLineEdit
> + kpasswordlinee
mlaurent updated this revision to Diff 17533.
mlaurent added a comment.
Fix copyright
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17471&id=17533
REVISION DETAIL
https://phabricator.kde.org/D7011
AFFECTED FILES
autotests/CMakeLists.txt
autotests/knewpasswordwidgette
apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Check the capabilities and if it can't be suspended, don't even
show the button
TEST PLAN
Albert sent me several files over kdeconnect
REPOSITORY
R288 KJobWidgets
BRANCH
master
REVISION D
apol added a comment.
+1
I confirm KDE Connect still works through the QNAM abstraction without going
crazy calling `slotDataReqFromDevice`.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7045
To: aacid
Cc: apol, #frameworks
cfeck added a comment.
Interesting. When I RMB-click on a folder in Dolphin, I indeed see "Delete
File" in the context menu, but I do not see "Rename File", but "Rename ..."
instead. Does Dolphin not use standard actions consistently?
+1 from my side.
REPOSITORY
R265 KConfigWidgets
R
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
We don't need to call ourselves every time to see if the data transfer
finished,
the iodevice will signal us thorough readChannelFinished wh
vkrause updated this revision to Diff 17513.
vkrause added a comment.
Add explicit option to disable the widget dependency.
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6990?vs=17379&id=17513
BRANCH
sonnet-no-widget
REVISION DETAIL
https://phabricato
dvratil created this revision.
dvratil added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
When lastUrl = "file:///folder/" and currentUrl = "file:///folder" then
currentUrl.isParentOf(lastUrl)
returns true, which causes the code to hit an asse
chinmoyr added inline comments.
INLINE COMMENTS
> dfaure wrote in filehelper.cpp:86
> opendir can return 0, in which case the next line will probably crash.
>
> Overall, this whole method seriously lacks error handling in my opinion. Just
> checking for errno at the end isn't enough, e.g. in ca
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:2bf92ff35886: Adding support to ipv*.route-metric
(authored by jgrulich).
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6687?vs=16836&id=17508
REVISION D
chinmoyr updated this revision to Diff 17507.
chinmoyr added a comment.
- used switch..case
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=17013&id=17507
REVISION DETAIL
https://phabricator.kde.org/D6197
AFFECTED FILES
src/ioslaves/file/CMakeLists.txt
src/ioslaves/fil
chinmoyr added a comment.
ping @thiago
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6709
To: chinmoyr, thiago, #frameworks
Cc: davidedmundson, elvisangelaccio, shortstheory
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6894
To: broulik, #plasma, mart
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, j
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/26/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Tue, 01 Aug 2017 15:52:49 +
Build duration:
57 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/24/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 01 Aug 2017 15:52:01 +
Build duration:
34 sec and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/25/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Tue, 01 Aug 2017 15:51:51 +
Build duration:
56 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/24/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Tue, 01 Aug 2017 15:42:45 +
Build duration:
1 min 4 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/23/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 01 Aug 2017 15:42:45 +
Build duration:
37 sec and counting
JUnit Tests
Nam
subdiff added a comment.
I'm currently on a tight time budget, so this will need to wait a little bit.
I'll roll with the change on my machine for a while and if everything works
fine add a unit test in the end.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
graesslin added inline comments.
INLINE COMMENTS
> surface_interface.cpp:841
>
> +SurfaceInterface *SurfaceInterface::inputSurfaceAt(const QPointF &position)
> +{
Could you try to share the logic between surfaceAt and inputSurfaceAt methods?
I cannot spot a difference except the method it cal
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please verify that this does not break Qt! (Qt has a very special handling of
subsurfaces and we have lots of workarounds for Qt there)
Also please add a unit test which
subdiff created this revision.
subdiff added a project: Plasma on Wayland.
Restricted Application added a subscriber: plasma-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
I noticed that while working on my GSoC Xwayland project and using
sub-surfaces with empty inp
ltoscano added a reviewer: ilic.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D7033
To: carewolf, ilic
Cc: #frameworks
carewolf created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Moves away from the deprecated QtScript module
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D7033
Notes from the KDeclarative/PlasmaComponents BoF:
CC'ing frameworks devel even though there's a good chance that it won't
make much sense unless you follow Plasma development.
About:
Since KF5.0 lots has changed. QtQuickControls2 was made, Q_GADGET was made,
Kirigami happened and more.
We've ende
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/22/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 01 Aug 2017 10:56:08 +
Build duration:
1 min 34 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/23/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Tue, 01 Aug 2017 10:56:08 +
Build duration:
1 min 10 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:d85a57645f94: Standard shortcuts: use
Ctrl+PageUp/PageDown for prev/next tab. (authored by dfaure).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6553?vs=16335&id=17473#toc
REPOSITORY
R237
mlaurent updated this revision to Diff 17471.
mlaurent added a comment.
Rename method as lineEdit as requested by David
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7011?vs=17470&id=17471
REVISION DETAIL
https://phabricator.kde.org/D7011
AFFECTED FILES
autotests/CMakeLists.tx
mlaurent retitled this revision from "Extract lineedit password" to "Extract
KPasswordLineEdit class".
REVISION DETAIL
https://phabricator.kde.org/D7011
To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks
33 matches
Mail list logo
