aacid added a comment.
Any reason not pushed?
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5788
To: nalvarez, #kate, jkt, dhaumann
Cc: aacid, dhaumann, jkt, #frameworks
Kanedias updated this revision to Diff 15553.
Kanedias added a comment.
Fixed KWAYLAND -> Kwayland in CmakeLists.txt
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1231?vs=15125&id=15553
REVISION DETAIL
https://phabricator.kde.org/D1231
AFFECTED FILES
Kanedias added a comment.
@davidedmundson , do we really have nativeResourceForScreen call? AFAIK KWin
uses its own QPA, which implements only bits of functionality. We need to have
nativeResourceForScreen to be able to pass wl_output, should I patch QPA also,
or is there better way?
REPOSI
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Polkit-1 has the a concept of persistence, under a different name. A policy
can be set to:
- auth_admin
- auth_admin_keep
policy-gen-polkit1.cpp chooses
dfaure added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kkeysequencewidget.cpp:778
> Should this section be using ShiftModifier? Qt::SHIFT has been masked out
qglobal.h: SHIFT = Qt::ShiftModifier
so it's the same (in case your sentence was making a difference about the t
elvisangelaccio added inline comments.
INLINE COMMENTS
> davidedmundson wrote in file.actions:5
> We don't want session persistence
>
> It would mean if you prompt the user to delete a file, any rogue plugin in
> Dolphin can now remove any file without prompts.
> We don't want session persiste
davidedmundson added inline comments.
INLINE COMMENTS
> file.actions:5
> +Policy=auth_admin
> +Persistence=session
We don't want session persistence
It would mean if you prompt the user to delete a file, any rogue plugin in
Dolphin can now remove any file without prompts.
> helper.cpp:46
> +
davidedmundson added inline comments.
INLINE COMMENTS
> kkeysequencewidget.cpp:778
> if (keyQt) {
> if ((keyQt == Qt::Key_Backtab) && (d->modifierKeys & Qt::SHIFT))
> {
> keyQt = Qt::Key_Tab | d->modifierKeys;
Should this section be using ShiftModifier? Qt
dfaure added a comment.
I'm completely agree about being careful, as long as it's not the point of
not fixing bugs :-)
If you can think of more shortcuts that I should check, I'm happy to add them
to the unittest and test them with kglobalaccel.
REPOSITORY
R268 KGlobalAccel
REVISION
dfaure added inline comments.
INLINE COMMENTS
> graesslin wrote in kkeyserver.cpp:976-980
> This is a special handling from KGlobalAccel. Are you sure it belongs into
> the generic implementation?
I would say yes, because e.g. Ctrl+& (on qwerty) is going to include Shift no
matter which applic
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
KQuickControls contains a copy of KSequenceWidget but with the UI
handled by a QtQuickControls based QML file.
This syncs the r
graesslin added inline comments.
INLINE COMMENTS
> kkeyserver.cpp:976-980
> +if (*keyQt != Qt::Key_Tab) { // KKeySequenceWidget does not map
> shift+tab to backtab
> +static const int FirstLevelShift = 1;
> +keySymX = xcb_key_symbols_get_keysym(symbols, e->detail,
graesslin added a comment.
> Man it's demotivating to contribute to KDE. Users say all sorts of bad
things about KDE, and then future-ex-maintainers reject your contribution.
Great.
Yes sure, and you can imagine how many angry mails and bug reports I get when
things break. I made the ex
13 matches
Mail list logo
