D5656: Adds method to force the reloading of a document

2017-05-01 Thread Nicolás Alvarez
nalvarez added a comment. I'm pretty sure this breaks ABI by adding a new virtual function... If an application was compiled against a previous version of KTextEditor and calls `documentSave()`, when run with a newer KTextEditor version (with this patch) it may end up calling the new `docume

D4051: kcm_useraccount is dead, long live user_manager

2017-05-01 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R263:8f81a80f5dd9: kcm_useraccount is dead, long live user_manager (authored by heikobecker). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4051?vs=9935&id=14061 REVIS

Re: KWallet::openWallet and 0-WinId ?

2017-05-01 Thread Albert Astals Cid
El dilluns, 1 de maig de 2017, a les 17:33:00 CEST, Martin Koller va escriure: > Hi, > > the Wallet::openWallet() documentation says for the WinId argument: > "The window id to associate any dialogs with. You can pass 0 if you don't > have a window the password dialog should associate with." > >

D4051: kcm_useraccount is dead, long live user_manager

2017-05-01 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D4051 To: heikobecker, #frameworks, aacid

KWallet::openWallet and 0-WinId ?

2017-05-01 Thread Martin Koller
Hi, the Wallet::openWallet() documentation says for the WinId argument: "The window id to associate any dialogs with. You can pass 0 if you don't have a window the password dialog should associate with." However passing 0 gives a runtime warning qDebug() << "Pass a valid window to KWalle

KConfigDialogManager and QButtonGroup

2017-05-01 Thread Martin Koller
Hi, trying to fix https://bugs.kde.org/show_bug.cgi?id=378930 I see that the mboxresource has a configuration dialog which uses KConfigDialogManager to handle the settings, but it has a QGroupBox widget holding QRadioButtons, which represent one setting (e.g. one of 2 possible compaction methods

Re: Review Request 128958: Add application/x-openvpn-profile mime type

2017-05-01 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128958/#review103166 --- ping - Lamarque Souza On Sept. 20, 2016, 11:59 a.m., Kai

D4051: kcm_useraccount is dead, long live user_manager

2017-05-01 Thread Heiko Becker
heikobecker added a comment. Ping? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D4051 To: heikobecker, #frameworks