nalvarez added a comment.

  I'm pretty sure this breaks ABI by adding a new virtual function... If an 
application was compiled against a previous version of KTextEditor and calls 
`documentSave()`, when run with a newer KTextEditor version (with this patch) 
it may end up calling the new `documentReload(ReloadDocument)`. With garbage in 
the first argument.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5656

To: pedroarthurp, dfaure, brauch, dhaumann, cullmann
Cc: nalvarez, kwrite-devel, #frameworks

Reply via email to