D4972: Start drag with press and hold on touch events

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This patch consists of two changes: - starting drags on press and hold - not starting drags when the event

D4847: KAuth integration in document saving

martinkostolny marked 7 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexteditor Cc: apol, dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #framewor

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12272. martinkostolny added a comment. Thanks a sorry for all the rookie mistakes. I tried to fix the problems You mentioned: - QT->Qt - get rid of useless streams - no more setting permissions and sync-to-disk when using QSaveFile - usin

D4968: Mac OS (X) has a POSIX-compliant /bin/sh too

rjvbb created this revision. rjvbb added a project: Frameworks. REVISION SUMMARY Apple also ships a POSIX-compliant /bin/sh, which is in fact a copy of /bin/bash . Some relevant links: https://developer.apple.com/library/prerelease/content/documentation/OpenSource/Conceptual/ShellScript

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 373 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/373/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 07 Mar 2017 15:57:22 + Build duration: 3 min 13 sec CHANGE SET Revision

D4925: actually delete old theme caches

This revision was automatically updated to reflect the committed changes. mart marked 2 inline comments as done. Closed by commit R242:bbcb217b4812: actually delete old theme caches (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.k

D4925: actually delete old theme caches

davidedmundson added inline comments. INLINE COMMENTS > theme_p.cpp:271 > +for (const QFileInfo &file : cacheDir.entryInfoList()) { > +if (!file.absoluteFilePath().endsWith(svgElementsFileName)) { > +QFile::remove(file.absoluteFilePath()); do we not want if (

D4925: actually delete old theme caches

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4925 REVISION DETAIL https://phabricator.kde.org/D4925 To: mart, #plasma, sitter Cc: sitter, apol, plasma-devel, #fr

D4925: actually delete old theme caches

mart updated this revision to Diff 12262. mart added a comment. use QFileInfo REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4925?vs=12133&id=12262 BRANCH arcpatch-D4925 REVISION DETAIL https://phabricator.kde.org/D4925 AFFECTED FI

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 461 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/461/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Mar 2017 11:53:57 + Build duration: 23 min CHANGE SET Revision 9f203f0e0cb5172bc5c39292c90ab2824d5e5190

D4937: Add KFileWidget::setSelectedUrl()

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. Yes, but constructing a relative QUrl isn't really that easy to do (definitely not obvious at that) and so future users will either pass a filename with QUrl(filename) (broken) or s

D4937: Add KFileWidget::setSelectedUrl()

dfaure added a comment. I thought about it, but the call sites I found didn't actually need that. So unless you know of one, I changed my mind to "let's wait for someone to request it". Although I guess it won't happen because people will just pass a QUrl instead ;-) REPOSITORY R241 KIO

D4847: KAuth integration in document saving

apol added inline comments. INLINE COMMENTS > dfaure wrote in katetextbuffer.cpp:904 > use .insert() to avoid the creation of a temporary. Or better use an initializer list? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexted

D4917: [Breeze Plasma Theme] Improve action-overlay icons

broulik added a comment. > only a draft based on the old design with the new semantic. The graphic is missing some states (add-hover, add-pressed, open-normal, open-hovered, remove-hover, remove-pressed). Not a fan of having a blue remove icon. Also, I was told the arrow isn't a particul

D4937: Add KFileWidget::setSelectedUrl()

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Looks good to me, although a new setSelectedFilename method would be nice to have REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D4937 To: dfaure, fvog

D4937: Add KFileWidget::setSelectedUrl()

dfaure updated this revision to Diff 12255. dfaure added a comment. deprecate setSelection REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4937?vs=12170&id=12255 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4937 AFFECTED FILES autotests/kf

D4937: Add KFileWidget::setSelectedUrl()

dfaure added a comment. I just found that this bug was very likely introduced by the fix for https://bugs.kde.org/show_bug.cgi?id=369216, proving that a method that takes a badly defined QString leads to some code (kdialog) calling it with a path and other code (filedialog integration plugin

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 6, 2017, 11:38 p.m., Aleix Pol Gonzalez wrote: > > src/ioslaves/file/file.cpp, line 1378 > > > > > > I'm not convinced, what's the point of requestroot? Why don't you let > > it call the action right

D4847: KAuth integration in document saving

dfaure added a comment. Right the only way to get atomic renaming is to write the tempfile next to its final destination, NOT in /tmp. (just like QSaveFile does ;) INLINE COMMENTS > katesecuretextbuffer.cpp:74 > +/** > + * There is no atomic rename operation publicly exposed by QT.