fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed.
Yes, but constructing a relative QUrl isn't really that easy to do (definitely not obvious at that) and so future users will either pass a filename with QUrl(filename) (broken) or store the absolute path themselves, which is unnecessary memory use and more complicated. I just noticed that with KIOFILEWIDGETS_NO_DEPRECATED defined the header file will not include the declaration but the cpp file still has the definition of the method, so it won't compile... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4937 To: dfaure, fvogt Cc: fvogt, #frameworks
