Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127911/ --- (Updated May 17, 2016, 8:55 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 127923: Add support for custom emoticon sizes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127923/ --- (Updated May 17, 2016, 5:27 a.m.) Review request for KDE Frameworks and D

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 43 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 01:07:47 + Build duration: 2 min 30 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 43 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 01:07:47 + Build duration: 2 min 30 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 37 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 01:06:22 + Build duration: 51 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 37 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 01:06:22 + Build duration: 51 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Re: Review Request 127865: Check size of unix domain socket path before copying to it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127865/ --- (Updated May 17, 2016, 12:25 a.m.) Status -- This change has been ma

Re: Review Request 127941: Kio fish: cannot process any file or diretory having a non-latin1 name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127941/ --- (Updated May 16, 2016, 10:05 p.m.) Status -- This change has been ma

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127911/#review95520 --- CMakeLists.txt (line 24)

Re: Review Request 127941: Kio fish: cannot process any file or diretory having a non-latin1 name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127941/#review95518 --- Ship it! I wish this awful E() macro was a function, it wo

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127935/ --- (Updated May 16, 2016, 10:26 p.m.) Status -- This change has been ma

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated May 16, 2016, 9:49 p.m.) Review request for KDE Software on Mac

Re: Review Request 127941: Kio fish: cannot process any file or diretory having a non-latin1 name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127941/ --- (Updated mai 16, 2016, 7:49 après-midi) Review request for KDE Frameworks

Review Request 127941: bug 357870: in kio fish, cannot process any file or diretory having a non-latin1 name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127941/ --- Review request for KDE Frameworks. Bugs: 357870 https://bugs.kde.org/

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127935/#review95515 --- Ship it! Ship It! - Elvis Angelaccio On May 16, 2016, 5

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127935/#review95514 --- Ship it! Ship It! - Burkhard Lück On Mai 16, 2016, 5:59

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127935/ --- (Updated Mag. 16, 2016, 7:59 p.m.) Review request for Documentation, KDE

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127935/ --- (Updated Mag. 16, 2016, 7:58 p.m.) Review request for Documentation, KDE

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

> On Mag. 16, 2016, 11:41 a.m., Elvis Angelaccio wrote: > > KF5DocToolsMacros.cmake, lines 47-49 > > > > > > Maybe update this sentence as well? "... index.docbook is installed > > using KDOCTOOLS_CREATE_HANDBOOK

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

> On Mag. 16, 2016, 11:41 a.m., Elvis Angelaccio wrote: > > KF5DocToolsMacros.cmake, lines 47-49 > > > > > > Maybe update this sentence as well? "... index.docbook is installed > > using KDOCTOOLS_CREATE_HANDBOOK

Re: Review Request 127843: Properly remove composed characters

> On Kvě. 7, 2016, 9:40 dop., Dominik Haumann wrote: > > I can see that the patch works, since Qt's QTextLayout functions are used > > for cursor navigation. > > > > I dislike the part that exposes the "currentTextLayout()", since it exposes > > more API (but ok, maybe we must), and it is not

Re: Review Request 127843: Properly remove composed characters

> On Kvě. 7, 2016, 9:40 dop., Dominik Haumann wrote: > > I can see that the patch works, since Qt's QTextLayout functions are used > > for cursor navigation. > > > > I dislike the part that exposes the "currentTextLayout()", since it exposes > > more API (but ok, maybe we must), and it is not

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 37 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 May 2016 16:04:16 + Build duration: 5 min 12 sec CHANGE SET Revision 75a55d449f2f070c5410e47

Re: Review Request 127929: K4TimeZoneWidget: flag images not displayed because of incorrect path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127929/ --- (Updated May 16, 2016, 6:03 p.m.) Status -- This change has been mar

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!

On Monday 16 May 2016, David Faure wrote: > On Saturday, May 14, 2016 10:52:16 AM CEST no-re...@kde.org wrote: > > GENERAL INFO > > > > BUILD UNSTABLE > > Build URL: > > https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/ > > PLATFORM=Linux,Variation=All,compiler=gcc/44/ Project

Review Request 127940: Rename docs/plasmapkg directory to docs/plasmapkg2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127940/ --- Review request for KDE Frameworks, Localization and Translation (l10n) and

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated May 16, 2016, 3:21 p.m.) Review request for KDE Software on Mac

Review Request 127939: Move src/runtime/kwallet-query/doc/ to docs/

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127939/ --- Review request for KDE Frameworks, Localization and Translation (l10n) and

Review Request 127938: Rename docs/kross directory to docs/kf5kross

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127938/ --- Review request for KDE Frameworks, Localization and Translation (l10n) and

Re: Review Request 127843: Properly remove composed characters

> On Kvě. 7, 2016, 9:40 dop., Dominik Haumann wrote: > > I can see that the patch works, since Qt's QTextLayout functions are used > > for cursor navigation. > > > > I dislike the part that exposes the "currentTextLayout()", since it exposes > > more API (but ok, maybe we must), and it is not

Re: Review Request 127934: Rename docs/kjsembed directory to docs/kjsembed5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127934/ --- (Updated May 16, 2016, 11:32 a.m.) Status -- This change has been ma

Re: Review Request 127933: Rename docs/kjs directory to docs/kjs5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127933/ --- (Updated May 16, 2016, 11:26 a.m.) Status -- This change has been ma

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!

On Monday 16 May 2016, David Faure wrote: > > Can someone take a look? Can more precise checks be added before the > QVERIFY to ease debugging when this fails? > At least a QVERIFY2(QFile::exists(iconPath), qPrintable(iconPath)) would be > good, right? But what if iconTheme is null? Then for sure

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 45 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/45/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 16 May 2016 10:49:08 + Build duration: 2 min 13 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 45 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/45/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 16 May 2016 10:49:08 + Build duration: 2 min 40 sec CHANGE SET Rev

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 46 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/46/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 16 May 2016 10:49:08 + Build duration: 2 min 36 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 46 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/46/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 16 May 2016 10:49:08 + Build duration: 2 min 36 sec CHANGE SET Revision 5

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!

On Monday 16 May 2016, David Faure wrote: > Can someone take a look? Can more precise checks be added before the > QVERIFY to ease debugging when this fails? > At least a QVERIFY2(QFile::exists(iconPath), qPrintable(iconPath)) would be > good, right? But what if iconTheme is null? Then for sure ico

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 May 2016 10:26:47 + Build duration: 5 min 49 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 May 2016 10:26:47 + Build duration: 5 min 49 sec CHANGE SET No changes JUNIT RESULTS Name: (

Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux, All, gcc - Build # 44 - Still Unstable!

On Saturday, May 14, 2016 10:52:16 AM CEST no-re...@kde.org wrote: > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/ PLATFORM=Linux,Variation=All,compiler=gcc/44/ Project: > PLATFORM=Linux,Variation=All,compiler=gcc > Date of bui

Re: Review Request 127865: Check size of unix domain socket path before copying to it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127865/#review95506 --- Ship it! Ship It! - Albert Astals Cid On May 8, 2016, 2

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 42 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/42/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 May 2016 10:17:46 + Build duration: 2 min 41 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 May 2016 10:17:11 + Build duration: 6 min 0 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 16 May 2016 10:17:11 + Build duration: 6 min 0 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Re: Review Request 127929: K4TimeZoneWidget: flag images not displayed because of incorrect path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127929/#review95505 --- Ship it! Ship It! - Albert Astals Cid On May 15, 2016,

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127935/#review95503 --- KF5DocToolsMacros.cmake (lines 47 - 49)

Re: Review Request 127897: Update documentation of kdoctools_install macro

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127897/ --- (Updated May 16, 2016, 9:26 a.m.) Status -- This change has been mar

Re: Review Request 127875: Selected state concept for icons

> On May 15, 2016, 7:26 p.m., David Faure wrote: > > src/kiconloader.cpp, line 820 > > > > > > Could q->theme() be NULL here in some cases? > > See > > https://build.kde.org/job/khtml%20master%20kf5-qt5/PLAT

Re: Review Request 127843: Properly remove composed characters

> On May 7, 2016, 9:40 a.m., Dominik Haumann wrote: > > I can see that the patch works, since Qt's QTextLayout functions are used > > for cursor navigation. > > > > I dislike the part that exposes the "currentTextLayout()", since it exposes > > more API (but ok, maybe we must), and it is not f

Re: Taking over KRunner maintainership

On vendredi 15 avril 2016 00:13:33 CEST Kai Uwe Broulik wrote: > Hi all, > > as was already briefly mentioned in the Plasma hangout this Monday Vishesh > asked me to take over maintainership of KRunner and I'm willing to accept. > > While I am not confident to have the skills required to really m

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

> On May 15, 2016, 5:03 p.m., Kåre Särs wrote: > > Looks good :) A couple of questions: > > > > - If we create the .rcc do we also want to install the icons? > > - I creates a similar solution for Kate on Windows (in a separate repo), > > but I needed to add a program to replace the symlinked f