----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127941/#review95518 -----------------------------------------------------------
Ship it! I wish this awful E() macro was a function, it would be much more readable and safer (would return a QByteArray rather than a pointer to a temporary buffer...), but anyhow, the fix looks clearly correct. PS: don't click "Ship It" on your own requests :-) - David Faure On May 16, 2016, 7:49 p.m., Fabien Shum-King wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127941/ > ----------------------------------------------------------- > > (Updated May 16, 2016, 7:49 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 357870 > https://bugs.kde.org/show_bug.cgi?id=357870 > > > Repository: kio-extras > > > Description > ------- > > All the commands sent to the Fish server are converted to latin1. By > consequence, all the non-latin1 characters are replaced by questions marks, > and therefore any command involving a file or directory with such a name > fails. > > > Diffs > ----- > > fish/fish.cpp f0b3b79 > > Diff: https://git.reviewboard.kde.org/r/127941/diff/ > > > Testing > ------- > > Created on a remote machine a file and a directory with an non-latin1 name > (ex: ??, éé). > 1. Connect with fish and try to copy the file to the local machine => It fails > 2. Try to enter the directory => it also fails. > > With the proposed fix, both work. > > > Thanks, > > Fabien Shum-King > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
