Review Request 127819: [autotests] Use -displayfd as argument to start Xvfb

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127819/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 127694: Add a Find module for WaylandProtocols

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127694/ --- (Updated May 3, 2016, 8:15 a.m.) Review request for Extra Cmake Modules,

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 20 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/20/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 03 May 2016 05:57:36 + Build duration: 2 min 54 sec CHANGE SET Revision 51d9

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 19 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/19/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 03 May 2016 05:57:36 + Build duration: 3 min 8 sec CHANGE SET Revisio

Re: Review Request for KWayland for inclusion in frameworks

Hi David, did you forget to update the version number of KWayland to 5.22 or is something still missing in KWayland? Cheers Martin On Sunday, April 17, 2016 10:42:08 AM CEST David Faure wrote: > Hi Martin, > > Very nice run down of the check list! > > I approve the move of kwayland to framewo

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 19 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/19/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 03 May 2016 05:34:30 + Build duration: 3 min 39 sec CHANGE SET No changes

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 2, 2016, 5:02 след обяд, Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of t

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/ --- (Updated Май 3, 2016, 7:10 преди обяд) Review request for KDE Frameworks

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/ --- (Updated May 3, 2016, 12:39 a.m.) Review request for KDE Frameworks, Alex

Re: Review Request 127655: Fix KAboutData::applicationData() to sync to current Q*Application metadata

> On April 29, 2016, 3:15 a.m., Michael Pyne wrote: > > I think I disagree with the idea of overwriting KAboutData properties if > > they are already set by the user. Alex, any thoughts? > > > > In the event the KAboutData doesn't already exist I think automatically > > setting it up makes sen

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 28, 2016, 8:44 p.m., Kai Uwe Broulik wrote: > > You broke the zoomed out view, ie. in the year/decade overview you now get > > a tick at *every* cell... > > Martin Klapetek wrote: > Oops, I'll fix, thanks. This is now fixed. - Martin -

Review Request 127817: Don't make KIconThemes depend on Oxygen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127817/ --- Review request for KDE Frameworks. Repository: kiconthemes Description

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 49 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/49/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 22:43:22 + Build duration: 15 min CHANGE SET No changes __

Jenkins-kde-ci: kxmlrpcclient master kf5-qt5 » Linux,gcc - Build # 41 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlrpcclient%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 22:43:22 + Build duration: 39 sec CHANGE SET No changes _

Re: Review Request 127813: Process paths just once

> On May 2, 2016, 10:21 p.m., Albert Astals Cid wrote: > > src/core/kconfiggroup.cpp, line 442 > > > > > > Are we sure we want this to be static? I'm not sure, my impression is that it's better if we only fetch

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 41 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 22:27:42 + Build duration: 9 min 58 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 44 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 22:30:56 + Build duration: 7 min 48 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 23 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 22:20:54 + Build duration: 4 min 49 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 48 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 22:24:15 + Build duration: 1 min 51 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 20 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/20/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:45:29 + Build duration: 16 min CHANGE SET No changes __

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 20 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/20/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:48:52 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Na

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 22 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 22:02:40 + Build duration: 4 min 47 sec CHANGE SET Revision 969e62c9fea27d6fa4da83fd391960

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 28 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:57:37 + Build duration: 2 min 24 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 40 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:38:05 + Build duration: 5 min 0 sec CHANGE SET Revision c506307ba50babe1d88297a6a5c4b1b1a224

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 22 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:43:42 + Build duration: 57 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: sonnet master kf5-qt5 » Linux,gcc - Build # 18 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/sonnet%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:29:43 + Build duration: 15 min CHANGE SET No changes

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 17 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:32:45 + Build duration: 15 min CHANGE SET No changes

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 18 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/18/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 02 May 2016 21:35:29 + Build duration: 1 min 50 sec CHANGE SET No changes

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 43 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:28:51 + Build duration: 5 min 57 sec CHANGE SET Revision c506307ba50babe1d88297a6a5c4b1b1a224de65 b

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 19 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:15:33 + Build duration: 6 min 41 sec CHANGE SET Revision 969e62c9fea27d6fa4da83f

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 19 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:15:33 + Build duration: 3 min 52 sec CHANGE SET Revision e811b7ec815e1c0d19e2456ff0ab4593b6

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 21 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:17:15 + Build duration: 1 min 4 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 18 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/18/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 02 May 2016 21:13:25 + Build duration: 2 min 10 sec CHANGE SET Revisio

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 18 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/18/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 02 May 2016 21:13:25 + Build duration: 2 min 10 sec CHANGE SET Revisio

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 47 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:10:34 + Build duration: 1 min 32 sec CHANGE SET Revision 07548ac1fe7a7fb31a9414739

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 20 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/20/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 21:08:34 + Build duration: 55 sec CHANGE SET Revision ca9620c3987a429ea2ae032949d04298a3f395e4

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 17 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/17/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 02 May 2016 20:59:26 + Build duration: 2 min 37 sec CHANGE SET No cha

Re: Review Request 127813: Process paths just once

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/#review95112 --- src/core/kconfiggroup.cpp (line 439)

Re: Review Request 127655: Fix KAboutData::applicationData() to sync to current Q*Application metadata

> On April 29, 2016, 3:15 a.m., Michael Pyne wrote: > > I think I disagree with the idea of overwriting KAboutData properties if > > they are already set by the user. Alex, any thoughts? > > > > In the event the KAboutData doesn't already exist I think automatically > > setting it up makes sen

Re: Review Request 127655: Fix KAboutData::applicationData() to sync to current Q*Application metadata

> On April 29, 2016, 3:15 a.m., Michael Pyne wrote: > > I think I disagree with the idea of overwriting KAboutData properties if > > they are already set by the user. Alex, any thoughts? > > > > In the event the KAboutData doesn't already exist I think automatically > > setting it up makes sen

Re: Version 5.21.0 for ECM missing (was: Re: Please add new versions on bugs.kde.org products on KF5 releases)

On Monday 02 May 2016 10:02:29 Friedrich W. H. Kossebau wrote: > Hi David, > > Am Samstag, 9. April 2016, 12:09:30 CEST schrieb David Faure: > > On Friday 08 April 2016 02:10:15 Friedrich W. H. Kossebau wrote: > > > Right now it seems at least the 5.21.0 version misses with all KF5 > > > products,

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

> On Май 2, 2016, 7:33 след обяд, David Edmundson wrote: > > src/plasma/datacontainer.cpp, line 262 > > > > > > why check storage is not null? > > > > if storageCount > 1 and storage is null we have a hu

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

> On Май 2, 2016, 8:04 след обяд, David Edmundson wrote: > > src/plasma/dataengine.cpp, line 574 > > > > > > This is the memory leak fix? > > > > If so, it's wrong. > > > > we get called from: >

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

> On May 2, 2016, 5:04 p.m., David Edmundson wrote: > > src/plasma/dataengine.cpp, line 574 > > > > > > This is the memory leak fix? > > > > If so, it's wrong. > > > > we get called from: > >

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

> On Май 2, 2016, 8:04 след обяд, David Edmundson wrote: > > src/plasma/dataengine.cpp, line 574 > > > > > > This is the memory leak fix? > > > > If so, it's wrong. > > > > we get called from: >

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

> On May 2, 2016, 5:04 p.m., David Edmundson wrote: > > src/plasma/dataengine.cpp, line 574 > > > > > > This is the memory leak fix? > > > > If so, it's wrong. > > > > we get called from: > >

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

> On Май 2, 2016, 8:04 след обяд, David Edmundson wrote: > > src/plasma/dataengine.cpp, line 574 > > > > > > This is the memory leak fix? > > > > If so, it's wrong. > > > > we get called from: >

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

> On Май 2, 2016, 7:33 след обяд, David Edmundson wrote: > > src/plasma/dataengine.cpp, line 415 > > > > > > This (and the following changes) accomplish absolutely nothing! > > > > previously. It started

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

> On Май 2, 2016, 7:33 след обяд, David Edmundson wrote: > > src/plasma/dataengine.cpp, line 573 > > > > > > Deleting an object auotmatically disconnects it > > > > This seems like a terrible thing to do

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/#review95098 --- src/plasma/dataengine.cpp (line 574)

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

> On May 2, 2016, 4:33 p.m., David Edmundson wrote: > > src/plasma/dataengine.cpp, line 573 > > > > > > Deleting an object auotmatically disconnects it > > > > This seems like a terrible thing to do. >

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

> On Май 2, 2016, 7:33 след обяд, David Edmundson wrote: > > src/plasma/dataengine.cpp, line 573 > > > > > > Deleting an object auotmatically disconnects it > > > > This seems like a terrible thing to do

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/#review95092 --- Which bit leaks? Why does it leak? and what specific thing fi

Review Request 127813: Process paths just once

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On May 2, 2016, 4:02 p.m., Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of touchi

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/ --- (Updated Май 2, 2016, 5:20 след обяд) Review request for KDE Frameworks a

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 2, 2016, 5:02 след обяд, Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of t

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 2, 2016, 5:02 след обяд, Martin Gräßlin wrote: > > src/platforms/xcb/kwindowsystem.cpp, lines 740-741 > > > > > > This makes the code way more difficult to read. I'm no longer able to > > grasp what's g

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/ --- (Updated Май 2, 2016, 5:04 след обяд) Review request for KDE Frameworks,

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95084 --- What is the "best" size if it's not specified? Why is your ch

Re: Review Request 127779: use system colors for monochrome icons

> On May 2, 2016, 1:51 p.m., Milian Wolff wrote: > > one more question: have you tried this with krita (or digicam) and their > > builtin functionality to change the app's color scheme? I.e. what about > > per-app changes vs. system-wide changes? I have to test this more, indeed probably won't

Re: Review Request 127810: Fix some gcc5.3 compile warnings in kwayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127810/ --- (Updated May 2, 2016, 3:54 p.m.) Status -- This change has been mark

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review95083 --- one more question: have you tried this with krita (or digicam

Re: Review Request 127779: use system colors for monochrome icons

> On May 2, 2016, 1:09 p.m., Sebastian Kügler wrote: > > Okay, let's try this in master and see if it's going to cause problems. > > Kai Uwe Broulik wrote: > Beware this is frameworks and the next frameworks release will be > upcoming Saturday > > Marco Martin wrote: > I was aiming at

Re: Review Request 127779: use system colors for monochrome icons

> On May 2, 2016, 1:09 p.m., Sebastian Kügler wrote: > > Okay, let's try this in master and see if it's going to cause problems. > > Kai Uwe Broulik wrote: > Beware this is frameworks and the next frameworks release will be > upcoming Saturday > > Marco Martin wrote: > I was aiming at

Re: Review Request 127810: Fix some gcc5.3 compile warnings in kwayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127810/#review95079 --- Ship it! - Sebastian Kügler On May 1, 2016, 8:32 p.m., A

Re: Review Request 127779: use system colors for monochrome icons

> On May 2, 2016, 1:09 p.m., Sebastian Kügler wrote: > > Okay, let's try this in master and see if it's going to cause problems. > > Kai Uwe Broulik wrote: > Beware this is frameworks and the next frameworks release will be > upcoming Saturday I was aiming at first for this one. Do you thi

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review95076 --- autotests/kiconloader_unittest.cpp (line 441)

Re: Review Request 127779: use system colors for monochrome icons

> On Mai 2, 2016, 1:09 nachm., Sebastian Kügler wrote: > > Okay, let's try this in master and see if it's going to cause problems. Beware this is frameworks and the next frameworks release will be upcoming Saturday - Kai Uwe --- This i

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review95075 --- Ship it! Okay, let's try this in master and see if it's go

Re: [kate/Applications/16.04] kate: Close document: use icon document-close instead of window-close

Hi, thank's for the question. Yes the close icon in the toolbar should be document-close, sorry that I don't report this "bug". ​about the configure dialog: we found the rule to don't mix monochrome and colored icons. as you have for the most elements action icons I would suggest also action ic

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/#review95072 --- Ping - Kai Uwe Broulik On Jan. 26, 2016, 6:13 nachm., Mart

DISCARDED: proposal for devel-versions with KF5 (was: Re: Please add new versions on bugs.kde.org products on KF5 releases)

Am Sonntag, 10. April 2016, 09:33:51 CEST schrieb David Faure: > On Saturday 09 April 2016 19:02:02 Friedrich W. H. Kossebau wrote: > > IIRC elsewhere I have seen people using a version called "git" in issue > > trackers, which would be used by developers for random snaphots and have > > them state

Version 5.21.0 for ECM missing (was: Re: Please add new versions on bugs.kde.org products on KF5 releases)

Hi David, Am Samstag, 9. April 2016, 12:09:30 CEST schrieb David Faure: > On Friday 08 April 2016 02:10:15 Friedrich W. H. Kossebau wrote: > > Right now it seems at least the 5.21.0 version misses with all KF5 > > products, though some also seem to miss the version 5.20.0 (e.g. > > frameworks-khtm