> On Май 2, 2016, 7:33 след обяд, David Edmundson wrote: > > src/plasma/datacontainer.cpp, line 262 > > <https://git.reviewboard.kde.org/r/127795/diff/3/?file=462319#file462319line262> > > > > why check storage is not null? > > > > if storageCount > 1 and storage is null we have a huge bug elsewhere. > > Anthony Fieroni wrote: > So this *can* dangerous, if job emit twice. It's complex. > > David Edmundson wrote: > If a job emits what twice?
So, you are right, if KJob emitted twice whole logic is broken - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/#review95092 ----------------------------------------------------------- On Май 2, 2016, 5:20 след обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127795/ > ----------------------------------------------------------- > > (Updated Май 2, 2016, 5:20 след обяд) > > > Review request for KDE Frameworks and Marco Martin. > > > Repository: plasma-framework > > > Description > ------- > > ^^ > > > Diffs > ----- > > autotests/pluginloadertest.h 61fc963 > autotests/pluginloadertest.cpp 4f96780 > src/plasma/datacontainer.cpp ee067db > src/plasma/dataengine.cpp f942926 > src/plasma/private/dataenginemanager.cpp 08e42fb > > Diff: https://git.reviewboard.kde.org/r/127795/diff/ > > > Testing > ------- > > Test pass. > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
