---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127245/#review93083
---
Ship it!
Thanks, looks more correct indeed.
- David Faure
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127261/#review93082
---
Ship it!
nice work! I had run into it in the past and didn
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127261/
---
(Updated March 2, 2016, 8:58 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127261/
---
Review request for KDE Frameworks and David Edmundson.
Repository: kauth
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127205/
---
(Updated März 2, 2016, 8:18 nachm.)
Review request for KDE Frameworks, Al
> On Feb. 27, 2016, 11:11 a.m., David Faure wrote:
> > It seems weird to have a setting for FTP on one side, and a setting for
> > "SMB and SFTP and any slave where this is implemented in the future".
> > I understand that it was the path of least code changes, but I fear this
> > creates an in
> On March 2, 2016, 2:26 p.m., Marco Martin wrote:
> > I find a bit baffling that an option is needed for this...
You are not exactly suggesting a better solution, though. Options are not
needed when we can make everything work magically out of the box. However FTP
servers are not exactly und
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127154/#review93075
---
I find a bit baffling that an option is needed for this...
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127223/#review93074
---
Ship it!
Ship It!
- Marco Martin
On Feb. 29, 2016, 4:19
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127205/#review93073
---
Looks good to me.
I'd prefer inline noop functions to macros
> On März 2, 2016, 9 vorm., Ben Cooksley wrote:
> > As a warning (because you'll be using QNAM here) please ensure you handle
> > redirects properly and completely. Any software which fails to do so is
> > considered unsupported even before it is released in regards to accessing
> > KDE.org in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127215/
---
(Updated March 2, 2016, 12:03 p.m.)
Status
--
This change has been m
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/289/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 02 Mar 2016 11:15:19 +
Build duration: 3 min 22 sec
CHANGE SET
Revision c
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/289/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 02 Mar 2016 11:15:19 +
Build duration: 3 min 22 sec
CHANGE SET
Revision c
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/296/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Wed, 02 Mar 2016 11:15:19 +
Build duration: 2 min 42 sec
CHANGE SET
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/296/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Wed, 02 Mar 2016 11:15:19 +
Build duration: 2 min 42 sec
CHANGE SET
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/296/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 02 Mar 2016 11:15:19 +
Build duration: 1 min 10 sec
CHANGE SET
Rev
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127245/
---
(Updated March 2, 2016, 11:04 a.m.)
Review request for KDE Frameworks.
> On March 2, 2016, 8:19 a.m., David Faure wrote:
> > I couldn't find "AppData" or "Roaming" in kdelibs4 though. Did this come
> > from windows API calls, or from kdewin maybe? Just wanted to check it was
> > the exact same logic as in kdelibs4...
In kdecore/kernel/kstandarddirs.cpp line 1733
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127251/#review93058
---
As a warning (because you'll be using QNAM here) please ensur
On Tuesday 01 March 2016 10:48:16 Andre Heinecke wrote:
> Hi,
>
> I want to implement a similiar "Show Password" functionality as
> KPasswordDialog from KWidgetsAddons has in GnuPG's pinentry.
>
> I'd like to use the same Icons for this, but Pinentry is GPLv2 or Later while
> breeze is LGPLv3.
> On March 1, 2016, 4:37 p.m., Aleix Pol Gonzalez wrote:
> > Eh... I just realized it's not 100% correct. We have a test
> > (testUnknownIconNotCached) that fails, unsure how I didn't see it yesterday.
> >
> > The problem with this one is that we are not reacting when icons are
> > introduced
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127215/#review93056
---
Ship it!
Well, the Qt bug isn't invalid, there's a bug if
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127245/#review93055
---
Ship it!
I couldn't find "AppData" or "Roaming" in kdelibs
24 matches
Mail list logo
