----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127245/#review93083 -----------------------------------------------------------
Ship it! Thanks, looks more correct indeed. - David Faure On March 2, 2016, 11:04 a.m., Andre Heinecke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127245/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 11:04 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > The old config was by default in ~/AppData/Roaming/.kde so on Windows we > should look there, too. > > The new config location (as used everywhere in KConfig) should be > GenericConfigLocation and not ConfigLocation. > According to http://doc.qt.io/qt-5/qstandardpaths.html this only makes a > difference on Windows so I think it's still safe to change this. > > > Diffs > ----- > > src/lib/util/kdelibs4configmigrator.cpp c8560c1 > src/lib/util/kdelibs4migration.cpp f631efa > > Diff: https://git.reviewboard.kde.org/r/127245/diff/ > > > Testing > ------- > > On Windows: Made changes to XMLGui rc file and both kleopatra config files > with a KDE 4 Kleo. Checked that they were migrated and changes show up. > > > Thanks, > > Andre Heinecke > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
