Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/#review92753 --- I don't like the introduction of the SCRAPBOOK. The repositor

Re: Review Request 127031: Add function to get runtime frameworks version information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127031/ --- (Updated Feb. 25, 2016, 1:02 a.m.) Status -- This change has been ma

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

> On Feb. 24, 2016, 4:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific? > > > > Thanks, > > Aleix Pol G

Re: Review Request 127090: Clean KWalletQuery cmake file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127090/ --- (Updated Feb. 25, 2016, 12:34 a.m.) Status -- This change has been m

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

> On Feb. 24, 2016, 8:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific? > > > > Thanks, Well, Qt might

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/ --- (Updated Feb. 24, 2016, 11:52 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 127090: Clean KWalletQuery cmake file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127090/#review92744 --- Ship it! Ship It! - Sebastian Kügler On Feb. 16, 2016,

Re: Review Request 125987: KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait for it.

> On Feb. 24, 2016, 8:29 a.m., Martin Gräßlin wrote: > > should we also add this change to plasma-integration? > > David Faure wrote: > Indeed, I have the same unittest failure there. > > -asterix- dfaure 9:55 > /s/kde/build/5/kde/workspace/plasma-integration/autotests>./kfontsetti

Re: Review Request 127158: Adds writer and external (extractor and writer) plugin support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127158/ --- (Updated Feb. 24, 2016, 8:34 p.m.) Status -- This change has been di

Re: Review Request 127033: Add /../share/hunspell/ to dictionary search path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127033/ --- (Updated Feb. 24, 2016, 8:25 p.m.) Review request for KDE Frameworks, Lau

Re: Review Request 127033: Add /../share/hunspell/ to dictionary search path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127033/ --- (Updated Feb. 24, 2016, 8:25 p.m.) Status -- This change has been ma

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127169/#review92739 --- Hi Aleix, I'm not familiar with the 'tiny mess'. Can you say

Re: Review Request 127159: Make the KPeople qml example slightly more usable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127159/ --- (Updated Feb. 24, 2016, 6:08 p.m.) Status -- This change has been ma

Re: Review Request 127117: Reverse the filtering logic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127117/ --- (Updated Feb. 24, 2016, 6:08 p.m.) Status -- This change has been ma

Re: Review Request 127164: Add actionType to the declarative plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127164/ --- (Updated Feb. 24, 2016, 6:08 p.m.) Status -- This change has been ma

Re: Review Request 127163: Add actionType to the PersonActionsModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127163/ --- (Updated Feb. 24, 2016, 6:08 p.m.) Status -- This change has been ma

Re: Review Request 127158: Adds writer and external (extractor and writer) plugin support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127158/#review92735 --- I think the very first thing you should do is divide the whol

Re: Review Request 126740: Add a script for optimizing svgs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/ --- (Updated Feb. 24, 2016, 5:23 p.m.) Status -- This change has been ma

Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127169/ --- Review request for Extra Cmake Modules and KDE Frameworks. Repository: ex

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

> On Feb. 24, 2016, 7:19 a.m., Martin Gräßlin wrote: > > src/klauncher/klauncher.h, line 274 > > > > > > const QByteArray & Well, I assign to it in the function. - Xuetian ---

Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

> On Feb. 24, 2016, 12:36 a.m., Aleix Pol Gonzalez wrote: > > Ship It! > > Aleix Pol Gonzalez wrote: > Eh.. wait, we still support Qt 5.3, will that be a problem? Hi Aleix, Good catch! It's not a problem in this commit, but following commits would not compile with Qt 5.3 because of a conn

Re: Review Request 125987: KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait for it.

> On Feb. 24, 2016, 8:29 a.m., Martin Gräßlin wrote: > > should we also add this change to plasma-integration? Indeed, I have the same unittest failure there. -asterix- dfaure 9:55 /s/kde/build/5/kde/workspace/plasma-integration/autotests>./kfontsettingsdata_unittest * Start testing

Re: Review Request 125987: KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait for it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125987/#review92709 --- should we also add this change to plasma-integration? - Mart

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 238 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/238/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Feb 2016 08:00:43 + Build duration: 6 min 19 sec CHANGE SET Revision cedafa80d23bcc4d9a9ea4f180c7f7cb8df

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 238 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/238/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Feb 2016 08:00:43 + Build duration: 6 min 19 sec CHANGE SET Revision cedafa80d23bcc4d9a9ea4f180c7f7cb8df

Re: Review Request 125987: KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait for it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125987/ --- (Updated Feb. 24, 2016, 12:05 a.m.) Status -- This change has been m

Re: Review Request 126694: KHTML java applet viewer: repair broken DBus call to kpasswdserver

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126694/ --- (Updated Feb. 24, 2016, 9:03 a.m.) Status -- This change has been ma

Re: Review Request 127127: KOpenWithDialog: show mimetype name and comment in "Remember" checkbox text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127127/ --- (Updated Feb. 24, 2016, 8 a.m.) Status -- This change has been marke