> On Feb. 24, 2016, 8:29 a.m., Martin Gräßlin wrote:
> > should we also add this change to plasma-integration?
>
> David Faure wrote:
> Indeed, I have the same unittest failure there.
>
> -asterix- dfaure 9:55
> /s/kde/build/5/kde/workspace/plasma-integration/autotests>./kfontsettingsdata_unittest
>
> ********* Start testing of KFontSettingsData_UnitTest *********
> Config: Using QtTest library 5.6.0, Qt 5.6.0 (x86_64-little_endian-lp64
> shared (dynamic) debug build; by GCC 4.8.3 20140627 [gcc-4_8-branch revision
> 212064])
> PASS : KFontSettingsData_UnitTest::initTestCase()
> PASS : KFontSettingsData_UnitTest::_q_showIfNotHidden()
> PASS : KFontSettingsData_UnitTest::testFonts()
> QWARN : KFontSettingsData_UnitTest::testFontsChanged()
> kfontsettingsdata_unittest(11964)/default KIconTheme::KIconTheme: Icon theme
> "non-existent-icon-theme" not found.
> FAIL! : KFontSettingsData_UnitTest::testFontsChanged() Compared values
> are not the same
> Actual (m_fonts->font(KFontSettingsData::GeneralFont)->family()):
> "OxyFontTest"
> Expected (QStringLiteral("ChangedFontTest")) :
> "ChangedFontTest"
> Loc:
> [/d/kde/src/5/kde/workspace/plasma-integration/autotests/kfontsettingsdata_unittest.cpp(107)]
> PASS : KFontSettingsData_UnitTest::cleanupTestCase()
> Totals: 4 passed, 1 failed, 0 skipped, 0 blacklisted
> ********* Finished testing of KFontSettingsData_UnitTest *********
>
> Can you forwardport? (otherwise I'll do it tonight)
Done now.
http://commits.kde.org/plasma-integration/36bc1c1ee0ef09adaff31dc95d998f7a04544ceb
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125987/#review92709
-----------------------------------------------------------
On Feb. 24, 2016, 8:05 a.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125987/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 8:05 a.m.)
>
>
> Review request for KDE Frameworks and Àlex Fiestas.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait
> for it.
>
>
> Diffs
> -----
>
> autotests/kfontsettingsdata_unittest.cpp
> 56ba9458625e2f39622251467ee39b388fc6508d
>
> Diff: https://git.reviewboard.kde.org/r/125987/diff/
>
>
> Testing
> -------
>
> This fixes ./kfontsettingsdata_unittest on my machine. I'm not sure how it
> passes on CI at all...
>
>
> Thanks,
>
> David Faure
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
