Re: Review Request 127004: WIP: OpenFileManagerWindowJob

2016-02-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127004/#review92141 --- src/widgets/openfilemanagerwindowjob.h (lines 5 - 7)

Re: Review Request 127004: WIP: OpenFileManagerWindowJob

2016-02-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127004/ --- (Updated Feb. 7, 2016, 6:20 nachm.) Review request for KDE Frameworks, Em

Review Request 127004: WIP: OpenFileManagerWindowJob

2016-02-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127004/ --- Review request for KDE Frameworks, Emmanuel Pescosta and Martin Gräßlin.

Re: Review Request 127002: Add KLocalizedString::getLanguages()

2016-02-07 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127002/ --- (Updated Feb. 7, 2016, 4:28 p.m.) Status -- This change has been mar

Re: Reminder: Please add "Since" version info also to cmake macros and arguments

2016-02-07 Thread Alex Merry
On 2016-01-18 16:45, Friedrich W. H. Kossebau wrote: Am Donnerstag, 14. Januar 2016, 09:50:05 schrieb Friedrich W. H. Kossebau: I am happy to fix at least KF5CoreAddonsMacros.cmake now that I came across it, appending the Since behind the example, if that is the current syntax? # Example: #

Re: Review Request 127002: Add KLocalizedString::getLanguages()

2016-02-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127002/#review92122 --- Qt API guidelines say to use getFoo() only when using "out pa

Re: Review Request 127002: Add KLocalizedString::getLanguages()

2016-02-07 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127002/#review92121 --- Ship it! Ship It! - Chusslove Illich On Феб. 7, 2016, 9

Review Request 127002: Add KLocalizedString::getLanguages()

2016-02-07 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127002/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n