----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127004/ -----------------------------------------------------------
(Updated Feb. 7, 2016, 6:20 nachm.) Review request for KDE Frameworks, Emmanuel Pescosta and Martin Gräßlin. Changes ------- * Fix a few comment typos * emitResult in both success and error cases in the DBus reply handler Repository: kio Description ------- This job uses the org.freedesktop.FileManager1 interface to highlight files within a certain folder, useful for eg. downloaded files or a "open containing folder" functionality. Diffs (updated) ----- src/widgets/CMakeLists.txt 87dac50 src/widgets/openfilemanagerwindowjob.h PRE-CREATION src/widgets/openfilemanagerwindowjob.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127004/diff/ Testing ------- With Dolphin's org.freedesktop.FileManager1 service installed, I got a file highlighted properly. Without it Dolphin opened the folder without highlighting (KRun fallback). Not sure what to do with the startup id stuff Thanks, Kai Uwe Broulik
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
