Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-01-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review91605 --- src/platformtheme/kdeplatformfiledialoghelper.cpp (line 195)

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

2016-01-25 Thread Martin Gräßlin
> On Jan. 25, 2016, 10:36 p.m., Luca Beltrame wrote: > > FYI, this breaks Plasma 5 startup completely for me. kinit crashes with > > > > ```gdb > > #0 0x7ff831e58c20 in QObject::thread() const () at > > /usr/lib64/libQt5Core.so.5 > > #1 0x7ff8329d1a20 in KWindowSystem::d_func() () at

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

2016-01-25 Thread Martin Gräßlin
> On Jan. 25, 2016, 10:36 p.m., Luca Beltrame wrote: > > FYI, this breaks Plasma 5 startup completely for me. kinit crashes with > > > > ```gdb > > #0 0x7ff831e58c20 in QObject::thread() const () at > > /usr/lib64/libQt5Core.so.5 > > #1 0x7ff8329d1a20 in KWindowSystem::d_func() () at

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

2016-01-25 Thread Martin Gräßlin
> On Jan. 25, 2016, 10:36 p.m., Luca Beltrame wrote: > > FYI, this breaks Plasma 5 startup completely for me. kinit crashes with > > > > ```gdb > > #0 0x7ff831e58c20 in QObject::thread() const () at > > /usr/lib64/libQt5Core.so.5 > > #1 0x7ff8329d1a20 in KWindowSystem::d_func() () at

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

2016-01-25 Thread Andreas Hartmetz
> On Jan. 25, 2016, 9:36 p.m., Luca Beltrame wrote: > > FYI, this breaks Plasma 5 startup completely for me. kinit crashes with > > > > ```gdb > > #0 0x7ff831e58c20 in QObject::thread() const () at > > /usr/lib64/libQt5Core.so.5 > > #1 0x7ff8329d1a20 in KWindowSystem::d_func() () at

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

2016-01-25 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126313/#review91596 --- FYI, this breaks Plasma 5 startup completely for me. kinit cr

Re: Review Request 126314: Port klauncher to xcb

2016-01-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126314/ --- (Updated Jan. 25, 2016, 3:34 p.m.) Status -- This change has been ma

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

2016-01-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126313/ --- (Updated Jan. 25, 2016, 3:34 p.m.) Status -- This change has been ma

Review Request 126883: Add Package::cryptographicHash(QCryptographicHash::Algorithm)

2016-01-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126883/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: k

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-01-25 Thread Alex Richardson
> On Jan. 24, 2016, 10:01 p.m., David Faure wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 195 > > > > > > Yes, this definitely looks like it should be fixed in Qt instead (and > > this code

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-01-25 Thread Kåre Särs
> On Jan. 24, 2016, 10:01 p.m., David Faure wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 195 > > > > > > Yes, this definitely looks like it should be fixed in Qt instead (and > > this code

Re: Review Request 126813: Fix build with older polkit

2016-01-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126813/#review91567 --- Ship it! Ship It! - Martin Gräßlin On Jan. 21, 2016, 5:

Re: Review Request 126880: Fix QFileDialog::openUrl() for remote files

2016-01-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126880/#review91563 --- Hmm, see https://git.reviewboard.kde.org/r/126876 - David Fa

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

2016-01-25 Thread David Faure
> On Jan. 24, 2016, 10:01 p.m., David Faure wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 195 > > > > > > Yes, this definitely looks like it should be fixed in Qt instead (and > > this code

Re: Making polkit-qt-1 a tier1 framework

2016-01-25 Thread Martin Graesslin
On Saturday, January 23, 2016 11:59:28 AM CET David Faure wrote: > On Thursday 14 January 2016 13:20:01 Martin Gräßlin wrote: > > Hi all, > > > > I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks. > > Reasons are: > > > > * kdesupport is basically what became tier1 in framew

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

2016-01-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126870/#review91561 --- Pointing out the obvious: though shall not animate window pos