Re: Review Request 126440: Fix some Clazy warnings in kinit.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126440/#review89796 --- Ship it! Ship It! - Michael Pyne On Dec. 20, 2015, 10:44 p

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89795 --- Ship it! Revised patch looks good here. - Michael Pyne On

Re: Review Request 126423: KPluginSelector::addPlugins: do not assert if 'config' parameter is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126423/#review89792 --- Ship it! Ship It! - Michael Pyne On Dec. 19, 2015, 8:34 a.

Re: Review Request 126409: Fix use-after-free in .desktop file parser

> On Dec. 18, 2015, 3:17 a.m., Alex Richardson wrote: > > src/lib/plugin/desktopfileparser.cpp, line 346 > > > > > > `defs << *def // This must...` instead? And then the `defs << *def` in > > the else block? Wou

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89786 --- Hey, when my patch will be reviewed? - Andrey Cygankov On Д

Review Request 126440: Fix some Clazy warnings in kinit.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126440/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kin

Re: [Kde-pim] kdesrc-build setup for kdepim

> I've been strugling since wednesday to build kdepim with KSB. I think I've > managed to sort out most dependencies. Only kdepim-runtime and kdepin dont > build. Reason is I don't have kross *.16 (kubuntu comes with *.15. I've tried > to build kross with KSB but it fails with: > [ 64%] Automati

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly unexpecte