Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86442 --- What about rename class ? - Laurent Montel On oct. 4, 2015,

Re: Review Request 125532: KTextEdit: fix loading Sonnet default settings, add context menu to switch spell-checking language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125532/#review86440 --- For me seems good as I created same patch in kdepim :) - Laur

Re: Review Request 125532: KTextEdit: fix loading Sonnet default settings, add context menu to switch spell-checking language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125532/#review86439 --- src/widgets/ktextedit.cpp (line 139)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 121 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/121/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Oct 2015 22:15:18 + Build duration: 6 min 51 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 89 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Oct 2015 21:42:40 + Build duration: 2 min 8 sec CHANGE SET Revision 0a39ba6ec01600efeb9e334fa457dd7

Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125537/ --- (Updated Oct. 6, 2015, 9:42 p.m.) Status -- This change has been mar

Re: Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

Hi, 2015-10-06 15:04 GMT+02:00 : > > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/119/ > Project: PLATFORM=Linux,compiler=gcc > Date of build: Tue, 06 Oct 2015 12:34:13 + > Build duration: 14 min > > CHANGE SET >

Re: Review Request 125535: Minor optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125535/ --- (Updated Oct. 6, 2015, 4:01 p.m.) Status -- This change has been mar

Re: Review Request 125535: Minor optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125535/#review86431 --- +1 LGTM. - Aleix Pol Gonzalez On Oct. 6, 2015, 2:44 p.m., A

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 120 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/120/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Oct 2015 15:02:37 + Build duration: 1 min 35 sec CHANGE SET Revision 822085a4971915fdd87b50fd8709e73ca949bb3c b

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 113 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/113/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Oct 2015 15:02:43 + Build duration: 9 min 8 sec CHANGE SET Revision 822085a4971915fdd87b50fd8709e73ca94

Re: Review Request 125262: Parse ServiceType files when reading .desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125262/ --- (Updated Oct. 6, 2015, 3:07 p.m.) Review request for KDE Frameworks, Davi

Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125537/#review86429 --- Ship it! Perfect thanks! I'll create a new tag to include th

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/119/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Oct 2015 12:34:13 + Build duration: 14 min CHANGE SET Revision 4f464d4ade465ad009758d12908f72189953c4f1 by scr

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 112 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/112/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Oct 2015 12:34:13 + Build duration: 15 min CHANGE SET Revision 4f464d4ade465ad009758d12908f72189953c4f1

Re: Review Request 125535: Minor optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125535/ --- (Updated oct. 6, 2015, 12:44 p.m.) Review request for KDE Frameworks. C

Re: Review Request 125263: Adapt KPluginInfo to introduction of KPluginMetaData::mimeTypes()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125263/ --- (Updated Oct. 6, 2015, 11:43 a.m.) Status -- This change has been ma

Re: Review Request 125527: Add mimeTypes() to KPluginMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125527/ --- (Updated Oct. 6, 2015, 11:42 a.m.) Status -- This change has been ma

Re: Review Request 125527: Add mimeTypes() to KPluginMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125527/#review86417 --- Ship it! Ship It! - Sebastian Kügler On Oct. 6, 2015, 10:3

Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125537/ --- (Updated Oct. 6, 2015, 11:06 a.m.) Review request for KDE Frameworks, Alb

Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125537/#review86416 --- Nice and original solution, I like it. Just some last fixes I

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

On 6 October 2015 at 11:15, Sebastian Kügler wrote: > On Mon, 05 Oct 2015 10:36:23 - > "Alex Richardson" wrote: >> https://git.reviewboard.kde.org/r/125261/ > >> This change has been discarded. > >> Description >> --- >> >> When loading a .desktop file this will parse the XDG MimeType= ke

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

On Mon, 05 Oct 2015 10:36:23 - "Alex Richardson" wrote: > https://git.reviewboard.kde.org/r/125261/ > This change has been discarded. > Description > --- > > When loading a .desktop file this will parse the XDG MimeType= key > > Contrary to KService we don't merge these with ServiceTyp

Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125537/ --- (Updated Oct. 6, 2015, 9:53 a.m.) Review request for KDE Frameworks, Albe

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 118 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Oct 2015 08:30:48 + Build duration: 14 min CHANGE SET Revision 4b24b70c93523c5bc56c90c04a5a666331e96a1b by fra

Re: Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

> On Oct. 6, 2015, 10:27 a.m., Aleix Pol Gonzalez wrote: > > src/ioslaves/trash/kio_trash.cpp, line 617 > > > > > > Maybe use qCDebug? So it can be disabled and so. > > Emmanuel Pescosta wrote: > Trash doesn

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 111 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/111/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 06 Oct 2015 08:30:48 + Build duration: 14 min CHANGE SET Revision 4b24b70c93523c5bc56c90c04a5a666331e96a1b

Re: Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

> On Oct. 6, 2015, 10:27 a.m., Aleix Pol Gonzalez wrote: > > src/ioslaves/trash/kio_trash.cpp, line 617 > > > > > > Maybe use qCDebug? So it can be disabled and so. Trash doesn't use categorized logging atm so I

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/ --- (Updated Oct. 6, 2015, 8:30 a.m.) Status -- This change has been mar

Re: Review Request 124983: Move the desktop files and file templates for the "Create New..." menu from kde-baseapps to kio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124983/ --- (Updated Oct. 6, 2015, 8:30 a.m.) Status -- This change has been mar

Re: Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125538/#review86411 --- src/ioslaves/trash/kio_trash.cpp (line 617)

Re: Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125538/ --- (Updated Oct. 6, 2015, 7:40 a.m.) Status -- This change has been mar

Re: Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125538/#review86410 --- Ship it! Nice! src/ioslaves/trash/trashimpl.cpp (line 726)

Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125537/#review86409 --- Good catch, thanks - and nice to see a unittest as well. src

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

On Monday 05 October 2015 21:24:34 Marko Käning wrote: > Well, I know, I could simply make my Portfile use a patch file… > > On 05 Oct 2015, at 21:18 , Marko Käning wrote: > > I’d suggest a 5.14.1 for the kdesignerplugin, which contains Kurt’s fix: > > … or simply wait a a tiny bit longer… > >

Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125538/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc