----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125538/#review86410 -----------------------------------------------------------
Ship it! Nice! src/ioslaves/trash/trashimpl.cpp (line 726) <https://git.reviewboard.kde.org/r/125538/#comment59535> trailing space src/ioslaves/trash/trashimpl.cpp (line 731) <https://git.reviewboard.kde.org/r/125538/#comment59536> QString is just one more character than auto, and more readable :-) - David Faure On Oct. 6, 2015, 7:05 a.m., Emmanuel Pescosta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125538/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 7:05 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > Gives the user info about the trash occupancy when opening the trash > > > Diffs > ----- > > src/ioslaves/trash/kio_trash.h e6160c4 > src/ioslaves/trash/kio_trash.cpp 7ca8ad0 > src/ioslaves/trash/trashimpl.h 9881d8e > src/ioslaves/trash/trashimpl.cpp 5a2832a > > Diff: https://git.reviewboard.kde.org/r/125538/diff/ > > > Testing > ------- > > Works fine (with and without maximum size limit) > > > Thanks, > > Emmanuel Pescosta > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
