Re: Review Request 125217: KDirWatch: fix thread safety

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125217/ --- (Updated Sept. 15, 2015, 5:46 a.m.) Status -- This change has been m

Re: Review Request 125217: KDirWatch: fix thread safety

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125217/#review85412 --- Ship it! +1 - Michael Pyne On Sept. 14, 2015, 7:06 a.m., D

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/#review85410 --- src/qmlcontrols/kquickcontrolsaddons/eventforge.h (line 27) <

Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- Review request for KDE Frameworks, Plasma and Eike Hein. Repository: kdec

Re: Documentation on adding new Solid Backends

Hi, The documentation is located in http://techbase.kde.org/Development/Tutorials/Solid_Tutorials. I am afraid it is scarse and in some cases outdated. You can also take a look at available backends in git://anongit.kde.org/solid/src/solid/devices/backends as examples, specially udev and udisks2 b

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

> On Sep 14, 2015, at 8:36 AM, Kurt Hindenburg > wrote: > > >> On Sep 14, 2015, at 5:54 AM, Alex Merry wrote: >> >> On 2015-09-14 00:42, Kurt Hindenburg wrote: On Sep 13, 2015, at 5:43 PM, Marko Käning wrote: Hi devs, the other day I had built version 5.13 successfully on a

Re: SIC/BIC in Frameworks (NOT)

I guess I forgot to turn back on clean workspace? We were debugging qt5.5. I Am so sorry, been traveling home. Scarlett On Sep 14, 2015 12:59 PM, "Ben Cooksley" wrote: > On Mon, Sep 14, 2015 at 12:28 AM, David Faure wrote: > > This is clearly a CI issue, not a SIC/BIC, as both our investigation

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

> On Sep 14, 2015, at 5:54 AM, Alex Merry wrote: > > On 2015-09-14 00:42, Kurt Hindenburg wrote: >>> On Sep 13, 2015, at 5:43 PM, Marko Käning wrote: >>> Hi devs, >>> the other day I had built version 5.13 successfully on a OSX/MacPorts-based >>> VM. >>> And so I wanted to try the same with th

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 42 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/42/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:21 + Build duration: 11 min CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 42 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/42/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:21 + Build duration: 11 min CHANGE SET No changes JUNIT RESULTS Nam

Re: SIC/BIC in Frameworks (NOT)

On Mon, Sep 14, 2015 at 12:28 AM, David Faure wrote: > This is clearly a CI issue, not a SIC/BIC, as both our investigations prove. And now fixed. > > On Sunday 13 September 2015 23:43:19 Ben Cooksley wrote: >> This then causes KNotification to fail to build (as it depends on >> netwm.h) which t

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 34 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/34/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:27 + Build duration: 1 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 34 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/34/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:27 + Build duration: 1 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 91 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/91/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:07 + Build duration: 5 min 19 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 96 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/96/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:04 + Build duration: 7 min 38 sec CHANGE SET No c

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 96 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/96/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:04 + Build duration: 7 min 38 sec CHANGE SET No c

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 96 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/96/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:04 + Build duration: 1 min 55 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 96 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/96/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:04 + Build duration: 1 min 55 sec CHANGE SET

Re: Review Request 125214: Add support for network shares in kio_trash

> On Sept. 14, 2015, 9:21 a.m., David Faure wrote: > > src/ioslaves/trash/trashimpl.cpp, line 838 > > > > > > strange default value, 1 would work just as well, wouldn't it? > > > > The first time we get

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 17 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:16 + Build duration: 4 min 32 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 17 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:16 + Build duration: 4 min 32 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: knotifications master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:12 + Build duration: 1 min 10 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: knotifications master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:12 + Build duration: 1 min 10 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/ --- (Updated Sept. 14, 2015, 12:31 p.m.) Review request for KDE Frameworks an

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 84 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:13:01 + Build duration: 4 min 41 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: knotifications master kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifications%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:13:06 + Build duration: 2 min 0 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: knotifications master kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knotifications%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:13:06 + Build duration: 2 min 0 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 41 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:12:28 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/86/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 14 Sep 2015 10:12:56 + Build duration: 2 min 56 sec CHANGE SET No changes

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 41 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:12:28 + Build duration: 12 min CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/86/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 14 Sep 2015 10:12:56 + Build duration: 2 min 56 sec CHANGE SET No changes

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/86/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Sep 2015 10:12:56 + Build duration: 2 min 42 sec CHANGE SET No chan

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 86 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/86/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Sep 2015 10:12:56 + Build duration: 2 min 42 sec CHANGE SET No chan

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 16 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:12:43 + Build duration: 4 min 38 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 16 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:12:43 + Build duration: 4 min 38 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

On 2015-09-14 00:42, Kurt Hindenburg wrote: On Sep 13, 2015, at 5:43 PM, Marko Käning wrote: Hi devs, the other day I had built version 5.13 successfully on a OSX/MacPorts-based VM. And so I wanted to try the same with the newest 5.14 just now, but failed! :( Any idea why those three inte

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 95 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/95/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Sep 2015 09:12:38 + Build duration: 47 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 85 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/85/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Sep 2015 09:12:38 + Build duration: 2 min 21 sec CHANGE SET Revisio

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 95 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/95/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 14 Sep 2015 09:12:38 + Build duration: 1 min 23 sec CHANGE SET Revi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 85 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/85/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 14 Sep 2015 09:12:38 + Build duration: 27 sec CHANGE SET Revision 4b4461d7

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/#review85347 --- Ship it! src/ioslaves/trash/trashimpl.h (line 25)

Re: Review Request 125217: KDirWatch: fix thread safety

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125217/ --- (Updated Sept. 14, 2015, 7:06 a.m.) Review request for KDE Frameworks, Al

Re: Review Request 125217: KDirWatch: fix thread safety

> On Sept. 14, 2015, 1:46 a.m., Michael Pyne wrote: > > src/lib/io/kdirwatch.cpp, line 1889 > > > > > > The changes themselves seem OK, but if this is really supposed to be > > thread-safe then shouldn't this c