----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/#review85410 -----------------------------------------------------------
src/qmlcontrols/kquickcontrolsaddons/eventforge.h (line 27) <https://git.reviewboard.kde.org/r/125226/#comment58984> api docs src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp (line 34) <https://git.reviewboard.kde.org/r/125226/#comment58986> x, y aren't always int in QtQuick especially as you use QPointF later src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp (line 40) <https://git.reviewboard.kde.org/r/125226/#comment58987> we're getting win and not using it. Is that deliberate? src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp (line 51) <https://git.reviewboard.kde.org/r/125226/#comment58985> why do people need to do this? This class feels like it's just working round Qt bugs? Other than that if this is long-term useful, we should do sendPress(flags buttons, flags modifiers, x, y) not just whatever AppletAppearance happened to need (or make it part of makeGrab() if that's all it's for ) - David Edmundson On Sept. 14, 2015, 5:17 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125226/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 5:17 p.m.) > > > Review request for KDE Frameworks, Plasma and Eike Hein. > > > Repository: kdeclarative > > > Description > ------- > > EventForge can cancel the half-managed events of child items > in order to implement the move of them with press and hold, > not having the parent and the children battling for the same > press-move-release event sequence. > > API-wise I think it's fine, apart perhaps the EventForge class name > (perhaps MouseEventGrabber is less technically correct, but still more clear?) > > > Diffs > ----- > > src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 > src/qmlcontrols/kquickcontrolsaddons/eventforge.h PRE-CREATION > src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp PRE-CREATION > src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f > > Diff: https://git.reviewboard.kde.org/r/125226/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
