Re: Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux, gcc - Build # 32 - Fixed!

2015-08-15 Thread Scarlett Clark
On vacation. I will fix it when I get back. Scarlett On Aug 15, 2015 7:05 AM, "Bhushan Shah" wrote: > On Sat, Aug 15, 2015 at 3:44 PM, David Faure wrote: > > Finally! > > > > https://build.kde.org/view/Frameworks%20kf5-qt5/ is all green again. > > > > There is no excuse anymore to ignore the mai

Re: Review Request 123376: Fix handling of mod-shift-number shortcuts.

2015-08-15 Thread Thomas Lübking
> On Mai 1, 2015, 7:51 vorm., Thomas Lübking wrote: > > Two things. > > a) "1" is a magic number (stupid xcb, should be xcppb ;-) - please add a > > comment that this picks the 1st level shift > > b) the overall code looks a bit inefficient. No idea how smart xcb is under > > the hood, but > >

Re: Review Request 123376: Fix handling of mod-shift-number shortcuts.

2015-08-15 Thread Thomas Lübking
> On Aug. 12, 2015, 10:17 vorm., Thomas Lübking wrote: > > bump, we should get this fixed for 5.4 > > > > Shui, do you want to work on improving the patch and adding the testcase? > > Thomas Lübking wrote: > -100 > THE PATCH BREAKS BACKTABBING!! > > Btw. entirely not figured by

Re: Review Request 123376: Fix handling of mod-shift-number shortcuts.

2015-08-15 Thread Yuxuan Shui
> On Aug. 12, 2015, 10:17 a.m., Thomas Lübking wrote: > > bump, we should get this fixed for 5.4 > > > > Shui, do you want to work on improving the patch and adding the testcase? > > Thomas Lübking wrote: > -100 > THE PATCH BREAKS BACKTABBING!! > > Btw. entirely not figured by

Re: Review Request 123376: Fix handling of mod-shift-number shortcuts.

2015-08-15 Thread Yuxuan Shui
> On May 1, 2015, 7:51 a.m., Thomas Lübking wrote: > > Two things. > > a) "1" is a magic number (stupid xcb, should be xcppb ;-) - please add a > > comment that this picks the 1st level shift > > b) the overall code looks a bit inefficient. No idea how smart xcb is under > > the hood, but > >

Re: Review Request 123376: Fix handling of mod-shift-number shortcuts.

2015-08-15 Thread Thomas Lübking
> On Aug. 12, 2015, 10:17 vorm., Thomas Lübking wrote: > > bump, we should get this fixed for 5.4 > > > > Shui, do you want to work on improving the patch and adding the testcase? > > Thomas Lübking wrote: > -100 > THE PATCH BREAKS BACKTABBING!! > > Btw. entirely not figured by

Re: Review Request 123376: Fix handling of mod-shift-number shortcuts.

2015-08-15 Thread Thomas Lübking
> On Aug. 12, 2015, 10:17 vorm., Thomas Lübking wrote: > > bump, we should get this fixed for 5.4 > > > > Shui, do you want to work on improving the patch and adding the testcase? -100 THE PATCH BREAKS BACKTABBING!! Btw. entirely not figured by autotests :-P @Martin test might be quite a prob

Re: Review Request 124746: [KDesktopFile] add readMimeType

2015-08-15 Thread Kai Uwe Broulik
> On Aug. 15, 2015, 7:24 nachm., David Faure wrote: > > Why not use KService instead? I don't know :) Seemed like the most reasonable way given I was checking the Desktop file for the exec path already. - Kai Uwe --- This is an automat

Re: Review Request 124746: [KDesktopFile] add readMimeType

2015-08-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124746/#review83843 --- Why not use KService instead? - David Faure On Aug. 15, 201

Review Request 124746: [KDesktopFile] add readMimeType

2015-08-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124746/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-15 Thread Elvis Angelaccio
> On Ago. 15, 2015, 10:36 a.m., David Faure wrote: > > Cool feature. I think the icon for this more usually looks like an eye, no? > > (so indeed I would encourage you to request a better icon from the artists > > / VDG / whoever makes icons these days) ;) > > > > Code looks good to me (and I

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-15 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- (Updated Ago. 15, 2015, 1:31 p.m.) Review request for KDE Frameworks and

Re: Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux, gcc - Build # 32 - Fixed!

2015-08-15 Thread Bhushan Shah
On Sat, Aug 15, 2015 at 3:44 PM, David Faure wrote: > Finally! > > https://build.kde.org/view/Frameworks%20kf5-qt5/ is all green again. > > There is no excuse anymore to ignore the mails from Jenkins, from now on they > will > represent real regressions. Now only if double emails can be stopped.

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 33 - Unstable!

2015-08-15 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 10:52:29 + Build duration: 10 min CHANGE SET Revision 3035ca3fac8a520271138e2f9c022522c93a

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 33 - Unstable!

2015-08-15 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 10:52:29 + Build duration: 10 min CHANGE SET Revision 3035ca3fac8a520271138e2f9c022522c93a

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/#review83822 --- Cool feature. I think the icon for this more usually looks lik

Re: [kio] src/filewidgets: Use QVector instead of QSet as Kévin suggested to help with QSet ordering unstability.

2015-08-15 Thread David Faure
On Friday 14 August 2015 11:41:31 Kevin Ottens wrote: > > You could also remove the QSet randomization using QT_HASH_SEED and > potentially QT_NO_CPU_FEATURE. Thanks, that solved it. I thought I was doing it already with qt_qhash_seed but initTestCase() was probably too late for that, so now I

Re: Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux, gcc - Build # 32 - Fixed!

2015-08-15 Thread David Faure
Finally! https://build.kde.org/view/Frameworks%20kf5-qt5/ is all green again. There is no excuse anymore to ignore the mails from Jenkins, from now on they will represent real regressions. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

2015-08-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 09:50:44 + Build duration: 12 min CHANGE SET Revision 5a4cafd757c5847568de32bd8fe409

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

2015-08-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 09:50:44 + Build duration: 12 min CHANGE SET Revision 5a4cafd757c5847568de32bd8fe409

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 32 - Fixed!

2015-08-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 09:50:44 + Build duration: 11 min CHANGE SET Revision 5a4cafd757c5847568de32bd8fe4093907920

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 32 - Fixed!

2015-08-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 09:50:44 + Build duration: 11 min CHANGE SET Revision 5a4cafd757c5847568de32bd8fe4093907920

Jenkins-kde-ci: kross master stable-kf5-qt5 » Linux,gcc - Build # 16 - Fixed!

2015-08-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kross%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 08:12:19 + Build duration: 3 min 12 sec CHANGE SET Revision 373fa281ee9d4bf7e1c7c4ce58e5b5f8d9

Jenkins-kde-ci: kross master stable-kf5-qt5 » Linux,gcc - Build # 16 - Fixed!

2015-08-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kross%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 08:12:19 + Build duration: 3 min 12 sec CHANGE SET Revision 373fa281ee9d4bf7e1c7c4ce58e5b5f8d9

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 15 - Fixed!

2015-08-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 08:12:19 + Build duration: 3 min 1 sec CHANGE SET Revision 373fa281ee9d4bf7e1c7c4ce58e5b5f8d9572725 b

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 15 - Fixed!

2015-08-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 08:12:19 + Build duration: 3 min 1 sec CHANGE SET Revision 373fa281ee9d4bf7e1c7c4ce58e5b5f8d9572725 b

Re: kross unit tests broken

2015-08-15 Thread David Faure
On Sunday 02 August 2015 18:45:38 Alexander Potashev wrote: > 2015-08-01 12:57 GMT+03:00 David Faure : > > Hello Alexander, > > > > thanks for your recent commits related to the unit tests in kross. > > > > However it seems that they don't pass ;) > > > > See > > https://build.kde.org/job/kross%20

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 62 - Fixed!

2015-08-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/62/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 07:37:54 + Build duration: 13 min CHANGE SET Revision 31161e0156db35a7cc23aa7c801b013b68939b89 b

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 62 - Fixed!

2015-08-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/62/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 07:37:54 + Build duration: 13 min CHANGE SET Revision 31161e0156db35a7cc23aa7c801b013b68939b89 b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 67 - Fixed!

2015-08-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/67/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 07:37:54 + Build duration: 11 min CHANGE SET Revision 31161e0156db35a7cc23aa7c801b013b68939b89 by David

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 67 - Fixed!

2015-08-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/67/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 15 Aug 2015 07:37:54 + Build duration: 11 min CHANGE SET Revision 31161e0156db35a7cc23aa7c801b013b68939b89 by David