-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124698/
-----------------------------------------------------------
(Updated Ago. 15, 2015, 1:31 p.m.)
Review request for KDE Frameworks and Christoph Feck.
Changes
-------
* Fixed confusing doxygen
* Replaced the two tooltips with a single, more descriptive one.
Bugs: 224686
https://bugs.kde.org/show_bug.cgi?id=224686
Repository: kwidgetsaddons
Description
-------
Starting from Qt 5.2, adding a trailing QAction to a QLineEdit is fairly
trivial. This patch implements such an action in order to allow a user to show
the password being typed. The action is only available if no password is given
to the dialog as preset.
About the icon: for now I've used `games-hint` from Breeze. Let me know whether
there is a more relevant icon already available. If not, we can either request
it or create a symlink for this one, e.g. `password-hint` or similar.
About the last screenshot: the greyed icon is due to Qt bug
[39660](https://bugreports.qt.io/browse/QTBUG-39660). Once fixed upstream (Qt
5.5?), the action will be properly hidden and there will be no icon greyed out.
Diffs (updated)
-----
src/kpassworddialog.h 9de2724640f483d5ab1134510fb84e1245814d90
src/kpassworddialog.cpp 3d348964b4c44d26c44856fc08c199007a195aca
Diff: https://git.reviewboard.kde.org/r/124698/diff/
Testing
-------
* Create a default KPasswordDialog. The new action is shown as soon as a
password is being typed. The action is no more available as soon as the line
edit is cleared.
* Create a default KPasswordDialog, call `setPassword()` with a non-empty
password and then show the dialog. The action is not available.
File Attachments
----------------
kpassworddialog1.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/11/8e7e0262-c185-42a3-a713-abea97619989__kpassworddialog1.png
kpassworddialog2.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/11/90f1cbf4-952d-498f-b2a6-27d52a1f650f__kpassworddialog2.png
kpassworddialog3.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/11/b4779acb-31b1-4950-87a4-6e65b5de16c6__kpassworddialog3.png
Thanks,
Elvis Angelaccio
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
