Re: Review Request 124611: do not install namelink for private library

2015-08-11 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124611/ --- (Updated Aug. 12, 2015, 6:09 a.m.) Status -- This change has been ma

Re: Review Request 124611: do not install namelink for private library

2015-08-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124611/#review83722 --- Ship it! Ship It! - Martin Gräßlin On Aug. 4, 2015, 10:04

Re: Review Request 124610: do not install namelink for private library

2015-08-11 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124610/ --- (Updated Aug. 12, 2015, 6:06 a.m.) Status -- This change has been ma

Re: git moves

2015-08-11 Thread Valentin Rusu
Sorry, I only see this today, but... * Jonathan Riddell [2015-08-05 18:11:56 +0200]: > some changes to pkg-kde git today: > > I added kwallet-pam to plasma > Why not include the kwallet-pam module in the kwallet framework? The src/runtime would be the perfect place for that module and users w

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 54 - Unstable!

2015-08-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Aug 2015 18:18:24 + Build duration: 4 min 48 sec CHANGE SET Revision d8aafbc37daab3cd62ee77430a55b3d72cc

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 54 - Unstable!

2015-08-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Aug 2015 18:18:24 + Build duration: 4 min 48 sec CHANGE SET Revision d8aafbc37daab3cd62ee77430a55b3d72cc

Re: Review Request 124690: Show custom folder icons again

2015-08-11 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124690/ --- (Updated Aug. 11, 2015, 6:18 p.m.) Status -- This change has been ma

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-11 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- (Updated Ago. 11, 2015, 3:46 p.m.) Review request for KDE Frameworks and

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-11 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/#review83709 --- src/kpassworddialog.cpp (line 128)

Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-11 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- Review request for KDE Frameworks, KDE Usability and Christoph Feck. Bugs

Re: Review Request 124696: Fix (worrying) MSVC warning

2015-08-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124696/ --- (Updated Aug. 11, 2015, 1:22 p.m.) Status -- This change has been ma

Re: [kubuntu-devel] Re: git moves

2015-08-11 Thread Jonathan Riddell
On Tue, Aug 11, 2015 at 01:18:20PM +0200, Valentin Rusu wrote: > * Jonathan Riddell [2015-08-05 18:11:56 +0200]: > > > some changes to pkg-kde git today: > > > > I added kwallet-pam to plasma > > > > Why not include the kwallet-pam module in the kwallet framework? The > src/runtime would be th

Re: Review Request 124696: Fix (worrying) MSVC warning

2015-08-11 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124696/#review83699 --- Ship it! src/iddecorator.cpp (line 36)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 24 - Still Unstable!

2015-08-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Aug 2015 11:05:28 + Build duration: 4 min 39 sec CHANGE SET Revision 6d82a824b3a7e5e87b4691439ecba0

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 24 - Unstable!

2015-08-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Aug 2015 11:05:28 + Build duration: 4 min 18 sec CHANGE SET Revision 6d82a824b3a7e5e87b4691439ecba064a75fa

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 24 - Unstable!

2015-08-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Aug 2015 11:05:28 + Build duration: 4 min 18 sec CHANGE SET Revision 6d82a824b3a7e5e87b4691439ecba064a75fa

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/ --- (Updated Aug. 11, 2015, 11:05 a.m.) Status -- This change has been m

Review Request 124696: Fix (worrying) MSVC warning

2015-08-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124696/ --- Review request for KDE Frameworks and Mirko Boehm. Repository: threadweav

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/#review83697 --- Ship it! - David Faure On Aug. 5, 2015, 10:41 p.m., Sebasti

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread Sebastian Kügler
> On Aug. 6, 2015, 7:13 a.m., David Faure wrote: > > If the goal is to query this property for the K menu for instance, aren't > > you missing an accessor in KService? OK, on the other hand, if this is the > > only user, then property("...") would do too, but still, compile-time > > checking i

Re: Review Request 124682: Cmake fail to parse proper taglib version - extra-cmake-modules

2015-08-11 Thread Luca Sartorelli
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124682/ --- (Updated Aug. 11, 2015, 8:11 a.m.) Review request for KDE Frameworks. R

Re: kross unit tests broken

2015-08-11 Thread David Faure
On Sunday 02 August 2015 18:45:38 Alexander Potashev wrote: > 2015-08-01 12:57 GMT+03:00 David Faure : > > Hello Alexander, > > > > thanks for your recent commits related to the unit tests in kross. > > > > However it seems that they don't pass ;) > > > > See > > https://build.kde.org/job/kross%20