----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124611/#review83722 -----------------------------------------------------------
Ship it! Ship It! - Martin Gräßlin On Aug. 4, 2015, 10:04 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124611/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 10:04 a.m.) > > > Review request for Build System and KDE Frameworks. > > > Repository: kglobalaccel > > > Description > ------- > > please note that the private target is appearing in the resulting cmake > config all the same and we cannot prevent this because of a cmake oddity > Alex Merry was kind enough to track down [1]. > testing suggests that this is however not breaking anything (what with the > library being private). > > [1] http://public.kitware.com/pipermail/cmake-developers/2015-July/025798.html > > > Diffs > ----- > > src/runtime/CMakeLists.txt 1a45ac82bde0dba194e3a2dd4313f7b732cc8129 > > Diff: https://git.reviewboard.kde.org/r/124611/diff/ > > > Testing > ------- > > make && make install > no .so symlink installed > > > Thanks, > > Harald Sitter > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
