Review Request 124289: [kidletime] Install private headers for platform plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124289/ --- Review request for KDE Frameworks. Repository: kidletime Description --

Review Request 124288: [kwindowsystem] Install private headers for platform plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124288/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: KFilePlacesModelTest

Hello, On Saturday 04 July 2015 22:24:50 David Faure wrote: > CI says: > > 10:59:57 QDEBUG : KFilePlacesModelTest::testReparse() Expected: > ("/home/jenkins", "remote:/", "/", "trash:/", "/media/nfs", "/foreign", > "/media/XO-Y4", "/media/floppy0", "/media/cdrom", "/foo") 10:59:57 QDEBUG : > KFil

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

> On July 7, 2015, 9:07 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > src/plugins/voikko/voikkoclient.cpp, line 32 > > > > > > I prefer to error out early («if (!dictionaries) return;»), less > > indentation

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

> On July 7, 2015, 9:38 p.m., Mark Gaiser wrote: > > src/knotificationmanager.cpp, line 89 > > > > > > Don't you have a memory leak here? > > You have a list of pointers which you own here, but QList doesn't k

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/#review82195 --- src/knotificationmanager.cpp (line 87)

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

> On July 7, 2015, 7:07 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > src/plugins/voikko/voikkodict.cpp, line 125 > > > > > > if (replacements.contains(word)) { > > suggestions.append(word); > >

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/#review82192 --- src/plugins/voikko/voikkoclient.cpp (line 28)

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/ --- (Updated July 7, 2015, 9 p.m.) Review request for KDE Frameworks and Mart

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

> On July 7, 2015, 5:10 p.m., Alex Richardson wrote: > > src/knotificationmanager.cpp, line 89 > > > > > > Use `KPluginLoader::findPlugins` or `KPluginLoader::instantiatePlugins` > > and then do the qobject_cast

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

> On July 7, 2015, 4:11 p.m., Aleix Pol Gonzalez wrote: > > src/plugins/voikko/voikkodict.cpp, line 261 > > > > > > qCDebug(SONNET_VOIKKO) << "Loaded" << words.size() << "replacements > > from the user dictionar

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/#review82179 --- Looks good to me otherwise src/knotificationmanager.cpp (lin

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

> On heinä 7, 2015, 2:11 ip, Aleix Pol Gonzalez wrote: > > src/plugins/voikko/voikkodict.cpp, line 261 > > > > > > qCDebug(SONNET_VOIKKO) << "Loaded" << words.size() << "replacements > > from the user dictionary

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/ --- (Updated heinä 7, 2015, 2:44 ip) Review request for KDE Frameworks and Ma

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/ --- (Updated July 7, 2015, 4:42 p.m.) Review request for KDE Frameworks and M

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

> On July 7, 2015, 3:56 p.m., Aleix Pol Gonzalez wrote: > > src/knotificationmanager.cpp, line 89 > > > > > > Would it make any sense to remove this altogether? > > > > If nobody is using it, it sounds us

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/#review82174 --- src/plugins/voikko/voikkoclient.h (line 37)

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/ --- (Updated heinä 7, 2015, 2 ip) Review request for KDE Frameworks and Marti

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/#review82175 --- I like it! - Martin Gräßlin On July 7, 2015, 2:52 p.m., Mar

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/#review82172 --- src/knotificationmanager.cpp (line 87)

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

> On July 7, 2015, 2:16 p.m., Hrvoje Senjan wrote: > > Seems kwindowsystem master doesn't build now (against Qt 5.5 at least): > > > > ``` > > [ 55s] In file included from > > /home/abuild/rpmbuild/BUILD/kwindowsystem-5.12.0git.20150707T133122~569a723/src/kwindowinfo.cpp:21:0: > > [ 55s] >

Review Request 124282: Implement Voikko based spellchecker for Sonnet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Review Request 124281: Remove KService and KIconThemes usage from KNotifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: knotifi

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/#review82168 --- Seems kwindowsystem master doesn't build now (against Qt 5.5 a

Re: Review Request 124266: Introduce an env variable to overwrite the platform name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124266/ --- (Updated July 7, 2015, 11:35 a.m.) Status -- This change has been ma

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124222/ --- (Updated July 7, 2015, 11:34 a.m.) Status -- This change has been ma

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/ --- (Updated July 7, 2015, 11:31 a.m.) Status -- This change has been ma

Re: Review Request 124212: kwindowsystem: Change source file layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124212/ --- (Updated July 7, 2015, 11:31 a.m.) Status -- This change has been ma

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/ --- (Updated July 7, 2015, 11:26 a.m.) Status -- This change has been ma

Re: Review Request 124147: Create Data Dir If it Does Not Exist

> On July 2, 2015, 9:47 a.m., David Faure wrote: > > src/ioslaves/http/kcookiejar/kcookieserver.cpp, line 68 > > > > > > This would be worth a qWarning too. > > > > And then I would still return a non-nul

Re: Review Request 124147: Create Data Dir If it Does Not Exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124147/ --- (Updated July 7, 2015, 8:29 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 124147: Create Data Dir If it Does Not Exist

> On July 2, 2015, 9:47 a.m., David Faure wrote: > > src/ioslaves/http/kcookiejar/kcookieserver.cpp, line 68 > > > > > > This would be worth a qWarning too. > > > > And then I would still return a non-nul