> On July 2, 2015, 9:47 a.m., David Faure wrote: > > src/ioslaves/http/kcookiejar/kcookieserver.cpp, line 68 > > <https://git.reviewboard.kde.org/r/124147/diff/2/?file=380949#file380949line68> > > > > This would be worth a qWarning too. > > > > And then I would still return a non-null string, so the rest of the > > code can (try to) keep going. > > > > No point in giving up because of a permission problem; I would warn and > > keep going with the filename, to give a chance to the user to fix the > > permission problem and not have to reboot. > > David Narváez wrote: > The whole reason why I started working on this is because the cookie > server was continuing without letting me know about the fact that it could > not create this folder. Is there a way to notify the user with more than a > qWarning() (after all this is running from kded5) like a popup dialog, > notification or something? If this crashes there will at least be a drkonqi > dialog to notify the user.
Yeah, you can show a messagebox. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124147/#review81981 ----------------------------------------------------------- On July 7, 2015, 8:29 a.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124147/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 8:29 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Prevents a cold start bug when the data dir is not created. Also, by > storing the file name as a member of the KCookieServer class we avoid > calculating it every time cookies are saved. > > > Diffs > ----- > > src/ioslaves/http/kcookiejar/kcookieserver.h > f61c7d0e4da58b805565632cf3dd484445c21275 > src/ioslaves/http/kcookiejar/kcookieserver.cpp > ac585a0b04637c485647564d18a89a75d6c11d97 > > Diff: https://git.reviewboard.kde.org/r/124147/diff/ > > > Testing > ------- > > Restarted kded5 with no file named kcookiejar inside ~/.local/share and with > a regular file named kcookiejar in that location. > > > Thanks, > > David Narváez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
