Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

2015-05-29 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123929/#review80962 --- src/filewidgets/kdiroperator.cpp (line 1298)

Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

2015-05-29 Thread Ashish Bansal
> On May 29, 2015, 12:45 p.m., David Faure wrote: > > I'm not sure this is a good idea, usability wise. Miss an icon by one > > pixel, and the effect is to go up, making the whole set of icons disappear? Well about usability there's already discussion going on dolphin RR 123658. Single click i

Jenkins-kde-ci: kdoctools master kf5-qt5 » OSX,clang - Build # 9 - Fixed!

2015-05-29 Thread no-reply
We thank you for fixing your build!___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123940: Use KPluginLoader::factory() when loading KIO::DndPopupMenuPlugin

2015-05-29 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123940/#review80959 --- Ship it! Ship It! - Alex Richardson On May 29, 2015, 11:09

Jenkins-kde-ci: kdoctools master kf5-qt5 » OSX,clang - Build # 8 - Still Failing!

2015-05-29 Thread no-reply
Check console output at https://build.kde.org/job/kdoctools%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/8/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-framew

Review Request 123940: Use KPluginLoader::factory() when loading KIO::DndPopupMenuPlugin

2015-05-29 Thread Ragnar Thomsen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123940/ --- Review request for Dolphin, KDE Frameworks, Emmanuel Pescosta, and Harald H

Jenkins-kde-ci: kdoctools master kf5-qt5 » OSX,clang - Build # 7 - Failure!

2015-05-29 Thread no-reply
Check console output at https://build.kde.org/job/kdoctools%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/7/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-framew

Re: Proposal: move KWalletManager inside KWallet framework

2015-05-29 Thread Valentin Rusu
* Stefan Bruens [2015-05-29 03:48:46 +0200]: > > > Details: > > > > > > 1. kwalletd5 checks the migration status. In case it already has run, it > > > immediately signals completion, otherwise the wizard is run and completion > > > is signaled afterwards. > > > > > > 2. Upon migration completio

Review Request 123939: KAssistantDialog: Re-add the Help button that was present in KDELibs4 version

2015-05-29 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123939/ --- Review request for KDE Frameworks, Christoph Feck and Kevin Ottens. Repos

Re: Review Request 123930: WIP: Make the speller dict cache static.

2015-05-29 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123930/#review80953 --- Having a static cache sounds reasonable to me and I think it m

Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

2015-05-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123929/#review80946 --- I'm not sure this is a good idea, usability wise. Miss an icon