----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123940/ -----------------------------------------------------------
Review request for Dolphin, KDE Frameworks, Emmanuel Pescosta, and Harald Hvaal. Repository: kio Description ------- This patch fixes an error when loading the DndPopupMenuPlugin of Ark (frameworks branch). DndPopupMenuPlugins use the K_PLUGIN_FACTORY_WITH_JSON macro, and therefore KPluginLoader::factory() should be used instead of KPluginLoader::instance() which is used by KPluginMetaData::instantiate(). The DndPopupMenuPlugin is used by Ark to enable the "Extract here" menu option when dragging an archive in Dolphin. Diffs ----- src/widgets/dropjob.cpp 63beb0a Diff: https://git.reviewboard.kde.org/r/123940/diff/ Testing ------- The "Extract here" option now appears when dragging an archive in Dolphin (current frameworks branch), and extraction works as expected. Thanks, Ragnar Thomsen
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
