Proposal: move KWalletManager inside KWallet framework

2015-05-25 Thread Valentin Rusu
Hello, Since the release 15.04 I see more and more users puzzled about their KDE Wallet set-up. For example, see this [1]. They have existing KDE4 wallets which get migrated by the KF5::KWallet::kwalletd5 migration agent, but have no means to look into/configure their migrated wallet, as KWalletMa

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-25 Thread Martin Gräßlin
> On May 25, 2015, 8:09 p.m., Eike Hein wrote: > > Preserving the owner of an existing file is a good idea, but won't help if > > there isn't one yet ...? > > David Edmundson wrote: > I put in the other two fixes too, the next app would wipe that file and > rebuild the DB. > > Eike Hein w

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

2015-05-25 Thread Bhushan Shah
> On May 25, 2015, 11:09 p.m., Allen Winter wrote: > > This is incorrect. std::abs comes from cstdlib, not cmath > > please fix accordingly. I have it compiling here fine on my macbook with > > #include instead of #include Fixed with http://commits.kde.org/ki18n/f0a4b6f1564efe397d804ac4ad17

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-25 Thread Eike Hein
> On May 25, 2015, 6:09 p.m., Eike Hein wrote: > > Preserving the owner of an existing file is a good idea, but won't help if > > there isn't one yet ...? > > David Edmundson wrote: > I put in the other two fixes too, the next app would wipe that file and > rebuild the DB. I guess I'm not

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-25 Thread David Edmundson
> On May 25, 2015, 6:09 p.m., Eike Hein wrote: > > Preserving the owner of an existing file is a good idea, but won't help if > > there isn't one yet ...? I put in the other two fixes too, the next app would wipe that file and rebuild the DB. - David ---

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

2015-05-25 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/#review80819 --- Preserving the owner of an existing file is a good idea, but w

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Elvis Stansvik
2015-05-25 16:48 GMT+02:00 Boudewijn Rempt : > Hi Elvis, > > If you've got kdemacors.h in /usr/include (for instance because you've > also got a kde4 dev env) then you won't encounter the error. The issue is > that the expanded list of includes is enclosed in "", which breaks the > build. Oh I s

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Elvis Stansvik
2015-05-25 16:13 GMT+02:00 Boudewijn Rempt : > Weird, it worked for me: > > https://paste.kde.org/pmvwwhyqp -- in fact, the header file isn't used or > needed in the example at all. I seem to be getting the same result as Alex (I think): https://paste.kde.org/pke2ztbok I'm a little pussled by y

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

2015-05-25 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123867/#review80817 --- This is incorrect. std::abs comes from cstdlib, not cmath ple

Re: Review Request 123902: Missing "or" when looking for .cmake and CMakeLists.txt files

2015-05-25 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123902/ --- (Updated May 25, 2015, 4:06 p.m.) Status -- This change has been mar

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Boudewijn Rempt
Hi Elvis, If you've got kdemacors.h in /usr/include (for instance because you've also got a kde4 dev env) then you won't encounter the error. The issue is that the expanded list of includes is enclosed in "", which breaks the build. On Mon, 25 May 2015, Elvis Stansvik wrote: 2015-05-25 16:

Re: Review Request 123902: Missing "or" when looking for .cmake and CMakeLists.txt files

2015-05-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123902/#review80811 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 25, 2015, 4:

Review Request 123902: Missing "or" when looking for .cmake and CMakeLists.txt files

2015-05-25 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123902/ --- Review request for KDE Frameworks, Plasma, Kevin Ottens, and Burkhard Lück.

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Boudewijn Rempt
On Mon, 25 May 2015, Stephen Kelly wrote: Boudewijn Rempt wrote: Here's an SSCCE that demonstrates the problem with Vc 0.7.4: cmake_minimum_required(VERSION 3.0) project(VcTest) set(CMAKE_INCLUDE_CURRENT_DIR ON) find_package(Qt5Core REQUIRED) find_package(Vc REQUIRED) # Uncomment thi

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Boudewijn Rempt
Hm, to expand on that: if you're running into compile problems, well, then my problem would be solved. I've tested on kubuntu vivid, with cmake 3.0.2 and the 5.9.0 packages. On Mon, 25 May 2015, Boudewijn Rempt wrote: Weird, it worked for me: https://paste.kde.org/pmvwwhyqp -- in fact, the h

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Boudewijn Rempt
Weird, it worked for me: https://paste.kde.org/pmvwwhyqp -- in fact, the header file isn't used or needed in the example at all. On Mon, 25 May 2015, Alex Merry wrote: On Monday 25 May 2015 15:31:52 Boudewijn Rempt wrote: http://www.valdyas.org/~boud/vc-cmake-3.tgz is as minimal as I know h

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Alex Merry
On Monday 25 May 2015 15:31:52 Boudewijn Rempt wrote: > http://www.valdyas.org/~boud/vc-cmake-3.tgz is as minimal as I know how to > make it: you still need qt, KDELibs4Support and extra-cmake-modules > installed. After that, running cmake and make VERBOSE=1 will give the > exact problem I've got.

Re: Review Request 123852: Optimize: Do not wipe dict cache when copying speller objects.

2015-05-25 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123852/ --- (Updated May 25, 2015, 1:59 p.m.) Status -- This change has been mar

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Boudewijn Rempt
On Mon, 25 May 2015, Stephen Kelly wrote: Boudewijn Rempt wrote: Yes, exactly. I've tried to find some documenation about this change, but apart from the rather unhelpful info in e.g. http://www.cmake.org/cmake/help/v3.1/manual/cmake-generator-expressions.7.html I couldn't find anything. I don

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Boudewijn Rempt
On Mon, 25 May 2015, Alex Merry wrote: include_directories("$") Well, I've tried that before, I think... It expands to this: /usr/bin/c++ -std=c++0x -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Alex Merry
On Monday 25 May 2015 13:50:08 Boudewijn Rempt wrote: > On Mon, 25 May 2015, Alex Merry wrote: > > Ah, yes. You may get somewhere with > > include_directories($) > > > > Basically, this should replace all those semicolons in the generated > > output > > with " -I", which should produce a correct c

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Boudewijn Rempt
On Mon, 25 May 2015, Alex Merry wrote: Ah, yes. You may get somewhere with include_directories($) Basically, this should replace all those semicolons in the generated output with " -I", which should produce a correct command line. This is untested, though. Hm... No luck here. This outputs an

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Alex Merry
On Monday 25 May 2015 13:03:40 Boudewijn Rempt wrote: > On Mon, 25 May 2015, Alex Merry wrote: > > The issue here is that Vc's macros implicitly assume that all compilation > > flags (including include paths) are done at the directory level (with > > include_directories() and setting CMAKE_CXX_FLAG

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Boudewijn Rempt
On Mon, 25 May 2015, Alex Merry wrote: The issue here is that Vc's macros implicitly assume that all compilation flags (including include paths) are done at the directory level (with include_directories() and setting CMAKE_CXX_FLAGS etc), while CMake is moving towards doing things at the target

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Alex Merry
On Saturday 23 May 2015 11:51:55 Boudewijn Rempt wrote: > Sorry for the extensive cross-posting in advance, please when replying, do > a reply-all. > > Just so everyone is on the same page: Vc is a template library that makes > it easy to build vectorized code using a single source file. Krita use

Re: Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123838/ --- (Updated May 25, 2015, 8:23 a.m.) Status -- This change has been mar

Re: Review Request 123731: Cleanup handling of notifications closing

2015-05-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123731/ --- (Updated May 25, 2015, 8:23 a.m.) Status -- This change has been mar