Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123867/ --- Review request for KDE Frameworks and Milian Wolff. Repository: ki18n D

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/#review80677 --- src/kbuildsycoca/kbuildsycoca.cpp (line 426)

Re: Review Request 123852: Optimize: Do not wipe dict cache when copying speller objects.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123852/#review80674 --- +1 I don't see the reason to clear the cache on the copy ass

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/ --- (Updated May 20, 2015, 6:33 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

> On May 20, 2015, 10:37 a.m., Luigi Toscano wrote: > > One thing is discouraging running applications as root, another thing is > > blocking them completely: what will it happen with this patch when the > > application is run as root, simply no cache and slower application? > > > > Isn't it p

Re: Review Request 123735: version of QmlObject with a static engine

> On May 20, 2015, 5:24 p.m., Vishesh Handa wrote: > > src/quickaddons/quickviewsharedengine.h, line 41 > > > > > > It would be awesome if we could have some tests for this class. > > > > Maybe we can ju

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80669 --- src/quickaddons/quickviewsharedengine.h (line 41)

Re: Review Request 123861: Make KCodecs::base64Encode() RFC compliant

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123861/#review80663 --- +1 - Aleix Pol Gonzalez On May 20, 2015, 2:46 p.m., Daniel

Re: Review Request 123858: Fix memory leak in drags

> On May 20, 2015, 12:59 p.m., David Edmundson wrote: > > Turns out this isn't needed. It's a seemingly undocumented 'feature' the > > drag will be deleted by QDragManager::drag() when dropped > > Sorry for the noise. and by undocummneted, what I mean is; Clearly written in the documentation ha

Re: Review Request 123858: Fix memory leak in drags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123858/ --- (Updated May 20, 2015, 12:59 p.m.) Status -- This change has been di

Re: Review Request 123858: Fix memory leak in drags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123858/#review80659 --- Turns out this isn't needed. It's a seemingly undocumented 'fe

Review Request 123861: Make KCodecs::base64Encode() RFC compliant

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123861/ --- Review request for KDE Frameworks. Repository: kcodecs Description

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

> On May 20, 2015, 10:37 a.m., Luigi Toscano wrote: > > One thing is discouraging running applications as root, another thing is > > blocking them completely: what will it happen with this patch when the > > application is run as root, simply no cache and slower application? > > > > Isn't it p

Re: Review Request 123857: Fix crash after a user has launched kbuildsycoca as root.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123857/#review80654 --- One thing is discouraging running applications as root, anothe