Re: Review Request 123452: Expose KJob::capabilities property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123452/#review79421 --- Ship it! Ship It! - Kevin Funk On April 21, 2015, 4:24 p.m

Re: Review Request 123452: Expose KJob::capabilities property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123452/#review79418 --- Bump? It's a simple-enough patch, I'll push this tomorrow if n

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 24, 2015, 2:53 a.m.) Review request for KDE Frameworks and

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

> On April 24, 2015, 12:33 a.m., Alex Richardson wrote: > > src/lib/io/kdirwatch.cpp, line 303 > > > > > > Why this manual loop instead of strlen()? Does that mean that null > > characters in the middle are vali

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79415 --- src/lib/io/kdirwatch.cpp (line 303)

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79411 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 23, 2015,

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79404 --- +1 from me, but I don't want to hit ship it without hearing fr

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79403 --- autotests/kconfig_compiler/test13.cpp.ref (line 18)

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/ --- (Updated April 23, 2015, 5:19 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

> On April 23, 2015, 6:55 p.m., Milian Wolff wrote: > > How are kf5 releases handled btw? Do I need to push this into some branch? > > There are none in kcoreaddons. This patch here should probably be put into > > a patch release (if we do this for kf5). The current schedule is one release eve

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

> On April 23, 2015, 12:55 p.m., Milian Wolff wrote: > > How are kf5 releases handled btw? Do I need to push this into some branch? > > There are none in kcoreaddons. This patch here should probably be put into > > a patch release (if we do this for kf5). > > Luigi Toscano wrote: > The cur

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79400 --- LGTM, but I think having/modifying a unit test for this change

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/ --- (Updated April 23, 2015, 4:50 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/#review79399 --- How are kf5 releases handled btw? Do I need to push this into

Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/ --- Review request for KDE Frameworks, David Faure, Marc Mutz, and Volker Kraus

Re: Places bookmark bug - Help needed

On Thursday 23 April 2015, Emmanuel Pescosta wrote: > So the possible solutions I see are: > * Store the bookmarks in one file (user-places.xbel) and remove the syncing I like the idea of storing places bookmarks only in a cross desktop location . I think they were initially synced in two places d

Places bookmark bug - Help needed

Hi everyone, I want to ask you, if you can help me to fix the "Places bookmarks disappear" bug [1], which was introduced by commit 2b5c6e42fc8114c6854ce490b9cdd4356be683d9 in kdelibs [2]. The adoption for Dolphin [3] has no effect on this bug. I have done some research and I'm a little bit confu

Re: Review Request 123477: Add public dependency on NetworkManager

On April 23, 2015, 1:35 p.m., Jan Grulich wrote: > > And yes, this is required as long as NetworkManager headers are included by > > NetworkManagerQt headers. > > Jan Grulich wrote: > I just found out that installing FindNetworkManager.cmake into CMake > modules is not enough, because it s

Re: Review Request 123477: Add public dependency on NetworkManager

On April 23, 2015, 3:35 p.m., Jan Grulich wrote: > > And yes, this is required as long as NetworkManager headers are included by > > NetworkManagerQt headers. > > Jan Grulich wrote: > I just found out that installing FindNetworkManager.cmake into CMake > modules is not enough, because it s

Re: Review Request 123477: Add public dependency on NetworkManager

On Dub. 23, 2015, 1:35 odp., Jan Grulich wrote: > > And yes, this is required as long as NetworkManager headers are included by > > NetworkManagerQt headers. > > Jan Grulich wrote: > I just found out that installing FindNetworkManager.cmake into CMake > modules is not enough, because it st

Re: Review Request 123478: ensure the filePath "metadata" is there

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123478/ --- (Updated April 23, 2015, 2:41 p.m.) Status -- This change has been m

Re: Review Request 123478: ensure the filePath "metadata" is there

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123478/#review79394 --- Ship it! Yes, please. I was wondering if I could rely on met

Review Request 123478: ensure the filePath "metadata" is there

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123478/ --- Review request for KDE Frameworks, Plasma and Sebastian Kügler. Repositor

Re: Review Request 123477: Add public dependency on NetworkManager

On April 23, 2015, 3:35 p.m., Jan Grulich wrote: > > And yes, this is required as long as NetworkManager headers are included by > > NetworkManagerQt headers. > > Jan Grulich wrote: > I just found out that installing FindNetworkManager.cmake into CMake > modules is not enough, because it s

Re: Review Request 123477: Add public dependency on NetworkManager

> On Dub. 23, 2015, 1:35 odp., Aleix Pol Gonzalez wrote: > > KF5NetworkManagerQtConfig.cmake.in, line 4 > > > > > > nitpick. weird 1 space indentation. Already spotted. On Dub. 23, 2015, 1:35 odp., Jan Grulich w

Re: Review Request 123477: Add public dependency on NetworkManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123477/#review79383 --- KF5NetworkManagerQtConfig.cmake.in (line 4)

cmake licences inline

Rather than referring to a separate COPYING-CMAKE-SCRIPTS file, which can get lost and not included, please just include the BSD licence inline in your cmake modules. Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mai

Jenkins build is back to stable : kpty_stable_qt5 #19

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 123477: Add public dependency on NetworkManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123477/ --- Review request for KDE Frameworks, David Faure, Daniel Vrátil, and Lamarque

Build failed in Jenkins: kinfocenter_stable_qt5 #18

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUIL

Build failed in Jenkins: kinfocenter_stable_qt5 #17

See Changes: [jr] Update version number for 5.3.0 -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in worksp

Re: New framework: KF5Syndication

On Thursday 23 April 2015, David Edmundson wrote: > > It's a Tier 3 Framework (depends on KCodecs and KIO). AFAIK it's > > currently being > > used only by Akregator. > > There is another (depending on the definition of "currently") > > Plasma 4 used it for an RSS reader plasmoid. > In Plasma 5 t

Re: New framework: KF5Syndication

On Wed, Apr 22, 2015 at 9:44 PM, Daniel Vrátil wrote: > Hi all, > > I'd like to ask for review of another Framework from kdepimlibs: > KF5Syndication > > KF5Syndication is an RSS/Atom parsing library. It also provides API to > fetch > feeds directly from network. > > It's a Tier 3 Framework (depe