Re: Review Request 123178: [KCompletion] Delete condition inside KLineEdit::keyPressEvent that is already checked in a former condition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123178/ --- (Updated April 7, 2015, 6:41 a.m.) Review request for KDE Frameworks. C

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On March 17, 2015, 6:05 p.m., Christophe Giboudeaux wrote: > > src/plugins/hunspell/CMakeLists.txt, line 9 > > > > > > endif() > > Eugene Shalygin wrote: > Ping? He means you shouldn't put anything inside e

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review78586 --- This doesn't let the user change the path but the distributor,

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

> On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: > > Just a question - why is the current suggested name wrong? In name "filename-1.6.tar.gz", 1.6 denotes package version and new suggested name changes it to "filename-1 2.6.tar.gz". It should add 1 after the package version and should no

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On Березень 17, 2015, 6:05 після полудня, Christophe Giboudeaux wrote: > > src/plugins/hunspell/CMakeLists.txt, line 9 > > > > > > endif() Ping? - Eugene -

Re: Review Request 123268: Fix extraction of some messages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123268/ --- (Updated April 6, 2015, 2:36 p.m.) Status -- This change has been ma

Re: Review Request 123265: Remove unused dependency.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123265/ --- (Updated April 6, 2015, 1:50 p.m.) Status -- This change has been ma

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review78559 --- Just a question - why is the current suggested name wrong? a

Re: Review Request 123268: Fix extraction of some messages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123268/#review78556 --- Ship it! Ship It! - David Faure On April 5, 2015, 7:06 p.m

Re: CI yesterday

On Sunday 05 April 2015 19:59:48 Bhushan Shah wrote: > On Sun, Apr 5, 2015 at 7:52 PM, David Faure wrote: > > Sorry for all the CI noise, the version upgrades required the new ECM > > version (5.9 instead of 1.9) which wasn't built yet due to CI being > > exceptionnally slow (only one slave runnin

Re: Review Request 123223: Fix bug 344614: kservice splits filename wrong

> On April 4, 2015, 9:34 a.m., David Faure wrote: > > Well spotted. > > > > I would however do what the commit says and just replace indexOf with > > lastIndexOf. QFileInfo::completeBaseName does much more work, see > > QFileSystemEntry::completeBaseName(). > > > > About the unittest: the sol