----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123268/ -----------------------------------------------------------
(Updated April 6, 2015, 2:36 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes ------- Submitted with commit 5fcad6720b2815ca85b9a67f086900883e95734c by Lasse Liehu to branch master. Repository: kwidgetsaddons Description ------- Wrapping QCoreApplication::translate calls into a new function broke extraction. Also ported remaining I18N_NOOP2 uses to Qt's i18n system. Added semicolons to the end of QT_TRANSLATE_NOOP3 uses because without them only the first //: comment would be extracted. Diffs ----- src/fonthelpers.cpp 1a1a2f4 src/kdatetimeedit.cpp 63686ad src/kmessagebox.cpp 7c2a577 src/kmimetypechooser.cpp 51c4044 Diff: https://git.reviewboard.kde.org/r/123268/diff/ Testing ------- Compiled and ran unit tests. Also ran lrelease locally and checked that messages and their //: comments were extracted properly. Thanks, Lasse Liehu
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
