Re: Review Request 122206: [kio] Make tests optional

> On March 17, 2015, 3:37 a.m., Albert Vaca Cintora wrote: > > I know this is merged already but this patch is being applied to every KDE > > package and I want to keep the discussion in a single place. > > > > We already have a toggle option in CMake that is "BUILD_TESTING". If Gentoo > > wan

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On März 17, 2015, 1:07 nachm., Laurent Montel wrote: > > src/plugins/hunspell/hunspellclient.cpp, line 27 > > > > > > #include "..." > > we use local file. No, the file is in an include path, not in the sam

Re: Review Request 122206: [kio] Make tests optional

> On mar. 17, 2015, 3:37 a.m., Albert Vaca Cintora wrote: > > I know this is merged already but this patch is being applied to every KDE > > package and I want to keep the discussion in a single place. > > > > We already have a toggle option in CMake that is "BUILD_TESTING". If Gentoo > > want

Re: What's the point of tiers if we bend the definition of them?

El Dimarts, 17 de març de 2015, a les 09:16:50, Kevin Ottens va escriure: > On Tuesday 17 March 2015 08:21:22 Martin Gräßlin wrote: > > On Monday 16 March 2015 23:16:51 Albert Astals Cid wrote: > > > We have KPackage depending on kdoctools but since it's optional we > > > pretend > > > it's not a r

Re: Review Request 122206: [kio] Make tests optional

> On March 16, 2015, 8:37 p.m., Albert Vaca Cintora wrote: > > I know this is merged already but this patch is being applied to every KDE > > package and I want to keep the discussion in a single place. > > > > We already have a toggle option in CMake that is "BUILD_TESTING". If Gentoo > > wan

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On Березень 17, 2015, 6:05 після полудня, Christophe Giboudeaux wrote: > > src/plugins/hunspell/CMakeLists.txt, line 7 > > > > > > So you change an hardcoded path by a user chosen hardcoded one ? > > > >

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review77647 --- src/plugins/hunspell/CMakeLists.txt

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

> On March 17, 2015, 4:38 p.m., David Faure wrote: > > Ship It! Yes, both in kdelibs 4 and in the kio framework. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122652/#review776

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122652/#review77642 --- Ship it! Ship It! - David Faure On March 17, 2015, 4:17 p.

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122652/ --- (Updated March 17, 2015, 4:17 p.m.) Review request for KDE Frameworks, kd

Jenkins build is back to stable : frameworkintegration_stable_qt5 #42

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : frameworkintegration_master_qt5 #176

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KIOSK feature in kconfig framework

Hello, I am planning to work on KIOSK tool during the GSoC 2015, so I came across this code in the kconfig framework while searching for things. I came across this code, #pragma message("TODO: enable kiosk feature again (resource restrictions), but without KStandardDirs... Needs a class in the kc

Jenkins build became unstable: frameworkintegration_stable_qt5 #41

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122918: revert 2ee76f0 to fix QtQuickControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122918/ --- (Updated March 17, 2015, 2:26 p.m.) Status -- This change has been d

Jenkins build became unstable: frameworkintegration_master_qt5 #175

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120467: Native Qt Quick FileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120467/ --- (Updated March 17, 2015, 2:22 p.m.) Status -- This change has been m

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review77636 --- Ok for me. Just wait that maintainer gives you a "Ship it" -

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated Березень 17, 2015, 2:09 після полудня) Review request for KDE Fr

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review77630 --- src/plugins/hunspell/hunspellclient.cpp

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review77631 --- I am not maintainer of this module but I can put a "+1" - Lau

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On Березень 17, 2015, 1:41 після полудня, Luigi Toscano wrote: > > (not entitled to give a ship it, but) have you checked if this is still > > relevant for the Sonnet framework? > > Luigi Toscano wrote: > Ups, this review is for sonnet; I was confused by the group (please use > kdeframew

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated Березень 17, 2015, 2:05 після полудня) Review request for KDE Fr

Re: Review Request 122206: [kio] Make tests optional

> On March 17, 2015, 3:37 a.m., Albert Vaca Cintora wrote: > > I know this is merged already but this patch is being applied to every KDE > > package and I want to keep the discussion in a single place. > > > > We already have a toggle option in CMake that is "BUILD_TESTING". If Gentoo > > wan

Fwd: frameworkintegration QFileDialog bug

Adding frameworks list. -- Forwarded message -- From: Jeremy Whiting Date: Mon, Mar 16, 2015 at 8:57 PM Subject: frameworkintegration QFileDialog bug To: kdelibs Hey all, We have a strange bug in frameworkintegration https://bugs.kde.org/show_bug.cgi?id=334963 which really oug

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated Березень 17, 2015, 1:50 після полудня) Review request for KDE Fr

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated Березень 17, 2015, 1:50 після полудня) Review request for KDE Fr

Re: Review Request 122484: KCodecs: Fix i18n of character set names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122484/ --- (Updated March 17, 2015, 11:21 a.m.) Status -- This change has been

Re: Review Request 122484: KCodecs: Fix i18n of character set names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122484/#review77612 --- Ship it! Ship It! - David Faure On March 17, 2015, 12:19 a

Re: What's the point of tiers if we bend the definition of them?

On Tuesday 17 March 2015 08:21:22 Martin Gräßlin wrote: > On Monday 16 March 2015 23:16:51 Albert Astals Cid wrote: > > We have KPackage depending on kdoctools but since it's optional we pretend > > it's not a real dependency and call KPackage tier2 > > > > What's in it for us other than lying to

Re: What's the point of tiers if we bend the definition of them?

On Monday 16 March 2015 23:16:51 Albert Astals Cid wrote: > We have KPackage depending on kdoctools but since it's optional we pretend > it's not a real dependency and call KPackage tier2 > > What's in it for us other than lying to ourselves? What's so bad about > KPackage being tier 3? > > It'd

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review77606 --- Could you please add another test case in kglobalshortcuttests

Re: Review Request 122978: Add unit test for crash of bug 343976

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122978/ --- (Updated March 17, 2015, 7:06 a.m.) Status -- This change has been m