Re: KAction Warning

On Saturday 19 July 2014 23:57:15 Christoph Cullmann wrote: > Hi, > > perhaps that is a stupid question, but last time I read up in the docs, they > didn't help me: > > KatePart spits out a lot of: > > kate(15138)/(default) KXMLGUIFactoryPrivate::saveDefaultActionProperties: > Shortcut for KActi

Re: Review Request 119382: Port kio-mtp to KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119382/#review63827 --- Ship it! Ship It! - David Faure On July 26, 2014, 8:40 a.m

Re: OSX/CI: KCrash misses DrKonqi

On Sunday 20 July 2014 19:38:10 Marko Käning wrote: > Hi, > > while pondering [1] I noticed that KCrash actually misses DrKonqi on OSX: > --- > $ tree /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kcrash > /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kcrash > └── inst >

Interesting issue with KAboutData and icons

Hi all, I received a bug (https://bugs.kde.org/show_bug.cgi?id=337938) reported against KAboutData in KCoreAddons, that setting the window icon doesn't actually set the window icon. In fact, KAboutData doesn't even try to, except for setting a property to the string name of the icon in questio

Re: Review Request 119590: Disable the DDS and JPEG-2000 plugins when Qt version is 5.3 or later

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119590/ --- (Updated Aug. 4, 2014, 9:51 p.m.) Status -- This change has been mar

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. > > Sune Vuorela wr

Re: Moderator?

On Tue, Aug 5, 2014 at 8:12 AM, Brian Duffy wrote: > Hi I'm still waiting for a post from last friday to be ok'd by the > moderator. Is that normal, or should I repost? Hi Brian, Your post appears to have been approved - see http://mail.kde.org/pipermail/kde-frameworks-devel/2014-August/018012.h

Re: Review Request 119594: fix FileDialog size restorage

> On Aug. 4, 2014, 12:11 nachm., Martin Klapetek wrote: > > This does fix the issue here; +1 from me > > > > Also, are you investigating/reporting the bug to Qt devs? > > Thomas Lübking wrote: > On a quick glimpse, it looks like the issue is that QWidgetWindow syncs > stuff and that it syn

Re: Review Request 119593: Ensure there's a platform window before restoring the window geometry and then process the resize

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119593/ --- (Updated Aug. 4, 2014, 8:39 nachm.) Review request for KDE Frameworks, kd

Moderator?

Hi I'm still waiting for a post from last friday to be ok'd by the moderator. Is that normal, or should I repost? -- Duff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review63815 --- Ship it! You dedice :) Thanks. autotests/kcolumnresizertest

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated Aug. 4, 2014, 6:09 p.m.) Review request for KDE Frameworks and P

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/#review63812 --- src/platformtheme/khintssettings.cpp

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. > > Sune Vuorela wr

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

> On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: > > Another thing I would like an opinion on, is about the color scheme: right now it searches for a configured color scheme name, then searches in the package a file with the same name as the color scheme name. I was thinking it may be prett

Re: KF5 is not longer building against Qt 5.4

On Mon, Aug 4, 2014 at 5:10 PM, Luigi Toscano wrote: > On Monday 04 of August 2014 17:01:54 Aleix Pol wrote: > > Hi, > > I just found out that qMessageFormatString got renamed > > into qMessageFormatString, that's the commit message [1]. > > Anybody has a better solution than a good ol' ifdef? >

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

> On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: > > src/platformtheme/khintssettings.cpp, line 53 > > > > > > I don't think we want to call the default look and feel package > > something like > > maybe

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

> On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: > > src/platformtheme/khintssettings.cpp, line 53 > > > > > > I don't think we want to call the default look and feel package > > something like > > maybe

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 7, 2014, 1:10 p.m., David Faure wrote: > > Very nice. > > > > The question of "why not in Qt" hasn't been answered though :) > > Aurélien Gâteau wrote: > If you think this has a chance to get in, I can propose it. > > Aleix Pol Gonzalez wrote: > I think it would be accepted.

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

> On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: > > src/platformtheme/khintssettings.cpp, line 53 > > > > > > I don't think we want to call the default look and feel package > > something like > > maybe

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

> On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: > > src/platformtheme/khintssettings.cpp, line 53 > > > > > > I don't think we want to call the default look and feel package > > something like > > maybe

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated Aug. 4, 2014, 3:18 p.m.) Review request for KDE Frameworks and P

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

> On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: > > src/platformtheme/khintssettings.cpp, line 53 > > > > > > I don't think we want to call the default look and feel package > > something like > > maybe

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On juin 7, 2014, 3:10 après-midi, David Faure wrote: > > Very nice. > > > > The question of "why not in Qt" hasn't been answered though :) > > Aurélien Gâteau wrote: > If you think this has a chance to get in, I can propose it. > > Aleix Pol Gonzalez wrote: > I think it would be acce

Re: KF5 is not longer building against Qt 5.4

Hi! El 04/08/2014 17:02, "Aleix Pol" escribió: > > Hi, > I just found out that qMessageFormatString got renamed into qMessageFormatString, actually into qFormatLogMessage ;-) Cheers David Gil that's the commit message [1]. > Anybody has a better solution than a good ol' ifdef? > > Aleix > > [

Re: KF5 is not longer building against Qt 5.4

On Monday 04 of August 2014 17:01:54 Aleix Pol wrote: > Hi, > I just found out that qMessageFormatString got renamed > into qMessageFormatString, that's the commit message [1]. > Anybody has a better solution than a good ol' ifdef? Is qFormatLogMessage just added or does it replace the old functi

KF5 is not longer building against Qt 5.4

Hi, I just found out that qMessageFormatString got renamed into qMessageFormatString, that's the commit message [1]. Anybody has a better solution than a good ol' ifdef? Aleix [1] commit e968793e81ffcb439210e7eb422c0063834cfdc9 Author: Kai Koehne Date: Fri Jul 18 14:40:59 2014 +0200 Add q

Re: Review Request 119523: port TextField to QtControls

On July 28, 2014, 6:54 p.m., Marco Martin wrote: > > Which methods do we need the inner control for? I saw positionAtPos and > > positionToRectangle, any others? > > Marco Martin wrote: > those two and passwordCharacter > > David Edmundson wrote: > and missing properties are: > >

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

> On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: > > src/platformtheme/khintssettings.cpp, line 259 > > > > > > This means we'll end up with a KCM to change icons that does nothing. > > That sounds bad? > >

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

> On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: > > src/platformtheme/khintssettings.cpp, line 259 > > > > > > This means we'll end up with a KCM to change icons that does nothing. > > That sounds bad? > >

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/#review63781 --- src/platformtheme/khintssettings.cpp

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. > > Sune Vuorela wr

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. agreed. - Sune

Re: Review Request 119593: Ensure there's a plastform window before restoring the window geometry

> On Srp. 4, 2014, 1:13 dop., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the window geometry. > > Martin Klapetek wrote: > Same here, Qt 5.3.1. Thomas, which Qt are you using? > > Nevertheless, as your knowledge about windows stuff is much better and if > you thi

Re: Review Request 119594: fix FileDialog size restorage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63770 --- Ship it! Great, this works for me :) Now what about https://

Re: Review Request 119594: fix FileDialog size restorage

> On Aug. 4, 2014, 12:11 nachm., Martin Klapetek wrote: > > This does fix the issue here; +1 from me > > > > Also, are you investigating/reporting the bug to Qt devs? On a quick glimpse, it looks like the issue is that QWidgetWindow syncs stuff and that it syncs (only) in ::event() ie. the eve

Re: Review Request 119594: fix FileDialog size restorage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63765 --- Ship it! This does fix the issue here; +1 from me Also, are

Re: Review Request 119594: fix FileDialog size restorage

> On Aug. 3, 2014, 11:13 nachm., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. > > Thomas Lübking wrote: > what is your precise testcase? > a bit remote because of your other patches: did you check that the > correct platformtheme lib is used? (

Re: Review Request 119594: fix FileDialog size restorage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/ --- (Updated Aug. 4, 2014, 11:57 vorm.) Review request for KDE Frameworks, kd

Re: Review Request 119593: Ensure there's a plastform window before restoring the window geometry

> On Aug. 4, 2014, 1:13 a.m., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the window geometry. Same here, Qt 5.3.1. Thomas, which Qt are you using? Nevertheless, as your knowledge about windows stuff is much better and if you think this patch is needed anyway, go for it. -

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

> On Aug. 4, 2014, 1:13 a.m., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. > > Thomas Lübking wrote: > what is your precise testcase? > a bit remote because of your other patches: did you check that the > correct platformtheme lib is used? (ran

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

> On Srp. 4, 2014, 1:13 dop., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. > > Thomas Lübking wrote: > what is your precise testcase? > a bit remote because of your other patches: did you check that the > correct platformtheme lib is used? (ran

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

> On Aug. 4, 2014, 1:13 a.m., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. > > Thomas Lübking wrote: > what is your precise testcase? > a bit remote because of your other patches: did you check that the > correct platformtheme lib is used? (ran

Jenkins build is back to stable : kio_master_qt5 #316

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kio_master_qt5 #315

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119337/#review63736 --- This patch sounds wrong (at first sight) because, well, this c

Re: Web Shortcuts KCM

On Saturday 02 August 2014 12:48:43 Kevin Ottens wrote: > On Saturday 02 August 2014 11:50:17 David Faure wrote: > > Then let's go more "bare bones" in frameworks that can't afford the > > KConfigWidgets dependency, but let's provide the more convenient and more > > usable "out of the box" solution

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

> On Srp. 4, 2014, 1:13 dop., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. > > Thomas Lübking wrote: > what is your precise testcase? > a bit remote because of your other patches: did you check that the > correct platformtheme lib is used? (ran

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

> On Aug. 3, 2014, 11:13 nachm., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. what is your precise testcase? a bit remote because of your other patches: did you check that the correct platformtheme lib is used? (ran into this in a custom installation.