> On June 7, 2014, 1:10 p.m., David Faure wrote: > > Very nice. > > > > The question of "why not in Qt" hasn't been answered though :) > > Aurélien Gâteau wrote: > If you think this has a chance to get in, I can propose it. > > Aleix Pol Gonzalez wrote: > I think it would be accepted. I'm at Qt Contributor Summit anyway, if > anybody knows who to ask I can physically poke him. > > Aurélien Gâteau wrote: > I don't have the time or energy to get this into Qt, but I am still happy > to commit it here if you want. Just let me know.
Yes, commit it here for now, but keep in mind that, this being your code, it's a lot easier for you to put it into Qt than for anyone else (who would have to rewrite it from scratch, for licensing reasons). - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review59506 ----------------------------------------------------------- On June 5, 2014, 12:38 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118514/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 12:38 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > ------- > > I have been asked to add ColumnResizer to KWidgetAddons. ColumnResizer is a > helper class I created long ago to help maintain uniform widths across > layouts. You can learn more about it from the blog post I wrote back then: > http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ . I > simplified the API a bit, added some documentation, and here it is. > > > Diffs > ----- > > autotests/CMakeLists.txt 854e916 > autotests/kcolumnresizertest-forms.ui PRE-CREATION > autotests/kcolumnresizertest-grid-and-form.ui PRE-CREATION > autotests/kcolumnresizertest-grids.ui PRE-CREATION > autotests/kcolumnresizertest.h PRE-CREATION > autotests/kcolumnresizertest.cpp PRE-CREATION > docs/pics/kcolumnresizer.png PRE-CREATION > src/CMakeLists.txt 27b9084 > src/kcolumnresizer.h PRE-CREATION > src/kcolumnresizer.cpp PRE-CREATION > tests/CMakeLists.txt eccf887 > tests/kcolumnresizertest.h PRE-CREATION > tests/kcolumnresizertest.cpp PRE-CREATION > tests/kcolumnresizertest.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118514/diff/ > > > Testing > ------- > > Manual test program behaves as expected. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
