Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

> On Iulie 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: > > Is this because of the usage of list(APPEND)? Maybe using set(.. > > PARENT_SCOPE) for appending would do the trick as well? > > Andreas Xavier wrote: > Can you confirm that you are seeing the same problem? > > This i

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

> On July 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: > > Is this because of the usage of list(APPEND)? Maybe using set(.. > > PARENT_SCOPE) for appending would do the trick as well? > > Andreas Xavier wrote: > Can you confirm that you are seeing the same problem? > > This is

[kwindowsystem] src: Preventing a crash in the KWindowInfo::Private destructor on OSX

Git commit 10398255165afda1a0ecddd1671bbb599846bb35 by Marko Käning. Committed on 15/07/2014 at 22:51. Pushed by kaning into branch 'master'. Preventing a crash in the KWindowInfo::Private destructor on OSX René J.V. Bertin found that Apple's developer documentation for CFRelease mentions that it

Jenkins build is back to stable : kio_master_qt5 #299

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119242: Fix QExplicitlySharedDataPointer usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119242/ --- (Updated July 15, 2014, 10:22 p.m.) Status -- This change has been m

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/ --- (Updated July 15, 2014, 10:21 p.m.) Status -- This change has been m

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119275/ --- (Updated July 15, 2014, 9:36 p.m.) Status -- This change has been di

Re: Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

> On July 15, 2014, 6:27 p.m., Alex Merry wrote: > > modules/ECMGenerateHeaders.cmake, line 150 > > > > > > This test doesn't do what you think it does. Rather than comparing > > "${camelcase_headers_var}" with

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

> On July 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: > > Is this because of the usage of list(APPEND)? Maybe using set(.. > > PARENT_SCOPE) for appending would do the trick as well? > > Andreas Xavier wrote: > Can you confirm that you are seeing the same problem? > > This is

Re: Review Request 119257: kconfig: Fix QBasicAtomicInt being treated as int.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119257/#review62436 --- This patch fixes the build. Why did you discard it? - David G

Re: Review Request 119289: Remove api_searchbox.html.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119289/ --- (Updated July 15, 2014, 7:20 p.m.) Status -- This change has been ma

Re: Review Request 119289: Remove api_searchbox.html.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119289/#review62414 --- Ship it! Huh, guess I missed that :-) - Alex Merry On July

Re: Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119300/#review62408 --- I don't think this should be necessary. Let's keep discussion

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

> On July 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: > > Is this because of the usage of list(APPEND)? Maybe using set(.. > > PARENT_SCOPE) for appending would do the trick as well? > > Andreas Xavier wrote: > Can you confirm that you are seeing the same problem? > > This is

Re: Review Request 119289: Remove api_searchbox.html.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119289/ --- (Updated July 15, 2014, 9:21 p.m.) Review request for KDE Frameworks, Ale

Re: Review Request 119291: Use an for the search box.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119291/ --- (Updated July 15, 2014, 6:20 p.m.) Status -- This change has been ma

Re: Review Request 119291: Use an for the search box.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119291/#review62407 --- Ship it! Ship It! - Alex Merry On July 15, 2014, 8:29 a.m.

Re: KConfig build fails

Hi! 2014-07-15 17:16 GMT+02:00 Daniel Vrátil : > On Tuesday 15 of July 2014 12:09:43 David Gil Oliva wrote: > > El 15/07/2014 10:02, "David Faure" escribió: > > > On Tuesday 15 July 2014 00:51:20 David Gil Oliva wrote: > > > > Hi! > > > > > > > > 2014-07-15 0:19 GMT+02:00 Frank Reininghaus < >

Re: KConfig build fails

On Tuesday 15 of July 2014 12:09:43 David Gil Oliva wrote: > El 15/07/2014 10:02, "David Faure" escribió: > > On Tuesday 15 July 2014 00:51:20 David Gil Oliva wrote: > > > Hi! > > > > > > 2014-07-15 0:19 GMT+02:00 Frank Reininghaus : > > > > Hi, > > > > > > > > 2014-07-14 23:21 GMT+02:00 David G

Re: Web Shortcuts KCM

On 07/15/2014 03:16 PM, Kevin Ottens wrote: Well, for a single entry menu, really? :-) Yeah, I do care about every single menu entry not being broken, no matter where users use my app :). Of course admittedly the situ- ation in KDE 4 wasn't good either since it actually meant a runtime dep on

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/#review62401 --- Ship it! Ship It! - Milian Wolff On July 12, 2014, 9:41 a.

Re: Review Request 119242: Fix QExplicitlySharedDataPointer usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119242/#review62402 --- Ship it! Ship It! - Milian Wolff On July 12, 2014, 9:43 a.

Review Request 119300: extra-cmake-modules: Fix using the same variable for camelCase and REQUIRED_HEADERS causes problems.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119300/ --- Review request for KDE Frameworks, Alex Merry and Michael Pyne. Repositor

Re: Web Shortcuts KCM

On Tuesday 15 July 2014 14:59:43 Eike Hein wrote: > On 07/15/2014 10:24 AM, Kevin Ottens wrote: > > Which applications? I experience that mostly in krunner and the browsers. > > As a user I don't think I get to type those anywhere else. > > It's not just typing. Konversation, Okular and Konsole le

Re: Web Shortcuts KCM

On 07/15/2014 10:24 AM, Kevin Ottens wrote: Which applications? I experience that mostly in krunner and the browsers. As a user I don't think I get to type those anywhere else. It's not just typing. Konversation, Okular and Konsole let you select text, right-click it and search it using one o

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

> On July 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: > > Is this because of the usage of list(APPEND)? Maybe using set(.. > > PARENT_SCOPE) for appending would do the trick as well? > > Andreas Xavier wrote: > Can you confirm that you are seeing the same problem? > > This is

Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

> On July 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: > > Is this because of the usage of list(APPEND)? Maybe using set(.. > > PARENT_SCOPE) for appending would do the trick as well? Can you confirm that you are seeing the same problem? This is my first time trying to compile KF5 and the

Re: KConfig build fails

El 15/07/2014 10:02, "David Faure" escribió: > > On Tuesday 15 July 2014 00:51:20 David Gil Oliva wrote: > > Hi! > > > > 2014-07-15 0:19 GMT+02:00 Frank Reininghaus : > > > Hi, > > > > > > 2014-07-14 23:21 GMT+02:00 David Gil Oliva: > > > > Hi! > > > > > > > > KConfig build fails with this message

Re: Review Request 119274: Use Atlas textures in SvgItem

> On July 14, 2014, 11:01 p.m., Aleix Pol Gonzalez wrote: > > Can we get some advertisement about why Atlas is better? > > > > /me wants numbers. Faster? Less memory consumption? > > Martin Gräßlin wrote: > it means we have one texture instead of many and that reduces state > changes which

Review Request 119291: Use an for the search box.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119291/ --- Review request for KDE Frameworks, Alex Merry and Aurélien Gâteau. Reposi

Review Request 119289: Remove api_searchbox.html.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119289/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Re: Web Shortcuts KCM

Hello, On Tuesday 15 July 2014 10:01:50 David Faure wrote: > On Tuesday 15 July 2014 08:15:46 Kevin Ottens wrote: > > Honestly to me it looks like a wrong move. A better move would be to have > > the framework (e.g. KIO) read the settings from the platform for its > > settings (e.g. proxies). >

Re: Review Request 119284: Semantically correct uiReady

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119284/ --- (Updated July 15, 2014, 8:19 a.m.) Status -- This change has been ma

Re: KConfig build fails

On Tuesday 15 July 2014 00:51:20 David Gil Oliva wrote: > Hi! > > 2014-07-15 0:19 GMT+02:00 Frank Reininghaus : > > Hi, > > > > 2014-07-14 23:21 GMT+02:00 David Gil Oliva: > > > Hi! > > > > > > KConfig build fails with this messages, all of them related to > > > QBasicAtomicInt. Are they KF5 bug

Re: Web Shortcuts KCM

On Tuesday 15 July 2014 08:15:46 Kevin Ottens wrote: > Honestly to me it looks like a wrong move. A better move would be to have > the framework (e.g. KIO) read the settings from the platform for its > settings (e.g. proxies). OK about proxies, but web shortcuts is a KIO-specific thing, you won't