Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

2014-06-16 Thread Martin Gräßlin
> On June 16, 2014, 9:10 p.m., Martin Gräßlin wrote: > > I would like to get the opinion from people who designed kglobalaccel. > > Personally I do not understand what the default shortcuts are for and why > > they are needed. > > > > From reading the documentation my understanding is that you

Re: KCoreAddons does not install most of its headers on my system

2014-06-16 Thread Michael Pyne
On Mon, June 16, 2014 13:14:47 Kevin Ottens wrote: > On Monday 16 June 2014 12:58:30 Àlex Fiestas wrote: > > I encountered this yesterday, for a quick workaround rollback to cmake 3.0 > > (cmake-git is what makes this happen) > > In fact, maybe a sign that our kdesrc-build config file should reque

Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

2014-06-16 Thread Vishesh Handa
> On June 16, 2014, 7:10 p.m., Martin Gräßlin wrote: > > I would like to get the opinion from people who designed kglobalaccel. > > Personally I do not understand what the default shortcuts are for and why > > they are needed. > > > > From reading the documentation my understanding is that you

Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

2014-06-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118783/#review60209 --- I would like to get the opinion from people who designed kglob

Review Request 118783: Set the normal shortcut when setting the default shortcut as well

2014-06-16 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118783/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobal

Review Request 118780: Disable the xcb flush connection workaround for Qt >= 5.3.1

2014-06-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118780/ --- Review request for KDE Frameworks and Àlex Fiestas. Repository: framework

Re: Review Request 118667: KCrash: call setgroups(0, 0) before calling setgid()

2014-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118667/#review60190 --- This review has been submitted with commit 8ea58f982469bf1090

Re: Review Request 118667: KCrash: call setgroups(0, 0) before calling setgid()

2014-06-16 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118667/ --- (Updated June 16, 2014, 12:37 p.m.) Status -- This change has been m

Re: KCoreAddons does not install most of its headers on my system

2014-06-16 Thread Kevin Ottens
On Monday 16 June 2014 12:58:30 Àlex Fiestas wrote: > On Mon, Jun 16, 2014 at 9:41 AM, Frank Reininghaus > wrote: > > > > Hello everyone, > > > > I tried to set up a separate Qt5+KF5 build in release mode. > > Unfortunately, I did not succeed :-( > > > > The first package that fails to build (e

Re: KCoreAddons does not install most of its headers on my system

2014-06-16 Thread Àlex Fiestas
On Mon, Jun 16, 2014 at 9:41 AM, Frank Reininghaus wrote: > Hello everyone, > > I tried to set up a separate Qt5+KF5 build in release mode. > Unfortunately, I did not succeed :-( > > The first package that fails to build (even if I repeat the > kdesrc-build process many times) is kservice. The co

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

2014-06-16 Thread Frank Reininghaus
> On June 16, 2014, 10:14 a.m., Milian Wolff wrote: > > Pretty ugly, but I'd say this is a good first take as we'd then have it > > movable (the public ABI change) and could then try to improve the private > > code around the NonMovable... stuff later on. > > > > I find it rather strange that

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

2014-06-16 Thread Frank Reininghaus
> On June 16, 2014, 10:09 a.m., Emmanuel Pescosta wrote: > > src/core/kcoredirlister_p.h, lines 40-42 > > > > > > "using KFileItem::KFileItem;" maybe? Maybe - I'm always a bit unsure which C++11 features are allo

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

2014-06-16 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/#review60180 --- Pretty ugly, but I'd say this is a good first take as we'd the

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

2014-06-16 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/#review60179 --- src/core/kcoredirlister_p.h

Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

2014-06-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/ --- (Updated June 16, 2014, 9:49 a.m.) Status -- This change has been ma

Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

2014-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/#review60176 --- This review has been submitted with commit 651901da4d5a600aa0

Re: Review Request 118253: Port KWindowSystem::raiseWindow and ::lowerWindow to XCB

2014-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118253/#review60177 --- This review has been submitted with commit cd509f6fb0491c30e5

Re: Review Request 118253: Port KWindowSystem::raiseWindow and ::lowerWindow to XCB

2014-06-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118253/ --- (Updated June 16, 2014, 9:49 a.m.) Status -- This change has been ma

Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

2014-06-16 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/#review60175 --- Ship it! Ship It! - Kevin Ottens On May 26, 2014, 7:09 a.m

KF5 Update Meeting 2014-w25 Reminder

2014-06-16 Thread Kevin Ottens
Hello all, After a three week hiatus because of me going on vacations and not managing properly to have someone impersonate me... a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.n

Re: Review Request 118692: Fix reading of entries for language/country combinations

2014-06-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/ --- (Updated June 16, 2014, 10:26 a.m.) Review request for KDE Frameworks, Da

Review Request 118775: Make KFileItem a Q_MOVABLE type

2014-06-16 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

KCoreAddons does not install most of its headers on my system

2014-06-16 Thread Frank Reininghaus
Hello everyone, I tried to set up a separate Qt5+KF5 build in release mode. Unfortunately, I did not succeed :-( The first package that fails to build (even if I repeat the kdesrc-build process many times) is kservice. The comiler reports [ 30%] Building CXX object src/CMakeFiles/KF5Service.dir/