----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118783/#review60209 -----------------------------------------------------------
I would like to get the opinion from people who designed kglobalaccel. Personally I do not understand what the default shortcuts are for and why they are needed. >From reading the documentation my understanding is that your patch is wrong >and instead the applications need to be fixed (it's just the default as what >one can click in the config interface, but not the loaded global shortcut). - Martin Gräßlin On June 16, 2014, 6:49 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118783/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 6:49 p.m.) > > > Review request for KDE Frameworks and Martin Gräßlin. > > > Repository: kglobalaccel > > > Description > ------- > > When a client calls setDefaultShortcut, only the default shortcut is > set. This makes sense, however kglobalaccel doesn't actually do anything > with the global shortcut, it just writes it to the configuration and > reads it back. > > All the actual logic is implemented behind "active" or "normal" shortcuts. > In kdelibs4, most applications would call KAction::setGlobalShorcut which > had a default of setting BOTH the active and the default shortcut. Again, > I'm not sure what they point of this was if the default shortcut does not > actually do anything. > > This fixes bugs such as the brightness key not working because > Powerdevil only sets the "default" shortcut. > > > Diffs > ----- > > src/kglobalaccel.cpp 54d18ec > > Diff: https://git.reviewboard.kde.org/r/118783/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
