Review Request 117495: Fix doc of KWindowInfo::clientMachine()

2014-04-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117495/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 117491: Rework FindX11_XCB.cmake

2014-04-10 Thread Martin Gräßlin
> On April 11, 2014, 7:32 a.m., Martin Gräßlin wrote: > > I'm wondering whether it's still needed in kwindowsystem at all. So the > > test might not be telling much. my task to remove the dependency from kwindowsystem failed: it's already no longer used. I'm just wondering where we have code

Re: Review Request 117490: Improve FindEGL.cmake

2014-04-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117490/#review55426 --- oh do I get this right? I can now do a find for EGL version 1.

Re: Review Request 117491: Rework FindX11_XCB.cmake

2014-04-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review55425 --- I'm wondering whether it's still needed in kwindowsystem at al

Re: workspace/khelpcenter which branch is "frameworks", branch master or frameworks?

2014-04-10 Thread Michael Pyne
On Fri, April 11, 2014 00:33:07 Aleix Pol wrote: > You can see the used branches in this file, between brackets (see Qt5): > http://quickgit.kde.org/?p=kde-build-metadata.git Well, that gives the dependencies but not always the branches. To see which branch is considered the "frameworks" branch

Re: Review Request 117486: Rewrite kiosk documentation

2014-04-10 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117486/#review55422 --- Ship it! Ship It! - Matthew Dawson On April 10, 2014, 12:2

Re: Review Request 117132: Use QLocale for figuring out what languages we're translated into

2014-04-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117132/#review55419 --- This review has been submitted with commit 44cbe33fb8c9bf3ebf

Re: Review Request 117132: Use QLocale for figuring out what languages we're translated into

2014-04-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117132/ --- (Updated April 10, 2014, 10:36 p.m.) Status -- This change has been

Re: workspace/khelpcenter which branch is "frameworks", branch master or frameworks?

2014-04-10 Thread Aleix Pol
On Thu, Apr 10, 2014 at 10:01 PM, Burkhard Lück wrote: > Hi, > > I am really confused about the branches which are really "frameworks". > > E.g workspace/khelpcenter has branches "master" and "frameworks". > But Aleix imported the khelpcenter docbooks to branch 'master', not into > branch 'framew

Re: Review Request 117132: Use QLocale for figuring out what languages we're translated into

2014-04-10 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117132/#review55418 --- Ship it! Ship It! - Chusslove Illich On April 9, 2014, 6 p

Re: Postfixing .po that come from Qt::tr() with a _qt.po

2014-04-10 Thread Chusslove Illich
> [: Albert Astals Cid :] > Hi, do you think it makes sense to use that postfix? > > We are using this currently for stuff like marble and trojita so our > translators know they can't use advanced stuff like JS scripting for the > translations. For this particular reason, the better solution is to

Postfixing .po that come from Qt::tr() with a _qt.po

2014-04-10 Thread Albert Astals Cid
Hi, do you think it makes sense to use that postfix? We are using this currently for stuff like marble and trojita so our translators know they can't use advanced stuff like JS scripting for the translations. What do you think? Cheers, Albert ___ K

Re: How do we want to ship framework translations

2014-04-10 Thread Albert Astals Cid
El Dijous, 10 d'abril de 2014, a les 20:57:20, Alexander Potashev va escriure: > 2014-04-10 20:31 GMT+04:00 Alex Merry : > > I thought the consensus was to change it so that they were distributed > > on a framework-by-framework basis. > > Hello Alex, > > The words "framework-by-framework basis" m

Re: How do we want to ship framework translations

2014-04-10 Thread Albert Astals Cid
El Dijous, 10 d'abril de 2014, a les 09:06:40, Aurélien Gâteau va escriure: > Hi, > > Until now, kdelibs translations have always been released as part of the > kde-l10n-$lang tarballs. I was wondering whether it should still be the > case with frameworks, or if each frameworks should instead ship

Re: How do we want to ship framework translations

2014-04-10 Thread Albert Astals Cid
El Dijous, 10 d'abril de 2014, a les 21:10:36, Burkhard Lück va escriure: > Am Donnerstag, 10. April 2014, 09:06:40 schrieb Aurélien Gâteau: > > Hi, > > > > Until now, kdelibs translations have always been released as part of the > > kde-l10n-$lang tarballs. I was wondering whether it should still

Re: How do we want to ship framework translations

2014-04-10 Thread Alexander Potashev
2014-04-10 20:31 GMT+04:00 Alex Merry : > I thought the consensus was to change it so that they were distributed > on a framework-by-framework basis. Hello Alex, The words "framework-by-framework basis" may be understood in three different ways: 1. Translations to all languages are shipped in a

Re: How do we want to ship framework translations

2014-04-10 Thread Chusslove Illich
> [: Burkhard Lück :] > For my daily work (proofreading translations of de, check i18n errors from > devels via x-test, check translation bugs reported on b.k.o) I build + > install the complete translations (gui + docs) of several languages each > day via l10n- kde4/scripts/autogen.sh, so need tha

workspace/khelpcenter which branch is "frameworks", branch master or frameworks?

2014-04-10 Thread Burkhard Lück
Hi, I am really confused about the branches which are really "frameworks". E.g workspace/khelpcenter has branches "master" and "frameworks". But Aleix imported the khelpcenter docbooks to branch 'master', not into branch 'frameworks'. So what is the correct branch for the "frameworks" in worksp

Re: How do we want to ship framework translations

2014-04-10 Thread Burkhard Lück
Am Donnerstag, 10. April 2014, 09:06:40 schrieb Aurélien Gâteau: > Hi, > > Until now, kdelibs translations have always been released as part of the > kde-l10n-$lang tarballs. I was wondering whether it should still be the > case with frameworks, or if each frameworks should instead ship with its >

Review Request 117490: Improve FindEGL.cmake

2014-04-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117490/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Review Request 117491: Rework FindX11_XCB.cmake

2014-04-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

"KDE4 references" task status

2014-04-10 Thread Alex Merry
Update on the "KDE4 references" task[0]: This is mostly done. There are some review requests still open, some things for translators to do in kdoctools, a couple of things I've asked David to look at and src/kwrapper/kwrapper_win.cpp in kinit, which needs a Windows person to look at it. Basicall

Re: kdeinit5 binary and man page in different repos

2014-04-10 Thread Alex Merry
On 09/04/14 19:08, Michael Palimaka wrote: > Hi, > > I noticed that kdeinit5 is in kinit, and its man page appears to be in > kservice. I guess the man page should be moved, but I'm not sure of the > best procedure with regards to preserving history etc. I've done this now. Alex ___

Re: Kioslave repos

2014-04-10 Thread Àlex Fiestas
On Thursday 10 April 2014 14:42:37 Marco Martin wrote: > On Thursday 10 April 2014, you wrote: > > in the second case, it's just a release blocker, and has to be enabled and > > ported, *even if* there won't be anyone maintaining it after that, it's a > > part of the workspace and needs to be relea

Re: Kioslave repos

2014-04-10 Thread Àlex Fiestas
On Thursday 10 April 2014 13:43:37 Marco Martin wrote: > On Thursday 10 April 2014, Àlex Fiestas wrote: > > > Developers being confortable with it, or even (gasp!) being actively > > > maintained goes completely secondary behind the causing as less > > > regressions as possible for the users. > >

Review Request 117489: Remove the old tutorial

2014-04-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117489/ --- Review request for KDE Frameworks. Repository: knewstuff Description --

Re: How do we want to ship framework translations

2014-04-10 Thread Alex Merry
On 10/04/14 17:06, Aurélien Gâteau wrote: > Hi, > > Until now, kdelibs translations have always been released as part of the > kde-l10n-$lang tarballs. I was wondering whether it should still be the > case with frameworks, or if each frameworks should instead ship with its > own translations. The

Review Request 117485: Add note about Kiosk to docs

2014-04-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117485/ --- Review request for KDE Frameworks. Repository: kbookmarks Description -

Review Request 117488: Improve Kiosk documentation

2014-04-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117488/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 117486: Rewrite kiosk documentation

2014-04-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117486/ --- Review request for KDE Frameworks. Repository: kconfig Description

Review Request 117487: Add Kiosk documentation

2014-04-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117487/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

How do we want to ship framework translations

2014-04-10 Thread Aurélien Gâteau
Hi, Until now, kdelibs translations have always been released as part of the kde-l10n-$lang tarballs. I was wondering whether it should still be the case with frameworks, or if each frameworks should instead ship with its own translations. The work I have been been doing assumed the later because

Re: kcoreaddons: is src/mimetypes/kde.xml still in use?

2014-04-10 Thread Burkhard Lück
Am Donnerstag, 10. April 2014, 08:28:51 schrieb Aurélien Gâteau: > On Thu, Apr 10, 2014, at 6:36, Burkhard Lück wrote: > > Am Donnerstag, 10. April 2014, 00:25:21 schrieb Aurélien Gâteau: > > > On Wed, Apr 9, 2014, at 9:57, Burkhard Lück wrote: > > > > Am Mittwoch, 9. April 2014, 06:59:08 schrieb A

Re: kcoreaddons: is src/mimetypes/kde.xml still in use?

2014-04-10 Thread Aurélien Gâteau
On Thu, Apr 10, 2014, at 6:36, Burkhard Lück wrote: > Am Donnerstag, 10. April 2014, 00:25:21 schrieb Aurélien Gâteau: > > On Wed, Apr 9, 2014, at 9:57, Burkhard Lück wrote: > > > Am Mittwoch, 9. April 2014, 06:59:08 schrieb Aurélien Gâteau: > > > > Hi, > > > > > > > > I am trying to figure out wh

[kdelibs4support] /: Add a compatibility CMake config file

2014-04-10 Thread Alex Merry
Git commit 7f707a8c28b92b1ad79b31dc74f0978255eaee9a by Alex Merry. Committed on 09/04/2014 at 21:55. Pushed by alexmerry into branch 'master'. Add a compatibility CMake config file This allows projects to continue using find_package(KF5KDE4Suport) and KF5::KDE4Support in CMake files, keeping sour

Re: Review Request 117078: Allow compiling kio on windows

2014-04-10 Thread Alexander Richardson
> On March 28, 2014, 4:19 p.m., David Faure wrote: > > src/core/kioglobal_p_win.cpp, line 27 > > > > > > Bonus points for contributing a static method to QProcess... > > Alexander Richardson wrote: > Makes se

Re: Review Request 117078: Allow compiling kio on windows

2014-04-10 Thread David Faure
> On March 28, 2014, 3:19 p.m., David Faure wrote: > > src/core/kioglobal_p_win.cpp, line 27 > > > > > > Bonus points for contributing a static method to QProcess... > > Alexander Richardson wrote: > Makes se

Re: kcoreaddons: is src/mimetypes/kde.xml still in use?

2014-04-10 Thread Burkhard Lück
Am Donnerstag, 10. April 2014, 00:25:21 schrieb Aurélien Gâteau: > On Wed, Apr 9, 2014, at 9:57, Burkhard Lück wrote: > > Am Mittwoch, 9. April 2014, 06:59:08 schrieb Aurélien Gâteau: > > > Hi, > > > > > > I am trying to figure out which code is responsible for loading > > > xml_mimetypes.po. This

Re: Review Request 117078: Allow compiling kio on windows

2014-04-10 Thread Alexander Richardson
> On March 28, 2014, 4:19 p.m., David Faure wrote: > > src/core/kioglobal_p.h, line 93 > > > > > > How is this different from QFileInfo::symLinkTarget()? Why not just > > port to that? >From a quick look through

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-04-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/#review55374 --- This review has been submitted with commit 801544210718d01ef5

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-04-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/ --- (Updated April 10, 2014, 1:14 p.m.) Status -- This change has been m

Re: Kioslave repos

2014-04-10 Thread Marco Martin
On Thursday 10 April 2014, you wrote: > in the second case, it's just a release blocker, and has to be enabled and > ported, *even if* there won't be anyone maintaining it after that, it's a > part of the workspace and needs to be released, (and yes, preferably in > the plasma- workspace repo) if i

Review Request 117475: kmimeassociationstest: remove kde4- prefix from desktop file names

2014-04-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 117333: Remove Solid::Networking usage from KIO

2014-04-10 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117333/ --- (Updated April 10, 2014, 12:08 p.m.) Review request for KDE Frameworks.

Re: Review Request 117333: Remove Solid::Networking usage from KIO

2014-04-10 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117333/ --- (Updated April 10, 2014, 12:08 p.m.) Review request for KDE Frameworks.

Re: Kioslave repos

2014-04-10 Thread Marco Martin
On Thursday 10 April 2014, Àlex Fiestas wrote: > > Developers being confortable with it, or even (gasp!) being actively > > maintained goes completely secondary behind the causing as less > > regressions as possible for the users. > > I guess you can leave the code there and just not add it to cma

Re: Kioslave repos

2014-04-10 Thread Kevin Ottens
On Thursday 10 April 2014 10:40:04 Àlex Fiestas wrote: > On Wednesday 09 April 2014 11:57:37 Marco Martin wrote: > > On Wednesday 09 April 2014, Àlex Fiestas wrote: > > > I'm against having anything in plasma-* without maintainer and even less > > > if > > > it is something that is known to have bu

Re: Figuring out kde-runtime: localization

2014-04-10 Thread Aleix Pol
On Sun, Feb 23, 2014 at 4:59 PM, Albert Astals Cid wrote: > El Divendres, 21 de febrer de 2014, a les 13:17:58, Aleix Pol va escriure: > > Hi, > > Going through the information we have in kde-runtime [1] we found there > are > > two subdirectories related to localization (localization and l10n) t

Re: Review Request 117333: Remove Solid::Networking usage from KIO

2014-04-10 Thread Àlex Fiestas
> On April 7, 2014, 3:37 p.m., Kevin Ottens wrote: > > src/ioslaves/http/http.cpp, line 1900 > > > > > > What about doing it? :-) > > Àlex Fiestas wrote: > I can do that but in another review if that is ok,

Re: KDE(Libs)4Support rename

2014-04-10 Thread Alex Merry
On 10/04/14 06:21, Kevin Ottens wrote: >> Are there any objections to me pushing this (along with relevant changes >> - mostly to CMake code and comments - in other repos, of course)? > > Good to go from my side. The earlier the better for that one. I've got some compatbility CMake code written.

Re: Re: Writing a Frameworks book at Randa

2014-04-10 Thread Martin Gräßlin
On Thursday 10 April 2014 01:42:13 Valorie Zimmerman wrote: > On Thu, Apr 10, 2014 at 1:26 AM, Aurélien Gâteau wrote: > > On Wed, Apr 9, 2014, at 6:05, Kevin Funk wrote: > >> On Wednesday 09 April 2014 02:25:18 Valorie Zimmerman wrote: > >> > Hello folks, I know that August is months away, but if

Re: Kioslave repos

2014-04-10 Thread Àlex Fiestas
On Wednesday 09 April 2014 11:57:37 Marco Martin wrote: > On Wednesday 09 April 2014, Àlex Fiestas wrote: > > I'm against having anything in plasma-* without maintainer and even less > > if > > it is something that is known to have bugs (many) in KDE4. > > > > So we wither split it and hope somebo

Re: Writing a Frameworks book at Randa

2014-04-10 Thread Valorie Zimmerman
On Thu, Apr 10, 2014 at 1:26 AM, Aurélien Gâteau wrote: > On Wed, Apr 9, 2014, at 6:05, Kevin Funk wrote: >> On Wednesday 09 April 2014 02:25:18 Valorie Zimmerman wrote: >> > Hello folks, I know that August is months away, but if you want your >> > Frameworks book, now is the time to step forward.

Re: Writing a Frameworks book at Randa

2014-04-10 Thread Aurélien Gâteau
On Wed, Apr 9, 2014, at 6:05, Kevin Funk wrote: > On Wednesday 09 April 2014 02:25:18 Valorie Zimmerman wrote: > > Hello folks, I know that August is months away, but if you want your > > Frameworks book, now is the time to step forward. > > > > Here are some things to think about: > > > > Most o

Re: kcoreaddons: is src/mimetypes/kde.xml still in use?

2014-04-10 Thread Aurélien Gâteau
On Wed, Apr 9, 2014, at 9:57, Burkhard Lück wrote: > Am Mittwoch, 9. April 2014, 06:59:08 schrieb Aurélien Gâteau: > > Hi, > > > > I am trying to figure out which code is responsible for loading > > xml_mimetypes.po. This file is produced by scripty when running on > > kcoreaddons, but I can't fin

Re: kcoreaddons: is src/mimetypes/kde.xml still in use?

2014-04-10 Thread Aurélien Gâteau
On Wed, Apr 9, 2014, at 9:57, Burkhard Lück wrote: > Am Mittwoch, 9. April 2014, 06:59:08 schrieb Aurélien Gâteau: > > Hi, > > > > I am trying to figure out which code is responsible for loading > > xml_mimetypes.po. This file is produced by scripty when running on > > kcoreaddons, but I can't fin