Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-22 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/#review53773 --- I can't test this because the kservice framework (dep of kinit

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-22 Thread Michael Hansen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 8:54 p.m.) Status -- This change has been m

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53772 --- This review has been submitted with commit b0b7e84f75f9b9edfb

Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/ --- Review request for KDE Frameworks and Alexander Richardson. Repository: k

Review Request 116982: Remove KDE 4 refs in khtml

2014-03-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116982/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Jenkins build is back to stable : ktexteditor_master_qt5 #296

2014-03-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116979: Rename the bootstrap CMake variable

2014-03-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116979/ --- (Updated March 22, 2014, 6:13 p.m.) Status -- This change has been m

Re: Review Request 116979: Rename the bootstrap CMake variable

2014-03-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116979/#review53771 --- This review has been submitted with commit 310adc4c3add4a08df

Review Request 116981: Use new terminology in webkit docs.

2014-03-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116981/ --- Review request for KDE Frameworks. Repository: kdewebkit Description --

Re: Review Request 116980: Update the kded5 man page

2014-03-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 22, 2014, 5:53 p.m.) Review request for Documentation and

Review Request 116980: Update the kded5 man page

2014-03-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- Review request for KDE Frameworks. Repository: kded Description ---

Jenkins build became unstable: ktexteditor_master_qt5 #295

2014-03-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53770 --- Ship it! Ship It! - Alex Merry On March 22, 2014, 5:13 p.m

Re: Review Request 116979: Rename the bootstrap CMake variable

2014-03-22 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116979/#review53769 --- Ship it! Well, nothing to say, thanks! - Luigi Toscano On

Review Request 116979: Rename the bootstrap CMake variable

2014-03-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116979/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-22 Thread Michael Hansen
> On March 22, 2014, 6:29 a.m., Alex Merry wrote: > > src/kguiaddons_config.h.cmake, lines 20-21 > > > > > > This was also copied out of another file, right? Nope, but it was put in before I changed my mind about

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-22 Thread Michael Hansen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/ --- (Updated March 22, 2014, 10:13 a.m.) Review request for KDE Frameworks.

Re: Unknown media types

2014-03-22 Thread Michael Palimaka
On 03/16/2014 09:46 PM, David Faure wrote: > On Saturday 15 March 2014 19:24:08 Michael Palimaka wrote: >> Hi, >> >> kcoreaddons installs /usr/share/mime/packages/kde5.xml which causes the >> following warnings when update-mime-database is executed: >> >> Unknown media type in type 'all/all' >> Unk

Re: regression in kinit framework?

2014-03-22 Thread Alex Merry
On 22/03/14 13:30, Alex Merry wrote: > On 22/03/14 12:59, Giorgos Tsiapaliokas wrote: >> Hello, >> >> in my machine from a fresh install(clean build and install directories) >> filedialogs fail to find kio_file,(I have attached an image of the error). >> >> I reseted the kinit framework to ef1375f

Re: Review Request 116935: Lookup paths for kioslaves in KLauncher

2014-03-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116935/ --- (Updated March 22, 2014, 2:58 p.m.) Status -- This change has been m

Re: Review Request 116935: Lookup paths for kioslaves in KLauncher

2014-03-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116935/#review53760 --- This review has been submitted with commit a556c328ad4cf79a5b

Re: Review Request 116935: Lookup paths for kioslaves in KLauncher

2014-03-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116935/#review53759 --- This review has been submitted with commit 85d4a3321f3f932cdd

Re: Review Request 116961: Replace fake MIME type

2014-03-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116961/#review53758 --- This review has been submitted with commit a0ff33dbcb7e2feeb3

Re: Review Request 116961: Replace fake MIME type

2014-03-22 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116961/ --- (Updated March 22, 2014, 2:48 p.m.) Status -- This change has been m

Re: Review Request 116037: change entities to reflect new branding

2014-03-22 Thread Luigi Toscano
> On March 4, 2014, 9:48 p.m., Kevin Ottens wrote: > > Ship It! > > Kevin Ottens wrote: > Any news? Anything blocking this patch from being committed? > > T.C. Hollingsworth wrote: > Well I still need to fix the i18n issues and change up the entities a > little bit to reflect the feedb

Re: Review Request 116935: Lookup paths for kioslaves in KLauncher

2014-03-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116935/#review53756 --- Ship it! Thanks for the fix. src/klauncher/klauncher.cpp

Re: regression in kinit framework?

2014-03-22 Thread Alex Merry
On 22/03/14 12:59, Giorgos Tsiapaliokas wrote: > Hello, > > in my machine from a fresh install(clean build and install directories) > filedialogs fail to find kio_file,(I have attached an image of the error). > > I reseted the kinit framework to ef1375f25f7b3f3fba25e1e9374d6c4c0e093c50 > and eve

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53754 --- src/kguiaddons_config.h.cmake

Re: Review Request 116935: Lookup paths for kioslaves in KLauncher

2014-03-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116935/ --- (Updated March 22, 2014, 1:27 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 116927: Fix kdeinit module lookup

2014-03-22 Thread Alex Merry
> On March 21, 2014, 4:10 p.m., Hrvoje Senjan wrote: > > this seems to broke kded modules loading here: > > Cannot load library /usr/lib64/libkdeinit5_kio_file: > > (/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No > > such file or directory) > > Hrvoje Senjan wrote: >

Re: Review Request 116927: Fix kdeinit module lookup

2014-03-22 Thread Alex Merry
> On March 21, 2014, 4:10 p.m., Hrvoje Senjan wrote: > > this seems to broke kded modules loading here: > > Cannot load library /usr/lib64/libkdeinit5_kio_file: > > (/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No > > such file or directory) > > Hrvoje Senjan wrote: >

Re: Review Request 116927: Fix kdeinit module lookup

2014-03-22 Thread Alex Merry
> On March 21, 2014, 4:10 p.m., Hrvoje Senjan wrote: > > this seems to broke kded modules loading here: > > Cannot load library /usr/lib64/libkdeinit5_kio_file: > > (/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No > > such file or directory) > > Hrvoje Senjan wrote: >

Re: Review Request 116961: Replace fake MIME type

2014-03-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116961/#review53746 --- Ship it! Yeah the other hits are just string comparisons for