----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116935/ -----------------------------------------------------------
(Updated March 22, 2014, 1:27 p.m.) Review request for KDE Frameworks, David Faure and Hrvoje Senjan. Changes ------- Extend to fix the issue raised in https://git.reviewboard.kde.org/r/116927/ Summary (updated) ----------------- Lookup paths for kioslaves in KLauncher Repository: kinit Description (updated) ------- Lookup paths for kioslaves in KLauncher If you pass kdeinit anything other than an absolute path, it assumes it is a normal kdeinit executable - ie, it is an executable <name> in $PATH, optionally with a libkdeinit5_<name> in a library path. kioslaves are actually installed as plugins, though, so we do the lookup in klauncher's requestSlave() function and pass an absolute path to kdeinit. Fix up kioslave debug and valgrind modes valgrind mode with kdeinit still requires the slave module as an argument, and debug mode cannot work without kdeinit. Diffs (updated) ----- src/klauncher/klauncher.cpp a8630854af4bd3094b9688c3f9a40d10516d2056 Diff: https://git.reviewboard.kde.org/r/116935/diff/ Testing (updated) ------- Built, installed. Killed all existing kdeinit5/klauncher/etc instances. Ran kdeinit5 on one terminal. Ran kioslavetest from kio/tests on another terminal. Used it to list /tmp. kioslavetest's terminal printed the contents of /tmp, and kdeinit5's terminal printed kdeinit5: Got EXEC_NEW '/home/kf5-devel/kf5/lib64/plugins/kf5/kio_file.so' from launcher. kdeinit5: preparing to launch '/home/kf5-devel/kf5/lib64/plugins/kf5/kio_file.so' kio_file.so(23605)/(default) [31mQStandardPaths::writableLocation[0m: QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-kf5-devel' kdeinit5: PID 23605 terminated. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
