KF5 Update Meeting 2014-w6 Reminder

2014-02-02 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

Re: Review Request 115419: Split KCompletionMatches into own headers

2014-02-02 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/ --- (Updated Feb. 2, 2014, 11:14 p.m.) Review request for KDE Frameworks. C

Re: Find dependencies quietly?

2014-02-02 Thread Alex Merry
On 02/02/14 16:36, Stephen Kelly wrote: > On 02/02/2014 05:26 PM, Alex Merry wrote: >> On 02/02/14 16:10, Stephen Kelly wrote: >>> On 02/02/2014 04:54 PM, Alex Merry wrote: Either that, or have it as a completly orthogonal property that nevertheless interacts with TYPE, but I think t

Re: Find dependencies quietly?

2014-02-02 Thread Stephen Kelly
On 02/02/2014 05:26 PM, Alex Merry wrote: > On 02/02/14 16:10, Stephen Kelly wrote: >> On 02/02/2014 04:54 PM, Alex Merry wrote: >>> Either that, >>> or have it as a completly orthogonal property that nevertheless >>> interacts with TYPE, but I think that's overcomplicating matters. >> It is not cl

Re: Find dependencies quietly?

2014-02-02 Thread Alex Merry
On 02/02/14 16:10, Stephen Kelly wrote: > On 02/02/2014 04:54 PM, Alex Merry wrote: >> Either that, >> or have it as a completly orthogonal property that nevertheless >> interacts with TYPE, but I think that's overcomplicating matters. > > It is not clear to me whether you realize that that is wha

Re: Find dependencies quietly?

2014-02-02 Thread Stephen Kelly
On 02/02/2014 04:54 PM, Alex Merry wrote: > On 02/02/14 07:27, Stephen Kelly wrote: >> On 02/02/2014 12:45 AM, Alex Merry wrote: >>> The obvious thing to do is set a package property (or something >>> equivalent) that says it was found as a dependency. The danger there is >>> that if something is

Re: Review Request 115433: Fix compilation where struct addrinfo is already defined

2014-02-02 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115433/ --- (Updated Feb. 2, 2014, 4:03 p.m.) Status -- This change has been dis

Re: Find dependencies quietly?

2014-02-02 Thread Alex Merry
On 02/02/14 07:27, Stephen Kelly wrote: > On 02/02/2014 12:45 AM, Alex Merry wrote: >> The obvious thing to do is set a package property (or something >> equivalent) that says it was found as a dependency. The danger there is >> that if something is first found as a dependency and then found >> ex

Re: Review Request 115424: Improve kparts dependencies

2014-02-02 Thread David Faure
> On Feb. 2, 2014, 9:36 a.m., David Faure wrote: > > tests/CMakeLists.txt, lines 1-2 > > > > > > There's never any reason for the tests/ subdir to use Qt5Test. > > > > Qt5Test = library for autotests. > >

Re: Review Request 115426: Remove transitive dependencies

2014-02-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115426/#review48773 --- This review has been submitted with commit 8faeec84acaea57865

Re: Review Request 115426: Remove transitive dependencies

2014-02-02 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115426/ --- (Updated Feb. 2, 2014, 3:11 p.m.) Status -- This change has been mar

Re: Review Request 115424: Improve kparts dependencies

2014-02-02 Thread Michael Palimaka
> On Feb. 1, 2014, 7:45 p.m., Alex Merry wrote: > > autotests/CMakeLists.txt, line 1 > > > > > > What happens if Qt5Test is not found? Presumably, this should either > > be REQUIRED or the tests should be wrapped

Re: Review Request 115424: Improve kparts dependencies

2014-02-02 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/ --- (Updated Feb. 2, 2014, 3:09 p.m.) Review request for KDE Frameworks and D

Re: Review Request 115424: Improve kparts dependencies

2014-02-02 Thread Michael Palimaka
> On Feb. 2, 2014, 9:36 a.m., David Faure wrote: > > tests/CMakeLists.txt, lines 1-2 > > > > > > There's never any reason for the tests/ subdir to use Qt5Test. > > > > Qt5Test = library for autotests. It

Re: Review Request 115433: Fix compilation where struct addrinfo is already defined

2014-02-02 Thread Valentin Rusu
> On Feb. 2, 2014, 12:40 p.m., Alex Merry wrote: > > Have you updated extra-cmake-modules recently? I pushed a fix for this > > issue a few days ago. Specifically, the issue was _GNU_SOURCE etc being > > defined when building, but not when running configure tests. Yes, I did a full KF5 rebui

Re: Review Request 115433: Fix compilation where struct addrinfo is already defined

2014-02-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115433/#review48766 --- Have you updated extra-cmake-modules recently? I pushed a fix

Re: Review Request 114260: Port mouse dataengine

2014-02-02 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/#review48763 --- Please test it with plasmaengineexplorer in my testing it show

Review Request 115434: Deprecate KWindowSystem::windowInfo

2014-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115434/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 114260: Port mouse dataengine

2014-02-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/ --- (Updated Feb. 2, 2014, 12:26 p.m.) Review request for KDE Frameworks and

Re: Review Request 115325: Improve documentation of KWindowInfo

2014-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115325/ --- (Updated Feb. 2, 2014, 11:12 a.m.) Status -- This change has been ma

Re: Review Request 115325: Improve documentation of KWindowInfo

2014-02-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115325/#review48761 --- This review has been submitted with commit 035874a1a0bfc31db6

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/ --- (Updated Feb. 2, 2014, 11:06 a.m.) Status -- This change has been ma

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

2014-02-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115251/#review48760 --- This review has been submitted with commit 58d640cb78573b7929

Review Request 115433: Fix compilation where struct addrinfo is already defined

2014-02-02 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115433/ --- Review request for KDE Frameworks. Repository: kde4support Description

Re: Review Request 115424: Improve kparts dependencies

2014-02-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/#review48758 --- tests/CMakeLists.txt