Re: Review Request 115225: Add runtime platform support to KWindowInfo

2014-01-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- (Updated Jan. 29, 2014, 8:02 a.m.) Review request for KDE Frameworks and

Re: Review Request 115372: Improve the compiler version checks (including requiring GCC 4.5)

2014-01-28 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115372/#review48510 --- kde-modules/KDECompilerSettings.cmake

Re: Review Request 115372: Improve the compiler version checks (including requiring GCC 4.5)

2014-01-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115372/#review48508 --- kde-modules/KDECompilerSettings.cmake

Review Request 115372: Improve the compiler version checks (including requiring GCC 4.5)

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115372/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: kactivities master becomes Qt5/KF5-based

2014-01-28 Thread Ivan Čukić
> Ping, 4.13 is looming over. If you want to make it so there's no new > releases of 4.12.x anymore and master is KF5 based, please discuss now. > > Personally I'd suggest against it since seems that even if we dicussed for > that happening to kde-workspace people did not get the memo and got ang

Re: kactivities master becomes Qt5/KF5-based

2014-01-28 Thread Albert Astals Cid
El Dilluns, 21 d'octubre de 2013, a les 19:14:23, Ivan Čukić va escriure: > > Well, to be honest, if you don't want a 4.13 release i'd prefer you > > actually use master for KF5. Otherwise people might random-commit fixes > > to master and then wonder why they never got into a release, so the two >

Re: Let's get in release mode!

2014-01-28 Thread Albert Astals Cid
El Dissabte, 14 de desembre de 2013, a les 20:30:14, Kevin Ottens va escriure: > Hello everyone, > > Now we're really getting there! Epics and review board are clean, thanks to > everyone who helped to get there. Now it's the time to go for the last push. > For that I opened what will be the last

Review Request 115370: Fix apidox, fix code style and delete useless includes in KComboBox (KCompletion)

2014-01-28 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115370/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 115360: Remove the allocator and visibility check

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/ --- (Updated Jan. 28, 2014, 10:43 p.m.) Review request for Build System, Extr

Re: Review Request 115367: Add a cmake option controlling whether to build kwalletd

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115367/ --- (Updated Jan. 28, 2014, 10:40 p.m.) Status -- This change has been m

Re: Review Request 115367: Add a cmake option controlling whether to build kwalletd

2014-01-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115367/#review48502 --- This review has been submitted with commit 459ac843aaf1abab5d

Re: Review Request 115367: Add a cmake option controlling whether to build kwalletd

2014-01-28 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115367/#review48500 --- Ship it! Ship It! - Valentin Rusu On Jan. 28, 2014, 10:28

Re: Review Request 115367: Add a cmake option controlling whether to build kwalletd

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115367/ --- (Updated Jan. 28, 2014, 10:28 p.m.) Review request for KDE Frameworks and

Re: Review Request 115367: Add a cmake option controlling whether to build kwalletd

2014-01-28 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115367/#review48499 --- src/runtime/CMakeLists.txt

Review Request 115367: Add a cmake option controlling whether to build kwalletd

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115367/ --- Review request for KDE Frameworks. Repository: kwallet-framework Descri

Re: Review Request 115367: Add a cmake option controlling whether to build kwalletd

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115367/ --- (Updated Jan. 28, 2014, 8:40 p.m.) Review request for KDE Frameworks and

Re: add test for QFileDialog::getExistingDirectory / bug?

2014-01-28 Thread Gregor Mi
On 28/01/14 15:05, Kevin Funk wrote: > Am Sonntag, 26. Januar 2014, 18:53:42 schrieb Gregor Mi: >> With another addition to qfiledialogtest in >> frameworks/frameworkintegration another potential bug can be exposed: >> >> Calling >> >> $ ./qfiledialogtest --nameFilter "c (*.cpp)" --nameFilter "h

Re: Change the ML default reply-to address

2014-01-28 Thread Albert Astals Cid
El Dimarts, 28 de gener de 2014, a les 16:04:30, Nicolás Alvarez va escriure: > 2014-01-28 Martin Klapetek : > > Hey, > > > > would it be possible to change the default reply-to address for this list? > > It's quite annoying in less-advanced-than-kmail clients always pressing > > "Reply" and getti

Re: Tier status of attica & kwallet

2014-01-28 Thread Valentin Rusu
On Thursday, January 23, 2014 11:18:02 PM Michael Palimaka wrote: > On 01/23/2014 08:21 AM, Valentin Rusu wrote: > > On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: > >> > Sure, the framework itself is still tier 2...but the repo also includes > kwalletd which definitely is not t

Re: Review Request 115364: Update tier number

2014-01-28 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115364/#review48495 --- Ship it! Ship It! - Valentin Rusu On Jan. 28, 2014, 5:14 p

Re: KF5 Update Meeting Minutes 2014-w5

2014-01-28 Thread Valentin Rusu
On Tuesday, January 28, 2014 04:40:51 PM Kevin Ottens wrote: > * teo is planning to help on the kwallet and secret service front; > * he's waiting to hear back from valentin rusu; teo already contacted me, suggesting IRC meeting during working hours. Unfortunately, I won't be able to attend, a

Re: Review Request 115363: Move and comment -fno-common setting

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115363/ --- (Updated Jan. 28, 2014, 8:15 p.m.) Review request for Build System, Extra

Re: Review Request 115360: Remove the allocator and visibility check

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/ --- (Updated Jan. 28, 2014, 8:16 p.m.) Review request for Build System, Extra

Re: KF5 Update Meeting Minutes 2014-w5

2014-01-28 Thread Dominik Haumann
On Tuesday 28 January 2014 18:22:17 Martin Klapetek wrote: > On Tue, Jan 28, 2014 at 6:07 PM, Dominik Haumann wrote: > > On Tuesday, January 28, 2014 16:40:51 Kevin Ottens wrote: > > > Hello everyone, > > > > [...] > > > > > * sebas has been working on high dpi support; > > > > Where? In Plasm

Re: Where to put QML Bindings for KDE frameworks?

2014-01-28 Thread Kevin Ottens
Hello, On Tuesday 28 January 2014 12:58:01 David Edmundson wrote: > For a task in Plasma I've had to port KKeySequence to render on > QtQuick, using QtQuickControls. > > I expect over time we will see more KDE widgets having QtQuick > implementations as well. Same for a lot of our other framework

Re: Change the ML default reply-to address

2014-01-28 Thread Nicolás Alvarez
2014-01-28 Martin Klapetek : > Hey, > > would it be possible to change the default reply-to address for this list? > It's quite annoying in less-advanced-than-kmail clients always pressing > "Reply" and getting only the sender instead of the whole list. > > There's a switch for that in mailman, lot

Change the ML default reply-to address

2014-01-28 Thread Martin Klapetek
Hey, would it be possible to change the default reply-to address for this list? It's quite annoying in less-advanced-than-kmail clients always pressing "Reply" and getting only the sender instead of the whole list. There's a switch for that in mailman, lots of lists have the "reply-to" set to the

Re: KF5 Update Meeting Minutes 2014-w5

2014-01-28 Thread Martin Klapetek
On Tue, Jan 28, 2014 at 6:07 PM, Dominik Haumann wrote: > On Tuesday, January 28, 2014 16:40:51 Kevin Ottens wrote: > > Hello everyone, > > > [...] > > * sebas has been working on high dpi support; > > Where? In Plasma 2? QML stuff? Styles? Widgets? Can you elaborate? > In Plasma, it concerns o

Re: C standard

2014-01-28 Thread Andrius da Costa Ribas
MSVC (at least vc2010) is C89 for C code, changing it to C99 on GCC may lead to changes that break MSVC build (since almost everything is mostly tested on linux/gcc only). -- Andrius 2014-01-28 Alex Merry > Currently, KDECompilerSettings.cmake in ECM sets -std=iso9899:1990 for C > code (C90).

Review Request 115364: Update tier number

2014-01-28 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115364/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet-

Re: C standard

2014-01-28 Thread Alex Merry
On 28/01/14 17:19, Andrius da Costa Ribas wrote: > MSVC (at least vc2010) is C89 for C code, changing it to C99 on GCC may > lead to changes that break MSVC build (since almost everything is mostly > tested on linux/gcc only). OK, that seems like a fair reason to keep it at the C89/C90 standard. I

Re: Review Request 115362: Do not explicitly link against libc

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115362/ --- (Updated Jan. 28, 2014, 5:13 p.m.) Status -- This change has been ma

Re: Review Request 115362: Do not explicitly link against libc

2014-01-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115362/#review48492 --- This review has been submitted with commit cd1bf67b24b751e176

Re: KF5 Update Meeting Minutes 2014-w5

2014-01-28 Thread Dominik Haumann
On Tuesday, January 28, 2014 16:40:51 Kevin Ottens wrote: > Hello everyone, > [...] > * sebas has been working on high dpi support; Where? In Plasma 2? QML stuff? Styles? Widgets? Can you elaborate? Greetings, Dominik ___ Kde-frameworks-devel mailing

C standard

2014-01-28 Thread Alex Merry
Currently, KDECompilerSettings.cmake in ECM sets -std=iso9899:1990 for C code (C90). Question: do we want to change this to -std=c99? Bear in mind that our minimum GCC version (4.2) does not completely support this standard. In particular, the semantics for inline functions don't match C99's unt

Re: Review Request 115362: Do not explicitly link against libc

2014-01-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115362/#review48490 --- Ship it! I tried it here, doesn't seem to break. Also it's re

Review Request 115362: Do not explicitly link against libc

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115362/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 115360: Remove the allocator and visibility check

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/ --- (Updated Jan. 28, 2014, 4:41 p.m.) Review request for Build System, Extra

Review Request 115363: Move and comment -fno-common setting

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115363/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 115361: use renamed kmailservice5

2014-01-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115361/#review48489 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 28, 2014, 4

Re: Review Request 115362: Do not explicitly link against libc

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115362/ --- (Updated Jan. 28, 2014, 4:41 p.m.) Review request for Build System, Extra

Review Request 115361: use renamed kmailservice5

2014-01-28 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115361/ --- Review request for KDE Frameworks and Hrvoje Senjan. Repository: kservice

Re: Review Request 115359: rename dbus interface files and .desktop files in kio

2014-01-28 Thread Jonathan Riddell
> On Jan. 28, 2014, 4:16 p.m., Hrvoje Senjan wrote: > > src/ioslaves/mailto/CMakeLists.txt, line 10 > > > > > > Is renaming desktop file(s) really needed? If so, iirc one of tests in > > KService shall need adjus

Re: Review Request 115359: rename dbus interface files and .desktop files in kio

2014-01-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115359/#review48486 --- src/ioslaves/mailto/CMakeLists.txt

Review Request 115360: Remove the allocator and visibility check

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Review Request 115359: rename dbus interface files and .desktop files in kio

2014-01-28 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115359/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 115332: Add a --quiet option

2014-01-28 Thread Alex Merry
> On Jan. 27, 2014, 5:37 p.m., Aurélien Gâteau wrote: > > Looks good, but I would suggest using Python logging module instead of > > writing our own. Basic usage should be as simple as: > > > > # setup > > import logging > > > > ... parse args... > > > > if args.quiet: > > minlevel = logg

Re: Review Request 115332: Add a --quiet option

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115332/ --- (Updated Jan. 28, 2014, 3:51 p.m.) Status -- This change has been di

Review Request 115358: Remove the --logfile-dir option, and instead always create a logfile

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115358/ --- Review request for KDE Frameworks, Aurélien Gâteau and Allen Winter. Repo

KF5 Update Meeting Minutes 2014-w5

2014-01-28 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 3 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, apol, dMaggot, mgraesslin, Riddell, sebas, teo, tosky and myself. Announcement: * Maintainers! Maintainers! Maintainers! * Don

Re: Where to put QML Bindings for KDE frameworks?

2014-01-28 Thread Marco Martin
On Tuesday 28 January 2014, Aleix Pol wrote: > > Well, there are many different needs, so we'll probably want to have > different solutions for them. > > Bindings to interact with each framework, I'd say they should be installed > by the framework itself, but that's only one case. I think we prob

Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- Review request for KDE Frameworks and Alex Merry. Repository: kimageforma

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Jan. 28, 2014, 2:57 p.m.) Review request for KDE Frameworks. R

Re: Review Request 115353: Rename dbus interface files for solid

2014-01-28 Thread Stefano Avallone
> On Jan. 28, 2014, 2:25 p.m., Jonathan Riddell wrote: > > What does this have that https://git.reviewboard.kde.org/r/114927/ doesn't? > > Pardon me. I somehow missed that review request. - Stefano --- This is an automatically generated

Re: Review Request 115353: Rename dbus interface files for solid

2014-01-28 Thread Stefano Avallone
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115353/ --- (Updated Jan. 28, 2014, 2:28 p.m.) Status -- This change has been di

Re: Review Request 115353: Rename dbus interface files for solid

2014-01-28 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115353/#review48476 --- What does this have that https://git.reviewboard.kde.org/r/114

Re: Review Request 115353: Rename dbus interface files for solid

2014-01-28 Thread Stefano Avallone
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115353/ --- (Updated Jan. 28, 2014, 2:12 p.m.) Review request for KDE Frameworks. R

Re: add test for QFileDialog::getExistingDirectory / bug?

2014-01-28 Thread Kevin Funk
Am Sonntag, 26. Januar 2014, 18:53:42 schrieb Gregor Mi: > With another addition to qfiledialogtest in > frameworks/frameworkintegration another potential bug can be exposed: > > Calling > > $ ./qfiledialogtest --nameFilter "c (*.cpp)" --nameFilter "h (*.h)" > --selectNameFilter "h (*.h)" Works

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

2014-01-28 Thread Aleix Pol Gonzalez
> On Jan. 27, 2014, 7:45 a.m., Kevin Ottens wrote: > > src/lib/kaboutdata.cpp, line 941 > > > > > > Not really my type of thing. It's acting on an object behind our back > > without knowing... what happens to co

Re: Where to put QML Bindings for KDE frameworks?

2014-01-28 Thread Aleix Pol
On Tue, Jan 28, 2014 at 12:58 PM, David Edmundson < da...@davidedmundson.co.uk> wrote: > For a task in Plasma I've had to port KKeySequence to render on > QtQuick, using QtQuickControls. > > I expect over time we will see more KDE widgets having QtQuick > implementations as well. Same for a lot of

Review Request 115353: Rename dbus interface files for solid

2014-01-28 Thread Stefano Avallone
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115353/ --- Review request for KDE Frameworks. Repository: solid Description --

Re: Where to put QML Bindings for KDE frameworks?

2014-01-28 Thread Mark Gaiser
On Tue, Jan 28, 2014 at 12:58 PM, David Edmundson wrote: > For a task in Plasma I've had to port KKeySequence to render on > QtQuick, using QtQuickControls. > > I expect over time we will see more KDE widgets having QtQuick > implementations as well. Same for a lot of our other frameworks, such as

Where to put QML Bindings for KDE frameworks?

2014-01-28 Thread David Edmundson
For a task in Plasma I've had to port KKeySequence to render on QtQuick, using QtQuickControls. I expect over time we will see more KDE widgets having QtQuick implementations as well. Same for a lot of our other frameworks, such as KIO. I can either add these components to KDeclarative, and creat

Re: Review Request 115028: Allow the building of deprecated code to be disabled

2014-01-28 Thread Alex Merry
> On Jan. 27, 2014, 2:14 a.m., Aleix Pol Gonzalez wrote: > > Shouldn't we maybe just remove these? Especially considerign they already > > are deprecated in kdelibs 4. > > > > I don't really like disabling compilation of deprecated symbols, especially > > in this case we're not winning that mu

Re: Review Request 114997: Improve KAuth README.md

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114997/ --- (Updated Jan. 28, 2014, 11:48 a.m.) Review request for KDE Frameworks and

Re: Review Request 115345: Fix kimageformats build with MSVC

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/#review48461 --- Ship it! Hmm, it now appears that PIC was already broken. Bu

Jenkins build is back to stable : ktexteditor_master_qt5 #170

2014-01-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

2014-01-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review48455 --- I agree with Kévin: this doesn't match what the function name

Jenkins build became unstable: ktexteditor_master_qt5 #169

2014-01-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-28 Thread David Faure
On Thursday 23 January 2014 16:08:51 andrea diamantini wrote: > I don't clearly understand why KUriFilter-Plugins should go to plasma- > workspace. I noticed KUriFilter is defined in kio and its plugins are used > e.g. in kparts (browserextension). Shouldn't these go to kio? Agreed. They are neede

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-28 Thread David Faure
On Monday 27 January 2014 15:21:05 David Edmundson wrote: > There is an existing page about slitting runtime here: > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization > > linked to from http://community.kde.org/Frameworks/Epics > > Alex's wiki page looks far more populated. > We

Re: Review Request 115347: Remove Qt5Xml dependency

2014-01-28 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115347/ --- (Updated Jan. 28, 2014, 8:39 a.m.) Status -- This change has been ma