Re: Review Request 115137: Provide information about the active screen in KWindowSystem

> On Jan. 20, 2014, 6 p.m., Thomas Lübking wrote: > > given the ratio by this property is set (often) and read (rarely), i wonder > > whether we could establish a semi-async functionality, where the client > > sends a message to have the property updated, then syncs, reads and returns > > the

Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/#review47854 --- Thanks for pointing out issues in KWindowSystem. I do hope tha

Re: Review Request 115147: Fix non-X11 implementation of KPassivePopup placement

> On Jan. 20, 2014, 3:17 p.m., Martin Gräßlin wrote: > > src/kpassivepopup.cpp, lines 471-473 > > > > > > is this comment still valid? QXcbWindow knows the concept of foreign > > windows. So maybe the code could

Re: Splitting kde-workspace and kde-runtime proposal

Hello! On Tue, Jan 21, 2014 at 1:19 AM, Àlex Fiestas wrote: > In the plasma sprint we have done a session to plan what we are going to do > with kde-workspace/kde-runtime repositories, here is the proposal we came > with. > > We are going to create 2 new repos called plasma-desktop and plasma-wor

Re: QStringLiteral and QTimer in KCompletion tests

On Tue, Jan 21, 2014 at 12:26 AM, David Gil Oliva wrote: > Hi! > > *kcompletionuitest.cpp* > > In kcompletionuitest.cpp I have found many uses of QStringLiteral that > perhaps aren't necessary, but I'm not sure: > > Form1::Form1(QWidget *parent) > : QWidget(parent) > { > setAttribute(Qt::W

QStringLiteral and QTimer in KCompletion tests

Hi! *kcompletionuitest.cpp* In kcompletionuitest.cpp I have found many uses of QStringLiteral that perhaps aren't necessary, but I'm not sure: Form1::Form1(QWidget *parent) : QWidget(parent) { setAttribute(Qt::WA_DeleteOnClose); *setObjectName(QStringLiteral("Form1"));* resize(55

Re: ECM version changed (Re: KDE Frameworks 5 TP1 tarballs)

On Monday, January 20, 2014 11:48:51 PM Albert Astals Cid wrote: > El Dilluns, 20 de gener de 2014, a les 23:39:32, Valentin Rusu va escriure: > > On Monday, January 20, 2014 01:44:37 AM šumski wrote: > > > On Saturday 11 of January 2014 11:15:47 Michael Palimaka wrote: > > > ... > > > > > > > Any

Re: ECM version changed (Re: KDE Frameworks 5 TP1 tarballs)

El Dilluns, 20 de gener de 2014, a les 23:39:32, Valentin Rusu va escriure: > On Monday, January 20, 2014 01:44:37 AM šumski wrote: > > On Saturday 11 of January 2014 11:15:47 Michael Palimaka wrote: > > ... > > > > > Any news on renaming the remaining binaries? > > > > Just to follow up on this

Re: qt configure parameters on Jenkins machine

On Tue, Jan 21, 2014 at 2:00 AM, Michal Humpula wrote: > Hi there, > > does anyone know, what are the ./configure params the Qt is compiled on > Jenkins machine with? There is some failing test in kate due to assertion in > Qt and I'm failing to reproduce the error locally. Please see the followi

Re: Review Request 115093: Add setup.py

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115093/#review47845 --- This review has been submitted with commit ff348b7a8c09e70322

Re: Review Request 115093: Add setup.py

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115093/#review47844 --- This review has been submitted with commit db03a730c22e13a630

Re: Review Request 115093: Add setup.py

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115093/#review47843 --- This review has been submitted with commit 323d101dd376d6d67c

Re: Review Request 115093: Add setup.py

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115093/ --- (Updated Jan. 20, 2014, 10:10 p.m.) Status -- This change has been m

Re: Review Request 115093: Add setup.py

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115093/#review47846 --- This review has been submitted with commit 3868c1e31e034b6bc5

Re: Review Request 115093: Add setup.py

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115093/#review47840 --- Ship it! Looks good, thanks a lot! - Aurélien Gâteau On Ja

Re: CI environment, kwallet & tests that pop windows

On Monday, January 20, 2014 12:32:04 PM David Faure wrote: > On Sunday 19 January 2014 23:02:09 Valentin Rusu wrote: > > Hello, > > > > kwallet-framework tests now (correctly) work when launched from a KF5 > > session. kwalletd pop-ups password dialogs using KF5/Qt5 (yes!). > > > > I also added S

Splitting kde-workspace and kde-runtime proposal

In the plasma sprint we have done a session to plan what we are going to do with kde-workspace/kde-runtime repositories, here is the proposal we came with. We are going to create 2 new repos called plasma-desktop and plasma-workspace, we decided to use plasma as a prefix so in the future we can

Jenkins build is back to stable : ktexteditor_master_qt5 #82

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115147: Fix non-X11 implementation of KPassivePopup placement

> On Jan. 20, 2014, 2:17 p.m., Martin Gräßlin wrote: > > src/kpassivepopup.cpp, lines 471-473 > > > > > > is this comment still valid? QXcbWindow knows the concept of foreign > > windows. So maybe the code could

Review Request 115157: Make better use of KWindowSystem in KPassivePopup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/ --- Review request for KDE Frameworks, Martin Gräßlin and Michael Palimaka. R

Jenkins build became unstable: ktexteditor_master_qt5 #81

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/#review47824 --- given the ratio by this property is set (often) and read (rare

Re: Review Request 115063: Created missing manpage for desktoptojson binary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/#review47823 --- This review has been submitted with commit f03dd455e68f64fdd9

Re: Review Request 115063: Created missing manpage for desktoptojson binary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/ --- (Updated Jan. 20, 2014, 4:59 p.m.) Status -- This change has been ma

Re: Review Request 115093: Add setup.py

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115093/#review47820 --- FWIW it works well for me. - Michael Palimaka On Jan. 17, 2

Re: Review Request 115063: Created missing manpage for desktoptojson binary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/#review47818 --- Ship it! No need for another diff thanks docs/desktoptojson

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/#review47817 --- This review has been submitted with commit c5fe6c274be46d49cb

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/ --- (Updated Jan. 20, 2014, 4:23 p.m.) Status -- This change has been ma

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/#review47816 --- Ship it! Ship It! - Aurélien Gâteau On Jan. 20, 2014, 5:12

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/ --- (Updated Jan. 20, 2014, 4:12 p.m.) Review request for KDE Frameworks, Alb

Re: Review Request 115153: Remove empty autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115153/#review47809 --- This review has been submitted with commit 081080bdc1943e667c

Re: Review Request 115153: Remove empty autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115153/ --- (Updated Jan. 20, 2014, 3:56 p.m.) Status -- This change has been ma

Re: Review Request 115153: Remove empty autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115153/#review47808 --- Ship it! Ship It! - Martin Klapetek On Jan. 20, 2014, 4:41

Re: Review Request 115140: kde-workspace doesn't explicitly need attica anymore

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115140/#review47807 --- This review has been submitted with commit 15d9689732975ce922

Re: Review Request 115140: kde-workspace doesn't explicitly need attica anymore

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115140/ --- (Updated Jan. 20, 2014, 3:49 p.m.) Status -- This change has been ma

Review Request 115153: Remove empty autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115153/ --- Review request for KDE Frameworks. Repository: knotifications Descripti

Re: Review Request 115140: kde-workspace doesn't explicitly need attica anymore

> On Jan. 20, 2014, 3:30 p.m., Christophe Giboudeaux wrote: > > Ship It! I do not have commit rights. Could you please commit the patch? The patch has been formatted with git-format-patch. Thanks! - Stefano --- This is an automatically

Re: Review Request 115140: kde-workspace doesn't explicitly need attica anymore

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115140/#review47802 --- Ship it! Ship It! - Christophe Giboudeaux On Jan. 20, 2014

Re: Review Request 115140: kde-workspace doesn't explicitly need attica anymore

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115140/ --- (Updated Jan. 20, 2014, 3:25 p.m.) Review request for kde-workspace and K

Re: Review Request 115140: Adapt to new attica name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115140/#review47786 --- kde-workspace doesn't explicitly need attica anymore, you coul

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/#review47785 --- src/kmessagewidget.h

Re: Review Request 115147: Fix non-X11 implementation of KPassivePopup placement

> On Jan. 20, 2014, 3:17 p.m., Martin Gräßlin wrote: > > src/kpassivepopup.cpp, lines 471-473 > > > > > > is this comment still valid? QXcbWindow knows the concept of foreign > > windows. So maybe the code could

Re: Review Request 115147: Fix non-X11 implementation of KPassivePopup placement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115147/ --- (Updated Jan. 20, 2014, 2:22 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115147: Fix non-X11 implementation of KPassivePopup placement

> On Jan. 20, 2014, 2:17 p.m., Martin Gräßlin wrote: > > src/kpassivepopup.cpp, line 37 > > > > > > why is the QScreen include needed? Looks like the changes don't use it The line "window->screen()->availableGeom

Re: Review Request 115147: Fix non-X11 implementation of KPassivePopup placement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115147/#review47781 --- src/kpassivepopup.cpp

Review Request 115147: Fix non-X11 implementation of KPassivePopup placement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115147/ --- Review request for KDE Frameworks. Repository: knotifications Descripti

Re: Review Request 115147: Fix non-X11 implementation of KPassivePopup placement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115147/ --- (Updated Jan. 20, 2014, 2:03 p.m.) Review request for KDE Frameworks. R

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/#review4 --- s/screen/output A screen is a virtual surface that may cover

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/ --- (Updated Jan. 20, 2014, 2:14 p.m.) Review request for KDE Frameworks, kde

Re: qt configure parameters on Jenkins machine

On Monday 20 January 2014 14:00:28 Michal Humpula wrote: > Hi there, > > does anyone know, what are the ./configure params the Qt is compiled on > Jenkins machine with? There is some failing test in kate due to assertion in > Qt and I'm failing to reproduce the error locally. You can check the bu

qt configure parameters on Jenkins machine

Hi there, does anyone know, what are the ./configure params the Qt is compiled on Jenkins machine with? There is some failing test in kate due to assertion in Qt and I'm failing to reproduce the error locally. Cheers Michal ___ Kde-frameworks-devel ma

Re: Review Request 115142: add EXPORT_NAME to kf5 template

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115142/#review47766 --- This review has been submitted with commit 4ace48993bc2a8cb18

Re: Review Request 115142: add EXPORT_NAME to kf5 template

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115142/ --- (Updated Jan. 20, 2014, 11:32 a.m.) Status -- This change has been m

Re: CI environment, kwallet & tests that pop windows

On Sunday 19 January 2014 23:02:09 Valentin Rusu wrote: > Hello, > > kwallet-framework tests now (correctly) work when launched from a KF5 > session. kwalletd pop-ups password dialogs using KF5/Qt5 (yes!). > > I also added SKIP for the case where there's no graphical session, thinking > that the

Re: Review Request 115142: add EXPORT_NAME to kf5 template

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115142/#review47765 --- Ship it! Ship It! - Alex Merry On Jan. 20, 2014, 11:07 a.m

Review Request 115142: add EXPORT_NAME to kf5 template

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115142/ --- Review request for KDE Frameworks, Aurélien Gâteau and Gregor Mi. Reposit

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/#review47760 --- src/kwindowsystem.h

Re: Review Request 115120: Clean up the CMake files (and a couple of other bits)

> On Jan. 19, 2014, 8:07 p.m., David Faure wrote: > > src/imageformats/CMakeLists.txt, line 53 > > > > > > Remind me, who uses these desktop files? > > > > Only the kde4support code, right? > > Alex Merr

Review Request 115141: Add a . at the end of command line option descriptions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115141/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/ --- (Updated Jan. 20, 2014, 10:34 a.m.) Status -- This change has been m

Re: Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114904/#review47759 --- This review has been submitted with commit 2748a51aa61f6dbc93

Re: Review Request 114904: Remove KDE4 magic from _SET_FANCY in KDEInstallDirs.cmake

> On Jan. 7, 2014, 9:43 p.m., Alexander Neundorf wrote: > > The motivation was that if somebody had set up carefully his install dirs > > for kdelibs, he simply wanted to point a following project to the same > > CMAKE_INSTALL_PREFIX, and have all the other install dirs automatically use > > t

Re: Review Request 115120: Clean up the CMake files (and a couple of other bits)

> On Jan. 19, 2014, 8:07 p.m., David Faure wrote: > > src/imageformats/CMakeLists.txt, line 53 > > > > > > Remind me, who uses these desktop files? > > > > Only the kde4support code, right? Yep. I must

Review Request 115140: Adapt to new attica name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115140/ --- Review request for kde-workspace and KDE Frameworks. Repository: kde-work

Review Request 115137: Provide information about the active screen in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/ --- Review request for KDE Frameworks, kdewin and kwin. Repository: kwindowsy