----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/#review47777 -----------------------------------------------------------
s/screen/output A screen is a virtual surface that may cover multiple outputs. An output represents a section of the screen geometry that's visible on a monitor. The ID returned by activeScreen() is an output ID. The documentation should explain how the active output relates to the primary output, and how the client is expected to use each. - Fredrik Höglund On Jan. 20, 2014, 1:14 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115137/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2014, 1:14 p.m.) > > > Review request for KDE Frameworks, kdewin and kwin. > > > Repository: kwindowsystem > > > Description > ------- > > The rational for these changes is based on the discussion in > http://article.gmane.org/gmane.comp.kde.devel.plasma/27579/ > > Plasma needs to know which is the active screen and so far only KWin knows > it, so we need to make everybody aware of it. > > --- > Add convenient wrapper for active screen to KWindowSystem > > A method is added to get the identifier of the active screen as a > QString and a signal whenever the active screen changes. This method > is only provided for X11, on Windows and Mac a null QString is returned > as the identifier. > > Add an active screen property to NETRootInfo > > The active screen is intended to be set by KWin to the active screen > it's using. This can be used by a Client to manually position e.g. > override redirect windows on the active screen. It's intended as a help > for multi-screen setups where a Client can only do guesses on where to > position e.g. a notification window. > > It's a KDE specific extension as property _KDE_NET_ACTIVE_SCREEN and > announced in the supported properties. > > > Diffs > ----- > > autotests/netrootinfotestwm.cpp 120fbee92d0b22862d8ce746b3b30891ecd9f056 > src/kwindowsystem.h 5bcfd062dcca42d282b70d0683d4ee1da88cc814 > src/kwindowsystem_mac.cpp 8bd2ac763fa26ba49e7733fc3ba93e755383928c > src/kwindowsystem_win.cpp 96148b2d808396a3046204e55fd19d767db017c5 > src/kwindowsystem_x11.cpp 8634240cabc708a608277b34f21c41cee295e48a > src/netwm.h aee6cea5e3b65cf6252b50515e4920cb9c96f240 > src/netwm.cpp 266afccaf111e6707493b18dad1d9c03dde1d912 > src/netwm_def.h 8b1ccb8bd731aefb9559c8f2b450337b0312ed4d > src/netwm_p.h 41792b330f7405034f4d51fb31a4de5dd674b6d0 > > Diff: https://git.reviewboard.kde.org/r/115137/diff/ > > > Testing > ------- > > * wm part of NETWM is unit tested > * KWindowSystem is only compile tested (unit testing is difficult as we need > a window manager which supports this property which is at the moment of this > writing: none) > * Windows and Mac is not even compile tested, that's why kdewin is included > in the review. If you have the time for it, please do a compile test. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
