Review Request 114356: Move KGlobalAccel from XmlGui into an own tier1 framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114356/ --- Review request for KDE Frameworks and Martin Klapetek. Repository: kdelibs

Jenkins build became unstable: kdelibs_frameworks_qt5 #1831

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114333: Add KF5 prefix for tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114333/#review45361 --- Ship it! Ship It! - Kevin Ottens On Dec. 6, 2013, 2:01 p.m.

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/#review45360 --- Ship it! The moves are still not easily reviewable (thank you

Re: Preparing for the split

On Sunday 08 December 2013 19:03:36 Kevin Ottens wrote: > Hello everyone, > > It is now really time to gear up toward the split. So from now on please > don't create any new patches for the frameworks branch of kdelibs and put > all effort and priority toward getting the existing open patches in >

Preparing for the split

Hello everyone, It is now really time to gear up toward the split. So from now on please don't create any new patches for the frameworks branch of kdelibs and put all effort and priority toward getting the existing open patches in reviewboard properly reviewed and pushed. We have to move fast i

Re: Suggestion: create an own framework for KGlobalAccel

On Sunday 08 December 2013 18:42:25 Kevin Ottens wrote: > On Sunday 08 December 2013 10:16:36 Martin Graesslin wrote: > > Hi, > > > > at the moment KGlobalAccel is part of XmlGui which I consider semantically > > wrong. Global shortcuts have nothing to do with XmlGui and there are quite > > some e

Re: Review Request 114187: KFormat - Add new KFormat class

> On Dec. 4, 2013, 7:32 p.m., Kevin Ottens wrote: > > Any chance for an update addressing the comments raised? John, please update ASAP, it's one of the patch we're waiting for to split. - Kevin --- This is an automatically generated e-

Re: Review Request 114185: Provide our own KFontDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114185/ --- (Updated Dec. 8, 2013, 5:50 p.m.) Status -- This change has been disc

Re: Suggestion: create an own framework for KGlobalAccel

On Sunday 08 December 2013 18:44:59 Martin Graesslin wrote: > On Sunday 08 December 2013 18:04:45 Albert Astals Cid wrote: > > El Diumenge, 8 de desembre de 2013, a les 10:16:36, Martin Graesslin va > > > > escriure: > > > Hi, > > > > > > at the moment KGlobalAccel is part of XmlGui which I consi

Re: Suggestion: create an own framework for KGlobalAccel

On Sunday 08 December 2013 10:16:36 Martin Graesslin wrote: > Hi, > > at the moment KGlobalAccel is part of XmlGui which I consider semantically > wrong. Global shortcuts have nothing to do with XmlGui and there are quite > some examples for applications which need global shortcuts but do not use

Re: Suggestion: create an own framework for KGlobalAccel

On Sunday 08 December 2013 18:04:45 Albert Astals Cid wrote: > El Diumenge, 8 de desembre de 2013, a les 10:16:36, Martin Graesslin va > > escriure: > > Hi, > > > > at the moment KGlobalAccel is part of XmlGui which I consider semantically > > wrong. Global shortcuts have nothing to do with XmlGu

Re: further coinstallability

Stephen Kelly wrote: > Jonathan Riddell wrote: >> but cmake files are harder e.g. /usr/lib/cmake/grantlee >> has files >> which they will want to be co-installable. cmake docs say they can be >> installed into a versioned directory e.g. /usr/lib/cmake/grantlee-5 but >> this needs to be checked an

Re: Suggestion: create an own framework for KGlobalAccel

El Diumenge, 8 de desembre de 2013, a les 10:16:36, Martin Graesslin va escriure: > Hi, > > at the moment KGlobalAccel is part of XmlGui which I consider semantically > wrong. Global shortcuts have nothing to do with XmlGui and there are quite > some examples for applications which need global sh

Re: Tier 3 depending between eachother

El Diumenge, 8 de desembre de 2013, a les 11:46:10, David Faure va escriure: > On Saturday 07 December 2013 17:57:31 Albert Astals Cid wrote: > > Looking at Aurélien's graphs i see that there seem to be a few Tier 3 > > things depending on other Tier 3 things. > > Yep, that's perfectly fine, it's

Re: KDirWatch vs QFileSystemWatcher

On Monday 28 October 2013 08:36:10 Sune Vuorela wrote: > On 2013-10-28, David Faure wrote: > > On Sunday 27 October 2013 22:02:18 Sune Vuorela wrote: > >> Seems to still consistently failing here on windows :/ > > > > Good, consistency is good, we can debug that :) > > > > Can you apply this pat

Re: Tier 3 depending between eachother

On Sunday 08 December 2013 12:41:17 Hugo Pereira Da Costa wrote: > On 12/08/2013 11:46 AM, David Faure wrote: > > On Saturday 07 December 2013 17:57:31 Albert Astals Cid wrote: > >> Looking at Aurélien's graphs i see that there seem to be a few Tier 3 > >> things depending on other Tier 3 things. >

Re: Review Request 114260: Port mouse dataengine

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114260/#review45349 --- plasma/generic/dataengines/mouse/mouseengine.cpp

Re: Tier 3 depending between eachother

On 12/08/2013 11:46 AM, David Faure wrote: On Saturday 07 December 2013 17:57:31 Albert Astals Cid wrote: Looking at Aurélien's graphs i see that there seem to be a few Tier 3 things depending on other Tier 3 things. Yep, that's perfectly fine, it's the definition of tier3, see the first sectio

Re: Suggestion: create an own framework for KGlobalAccel

On Sunday 08 December 2013 10:16:36 Martin Graesslin wrote: > Hi, > > at the moment KGlobalAccel is part of XmlGui which I consider semantically > wrong. Global shortcuts have nothing to do with XmlGui and there are quite > some examples for applications which need global shortcuts but do not use

Re: Tier 3 depending between eachother

On Saturday 07 December 2013 17:57:31 Albert Astals Cid wrote: > Looking at Aurélien's graphs i see that there seem to be a few Tier 3 things > depending on other Tier 3 things. Yep, that's perfectly fine, it's the definition of tier3, see the first section in http://community.kde.org/Frameworks/

Re: Review Request 114328: re-add customstyleelement suite to kstyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114328/ --- (Updated Dec. 8, 2013, 10:24 a.m.) Status -- This change has been mar

Re: Review Request 114328: re-add customstyleelement suite to kstyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114328/#review45342 --- This review has been submitted with commit 278f2ed5630e21bba28

Suggestion: create an own framework for KGlobalAccel

Hi, at the moment KGlobalAccel is part of XmlGui which I consider semantically wrong. Global shortcuts have nothing to do with XmlGui and there are quite some examples for applications which need global shortcuts but do not use xml gui (e.g. everything in the desktop shell). My suggestion is to m